summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Support different color pallete when not signed inv2.1.7-rc2Shawn O. Pearce2011-05-209-79/+125
| | | | | | | | | If the user is not signed in a different theme of colors can be applied to the UI, making it more obvious that login is necessary. Bug: issue 913 Change-Id: Id8c780042740b3b93dcee7ed84b3f9f6be06d9de Signed-off-by: Shawn O. Pearce <sop@google.com>
* Merge changes I14eb9d19,I8f6d5c5a into stableShawn O. Pearce2011-05-202-3/+3
|\ | | | | | | | | | | * changes: Send new patchset event after its available Enable git:// download URLs if canonicalGitUrl set
| * Send new patchset event after its availableShawn O. Pearce2011-05-201-2/+1
| | | | | | | | | | | | | | | | | | | | | | gerrit stream-events sent notification of a new patch set before it created the reference in the Git repository. This confused some CI systems that were able to read the stream-events message and look for the reference before the server was able to create it. Bug: issue 755 Change-Id: I14eb9d19984701eb9afbb13e006a24057e8c3473 Signed-off-by: Shawn O. Pearce <sop@google.com>
| * Enable git:// download URLs if canonicalGitUrl setShawn O. Pearce2011-05-201-1/+2
| | | | | | | | | | | | | | | | | | | | If the administrator has set gerrit.canonicalGitUrl but has left the download.scheme variable unset to its default, assume they want to use git:// as a type of download and enable it. Bug: issue 966 Change-Id: I8f6d5c5a3d16821d07c61f16bce9680a7e0721e5 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | Merge "Add config setting to only suggest users which are in a visible ↵Shawn Pearce2011-05-203-0/+20
|\ \ | |/ |/| | | group" into stable
| * Add config setting to only suggest users which are in a visible groupEdwin Kempin2011-05-203-0/+20
| | | | | | | | | | | | | | | | | | Add a new setting for the suggest section in the Gerrit configuration that limits the suggested users to those which are in at least one group that is visible to the current user. Change-Id: I89654bfdf63e2b780c5e0c93ee54b14afc1640a0 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | Fix NPE on Gerrit startup if mail.from doesn't include a nameEdwin Kempin2011-05-201-2/+2
|/ | | | | | | | | If for mail.from in the gerrit.config only an e-mail address but no name was set, Gerrit failed on startup with a NullPointerException. Bug: issue 961 Change-Id: Ie99a6c7ae42d77e408bc624408b2d13c8b5f9797 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Fix unused and deprecation warningsShawn O. Pearce2011-05-193-15/+2
| | | | | | | | Despite our best efforts to resolve warnings, some new ones slipped in late this afternoon. Change-Id: I4b8f8bba08de2d5c7a2a03c04d121c0e447bfa8e Signed-off-by: Shawn O. Pearce <sop@google.com>
* Merge "Adds a "revert change"-button to a submitted patchset." into stableShawn Pearce2011-05-1918-1/+425
|\
| * Adds a "revert change"-button to a submitted patchset.Gustaf Lundh2011-05-1918-3/+425
| | | | | | | | Change-Id: I409e656c88a7021f604c021ca3987d2e917c18d9
* | Fix assertion caused by early key-rebinding in ChangeScreenShawn O. Pearce2011-05-191-3/+3
| | | | | | | | | | | | | | | | | | | | Keys cannot be registered until the prior screen has dropped its key bindings. Move the activation of the current patch set into the registerKeys() routine of ChangeScreen, where its legal to register (or re-register) the key bindings. Change-Id: I24bba5a09bd9f1452e01bdb5685e2b332aa51106 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | Implement web interface for patches diffmonica.dionisio2011-05-199-41/+238
| | | | | | | | | | | | | | | | | | | | | | Support diff between patches in the change screen. Allow changing patches base comparison. All displayed patches can now have their files listed and compared to target branch or to a specific patch of the change. Bug issue: 194 Change-Id: I617cbe647338b8a4fb71788f04ab6e2c952780fc
* | Support diff between patch setsmonica.dionisio2011-05-196-22/+92
| | | | | | | | | | | | | | | | | | | | | | Pass through arguments for diff between patch sets Modify internal APIs to pass through the old, new and preferences needed to compute the differences between two patch sets for the UI. Bug: issue 194 Change-Id: I98827bf88227e912860769f22cd90f5c35b784b0
* | Fix connectivity check for new branchesShawn O. Pearce2011-05-191-0/+7
| | | | | | | | | | | | | | | | | | If a branch did not yet exist (e.g. a new project with no commits) Gerrit refused to allow uploading a new change for review, as the new commit was not connected to the history. Change-Id: Ie0beca2c51751d618655dcb739ff94de87ace75b Signed-off-by: Shawn O. Pearce <sop@google.com>
* | Merge "Documenting when different regexp libraries are used" into stableShawn Pearce2011-05-194-12/+35
|\ \
| * | Documenting when different regexp libraries are usedMagnus Bäck2011-05-194-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation hasn't been clear on which regular expression implementations were used when e.g. interpreting different configuration variables. In trivial cases this doesn't matter as most regular expression metacharacters are widely supported, but for complex expressions it can be beneficial to know. Change-Id: I2a479aba68779cf857dac9999bc4a90ac2685838
* | | Delete unused setDest() in MergedSenderShawn O. Pearce2011-05-192-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | We moved the private instance member this used to populate, as it was never read (and is thus dead code). But we forgot to also delete the now-dead setter. Change-Id: I5ef5897c58f32c88908c5134ef8221b1d938f970 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | Delete dead code computing domain of ActiveDirectoryShawn O. Pearce2011-05-191-10/+0
| | | | | | | | | | | | | | | | | | | | | We no longer use the default domain computation. Change-Id: Id08974efbb19e7aef8ed7ed9c43eb03a93d34047 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | init: Fix prompting for Account BaseDNShawn O. Pearce2011-05-191-0/+5
| | | | | | | | | | | | | | | | | | | | | This was accidentally dropped as dead code. Change-Id: Ie5d5f6425829c8f1361ea05eb71266aab75986eb Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | Merge "Fix calculation of project owners" into stableShawn Pearce2011-05-192-5/+39
|\ \ \
| * | | Fix calculation of project ownersEdwin Kempin2011-05-192-5/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calculating the owners of a project the ref pattern to which the OWN access rights are assigned are ignored and the inherited OWN access rights are also not taken into account. There are two use-cases for which the owners of a project must be calculated: 1. e-mail notification for project owners about new changes: This e-mail notification should only be sent to the local project owners (the groups to which the OWN access right is assigned on this project). In case there are no local owners for a project this e-mail notification should be sent to the local owners of the nearest parent project that has local owners. 2. resolving of the system group 'Project Owners': The 'Project Owners' system group should be resolved to all groups that are allowed to administrate the project. These are the local owners plus the inherited owners. For both use cases we have to filter the OWN access rights to only those access rights that are assigned for the ref pattern 'refs/*'. This change implements the logic described above. Change-Id: Ib90014caf628db00250694f00741076db0492113 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | | | Merge "Go back to change screen if 'Publish and Submit' fails on submit" ↵Shawn Pearce2011-05-191-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | into stable
| * | | Go back to change screen if 'Publish and Submit' fails on submitEdwin Kempin2011-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'Publish and Submit' action is not atomic. This means if the submit fails the comments and approvals will still be published. If the screen stays with the PublishCommentScreen on submit failure there is no indication for the user that the comments and approvals were actually published. To make this more obvious we now go back to the change screen before displaying the submit error. On the change screen the user can then see that the comments and approvals were successfully published. Bug: issue 963 Change-Id: I9fcfd6b89b53db6f672d79714c6942fa953e5dd9 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | | | Move ANTLR code to its own packageShawn O. Pearce2011-05-1910-21/+463
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This way we can set the Eclipse warnings/error reporting for the generated code to ignore problems we normally try to prevent in human written sources. Change-Id: I0b32d4ebf95611f58468a14e81489bf76f5d7603 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix GWT DeferredCommand deprecationsShawn O. Pearce2011-05-196-23/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Move to the new Scheduler API. It hasn't been deprecated yet. Change-Id: Icfe5d6a53f362a97e798afae9f8eb984b13e8ae5 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix SuggestBox related deprecation warningsShawn O. Pearce2011-05-194-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We always use the DefaultSuggestionDisplay so its reasonable to perform the downcast here to that type in order to control the UI as we want it to behave. Change-Id: Id48fdaf59ece74abe67773c800f23c3b8312ff3c Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix unchecked type warnings in predicate testsShawn O. Pearce2011-05-193-13/+27
| | | | | | | | | | | | | | | | | | | | Change-Id: If9c681e429e8c130c8cdf3f449a889eb234f3d2d Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Add missing serialVersionUID to servletsShawn O. Pearce2011-05-194-0/+6
| | | | | | | | | | | | | | | | | | | | Change-Id: I430066f9f5903d9893882d8c8f3bbbdff8ce4b9e Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix deprecation warning for Thread.stop()Shawn O. Pearce2011-05-191-6/+11
| | | | | | | | | | | | | | | | | | | | Change-Id: Ib1957f3a50c5e65ab5680bb07b43efe368b85fa9 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix SQLNestedException deprecated import warningShawn O. Pearce2011-05-191-5/+9
| | | | | | | | | | | | | | | | | | | | Change-Id: I3cf0b581458939ee434ddc20c4cd25956e9c280a Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Fix more rawtype warningsShawn O. Pearce2011-05-1919-26/+36
| | | | | | | | | | | | | | | | | | | | Change-Id: I50e401a7a604dde7bfad63639bdadb29c2b8a4a9 Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Access static methods by class not instanceShawn O. Pearce2011-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: Iac57284704550da10e7029d22ee051da4a78636d Signed-off-by: Shawn O. Pearce <sop@google.com>
* | | | Undeprecate a few functions that aren't going awayNasser Grainawi2011-05-193-5/+0
| | | | | | | | | | | | | | | | Change-Id: Ifd0199102a8316a9439f3ad931e6def9c8c4cc85
* | | | Remove unnecessary warning suppressionNasser Grainawi2011-05-1913-25/+0
| | | | | | | | | | | | | | | | Change-Id: Iac493ad8be46d29e82ffb3007aadf25a49debfa8
* | | | Use DateTimeFormat getFormat with predefinedFormatNasser Grainawi2011-05-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The get*TimeFormat functions were deprecated, replace with getFormat and specific predefinedFormat fields. Change-Id: Ib2e7a44b75f3d8dcaf2d683466cefd310de126bd
* | | | Replace encodeComponent and decodeComponentNasser Grainawi2011-05-192-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | Use the deprecation replacements encodeQueryString and decodeQueryString. Change-Id: Ib3cf73741b6d3430e9348338204ab3ff07908de9
* | | | Replace isChecked and setCheckedNasser Grainawi2011-05-191-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Use deprecation replacements getValue and setValue. Change-Id: I30c4d9a98c060c41fd1a4f8a68bf41fea7a04c1a
* | | | Remove dead code and unused variablesNasser Grainawi2011-05-1912-54/+4
| | | | | | | | | | | | | | | | Change-Id: If87f7ad452ce597c82872b36a76f32afcc6ab7fd
* | | | Remove unused importsNasser Grainawi2011-05-1924-44/+0
| | | | | | | | | | | | | | | | Change-Id: Ib51584840b6703a14554cc5b3e0aa890fe46234e
* | | | Add parent info to each ChangeScreen PatchSetBlockNasser Grainawi2011-05-197-3/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Parent commit id and short message is placed in a Grid that expands vertically when a patch set has more than one parent. The text "Initial Commit" is used when a patch set has no parents. Change-Id: I5775e8e09b506d9a97d0303e0ba150a926a091e8
* | | | Update JGit to 0.12.1.53-g5ec4977Shawn O. Pearce2011-05-192-2/+2
|/ / / | | | | | | | | | | | | Bug: issue 853 Change-Id: I53941cd6cf64a8c40af03113af250d1f86d83e3e
* | | Disallow to push to non-connected targetStefan Lay2011-05-181-31/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Check if a commit which is pushed to Gerrit is connected to the target branch. If not, disallow the push. Bug: issue 947 Change-Id: Icc61330ed040e8faab7a787c9ba688bde4216cb9 Signed-off-by: Stefan Lay <stefan.lay@sap.com>
* | | Merge "Create Git notes for submitted changes." into stableShawn Pearce2011-05-185-14/+448
|\ \ \
| * | | Create Git notes for submitted changes.Sasa Zivkov2011-05-045-14/+448
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For every submitted change a Git note will be created on the refs/notes/review branch. The format of the note is like: Change-Id: I1745af1cb850829d9d3076cf41fba7845cdc0a63 Code-Review+2: John Doe <john.doe@example.com> Verified+1: John Doe <john.doe@example.com> Submitted-by: John Doe <john.doe@example.com> Submitted-at: Mon, 27 Dec 2010 14:44:17 +0000 Reviewed-on: https://review.example.com/123457 Project: projectName Branch: refs/heads/master To view such notes locally one has to make sure that the refs/notes/review branch is fetched and use the --show-notes=review option of the git log command. Currently, a note is not created for merge commits created by gerrit. The changes done on the refs/notes/review branch are also scheduled for replication. The NoteMapMerger from JGit is now used to merge conclicting note changes. Change-Id: I1745af1cb850829d9d3076cf41fba7845cdc0a63 Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com> Bug: issue 64
* | | | Merge "Better help message when commit message is malformed" into stableShawn Pearce2011-05-181-2/+44
|\ \ \ \
| * | | | Better help message when commit message is malformedUlrik Sjölin2011-05-171-2/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the users commit message does not contain a properly formatted Change-Id the server gives the user a suggestion of an acceptable commit message. Change-Id: I07dd32f82188b9c64c7f66aba325bd5822e8fa74
* | | | | Merge "Re-enable form if 'Publish and Submit' fails to submit" into stableShawn Pearce2011-05-181-0/+6
|\ \ \ \ \
| * | | | | Re-enable form if 'Publish and Submit' fails to submitEdwin Kempin2011-05-191-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If submit fails when a user presses 'Publish and Submit' in the PublishCommentsScreen the form stays disabled so that now it's not possible to publish the voting and the comments without submitting (because the 'Publish' button is disabled). Now it's also not possible to copy a typed in summary comment to the clipboard. This change ensures that the form gets re-enabled if the submit fails. Change-Id: I75a0c55e98d064c4b64eaa78dac30ac202bf411f Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | | | | | Merge "Do not email reviewers adding themselves as reviewers"Shawn Pearce2011-05-181-5/+10
|\ \ \ \ \ \
| * | | | | | Do not email reviewers adding themselves as reviewersMartin Fick2011-05-171-5/+10
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Normally an email is sent to a reviewer when they are added as a reviewer on a change. In the special case that they are the ones adding themselves as a reviwer, do not bother sending them the notification email. Change-Id: Id4c98325bd0e0c8cd141de5fd4fc57b13e258553
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-08 03:58:39 +0000