summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add QtStage permissionv2.16.1-basedJukka Jokiniva2019-03-205-1/+11
| | | | | | | QtStage permission controls stage and unstage functionality. Change-Id: Iea161ee5c2f86c48421c50ee8c6b87d8094d3c68 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Fix warnings when compiling with error_prone_warnings_toolchainPaul Wicking2018-12-181-0/+10
| | | | | | | | | | | | bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Fix submodule urlsFrederik Gladhorn2018-12-181-7/+7
| | | | | | | | | We do not want to mirror all plugins. Make it convenient to work on gerrit. Change-Id: I686e9952292ddcdf5036c3eba5be8ed934a11b44 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Review dialog label extension point for plugin customizationJukka Jokiniva2018-12-181-0/+2
| | | | | | Change-Id: I38d83a5ac33f3766535abbe622010cca42006a66 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Add new status values: staged, integrating and deferredJukka Jokiniva2018-12-185-3/+63
| | | | | | Change-Id: I38c18e98219b9e28863f57e6e70887f25d6c9dfa Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Top level dropdown menu extension point for plugin customizationJukka Jokiniva2018-12-181-0/+2
| | | | | | Change-Id: I8c50c8b42b4340ba305efe25865a8c765f52af78 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Modify Gerrit version string to indicate that this is a Qt forkJukka Jokiniva2018-12-181-1/+1
| | | | | | | Change-Id: I2248e110a327ffc1bb1cf033a6c319117df12d26 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Set version to 2.16.1v2.16.1David Pursehouse2018-12-076-6/+6
| | | | Change-Id: I3c8d4b5bdaf7685148c8102a497a02f74d33bf72
* Merge "Merge branch 'stable-2.15' into stable-2.16" into stable-2.16Alice Kober-Sotzek2018-12-0619-43/+71
|\
| * Merge branch 'stable-2.15' into stable-2.16David Pursehouse2018-12-0519-43/+71
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: Fix invalid json example in POST access endpoint (remove array) ElasticV7QueryChangesTest: Close indices after test Upgrade Testcontainers to 1.10.2 and use ElasticsearchContainer Adapt ElasticV{5,6,7}QueryProjectsTest accordingly, as these are only implemented starting with stable-2.16. Change-Id: I0666decbeda54cae6e59f7bba0caaaf5550f4318
| | * Merge "ElasticV7QueryChangesTest: Close indices after test" into stable-2.15Marco Miller2018-12-042-1/+22
| | |\
| | | * ElasticV7QueryChangesTest: Close indices after testDavid Pursehouse2018-12-042-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For each test method, new indices are created with a unique name based on the test method name. This results in 3 indices (i.e. one each for accounts, changes and groups) for each test method that is run, which in turn results in the number of allocated shards increasing. In Elasticsearch 7.0 a shard limit is introduced [1] which so far only causes a warning. However in a future version (not clear if this means the final 7.0 release or a subsequent one) the limit will be enforced and result in an error. After each test, close the indices that were created. This results in the shards being deallocated, and prevents exceeding the limit. [1] https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html#_cluster_wide_shard_soft_limit Bug: Issue 10120 Change-Id: I6644cf9ee84a6133005d07c2310761707a74b96c
| | * | Fix invalid json example in POST access endpoint (remove array)Florian Ramillien2018-12-041-10/+8
| | |/ | | | | | | | | | | | | Bug: Issue 10106 Change-Id: I0f8a33ca57bc79648beea3ac047e1c2d2002217a
| | * Upgrade Testcontainers to 1.10.2 and use ElasticsearchContainerDavid Pursehouse2018-12-0414-28/+34
| | | | | | | | | | | | | | | | | | | | | | | | Since version 1.10.0 [1] there is an official ElasticsearchContainer. [1] https://github.com/testcontainers/testcontainers-java/releases/tag/1.10.0 Change-Id: I155f9eb0e0bac41c24469e683417eba52f01a80a
* | | SshCommandsIT: Add coverage of the "kill" and "ps" commandsDavid Pursehouse2018-12-061-31/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was only covering commands that are under the "gerrit" root, thus the "kill" and "ps" commands were not included. As a result of lacking test coveraage of the "kill" command, the problem reported in issue 10143 was overlooked. Extend the test to also be able to cover commands that are outside of the "gerrit" root. ImmutableMap.of only works with up to 5 entries, so rework generation of the list of commands to use ImmutableMap.Builder. Coverage of the "scp" and "suexec" commands is still lacking because the "scp" command doesn't seem to have a "--help" option and just hangs when executed, and the "suexec" command requires additional setup. Bug: Issue 10143 Change-Id: I0add49d2c2021d6c2961a3a212704bd5c24da17f
* | | Merge "AbstractQueryChangesTest: Test visibleto predicate with a group" into ↵Edwin Kempin2018-12-061-0/+4
|\ \ \ | | | | | | | | | | | | stable-2.16
| * | | AbstractQueryChangesTest: Test visibleto predicate with a groupDavid Pursehouse2018-12-061-0/+4
| |/ / | | | | | | | | | | | | Bug: Issue 10144 Change-Id: I598a509fb51af664519f7a479b63ffdad001b68b
* | | KillCommand: argument value should not be finalDavid Pursehouse2018-12-061-1/+1
| | | | | | | | | | | | | | | Bug: Issue 10143 Change-Id: Idd46c6d558c2b6f2636aef143588fec199d34ac7
* | | Update git submodulesLuca Milanesio2018-12-061-0/+0
|/ / | | | | | | | | | | | | | | | | | | | | | | * Update plugins/reviewnotes from branch 'stable-2.16' to 53333b3e3f70dfe14ce4c937246a00a2e4bfa3a0 - Adapt injection of UrlFormatter to DynamicItem Since I375245647 the UrlFormatter is not bound anymore directly but through a DynamicItem. Bug: Issue 10131 Change-Id: I3da6397bab34569029db4e3d6fd9b80a7197381b
* | Merge "Merge branch 'stable-2.15' into stable-2.16" into stable-2.16Marco Miller2018-12-0423-154/+142
|\ \
| * | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2018-12-0423-154/+142
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: ElasticContainer: Remove unneeded environment setting Remove redundant "testName" methods from Elasticsearch tests ElasticVersionTest: Add supportedVersion asserts for V7_0 Add support for Elasticsearch 7 Allow to set Elasticsearch number of shards and replicas Discontinue support for Elasticsearch 2.4.x ElasticSetting.Builder: Make methods return 'this' Add link to security documentation for Elasticsearch 6.5 ElasticVersionTest: Add missing tests for 6.5.x This merge also makes necessary changes related to the project index which is not implemented on stable-2.15: - Remove the tests for version 2.4.x - Add tests for version 7 Change-Id: Id39158eb94aa71a8a5b22702ccc2009f4ce48b8c
| | * ElasticContainer: Remove unneeded environment settingDavid Pursehouse2018-12-041-3/+0
| | | | | | | | | | | | Change-Id: Ifc237dc97602152da13d399ef1ace72daec8c954
| | * Remove redundant "testName" methods from Elasticsearch testsDavid Pursehouse2018-12-049-45/+9
| | | | | | | | | | | | | | | | | | | | | | | | All the Elasticsearch test classes inherit from GerritBaseTests, which has a getSanitizedMethodName method. Remove the testName methods defined in all of the test classes, and use getSanitizedMethodName instead. Change-Id: Ie834a087130fdecffd8bdc6eaa72fe53ab91d6eb
| | * ElasticVersionTest: Add supportedVersion asserts for V7_0Marco Miller2018-12-031-0/+3
| | | | | | | | | | | | | | | | | | As the previous or base commit 3a5cc19 would have done so. Change-Id: I63e1493bf43e771c6bbdd59331d383d39807efdf
| | * Add support for Elasticsearch 7David Pursehouse2018-11-3011-12/+261
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The integration for Elasticsearch 6 works with Elasticsearch 7 without any adjustments (meaning all the tests pass), however all POSTs to the _search URL result in a deprecation warning: "The {index}/{type}/_search endpoint is deprecated, use {index}/_search instead" Add handling of this in the query adapter so that the type is omitted on _search requests for Elasticsearch 7. Change-Id: Ib3796f5f41336b5c80c1186aa87809fd5d571fb8
| | * Allow to set Elasticsearch number of shards and replicasDavid Pursehouse2018-11-304-6/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current latest version of Elasticsearch, the number of shards and replicas are set to 5 and 1 respectively if not explicitly set. From version 7, the default number of shards will be changed to 1, and to continue using 5 it must be explicitly set when creating the index. Explicitly set the values when creating the index, but allow them to be changed in the gerrit.config. Default the new configurations to 5 and 1 to be consistent with the current defaults. Bug: Issue 9768 Change-Id: Ia6bc925757f7bf4450d4c8feb21cf838671344f8
| | * Discontinue support for Elasticsearch 2.4.xDavid Pursehouse2018-11-3011-253/+7
| | | | | | | | | | | | | | | | | | | | | | | | Soon we will add support for Elasticsearch 7.0, which means we will have 4 sets of tests (2.4, 5.x, 6.x, 7.x). Let's reduce that by dropping support for 2.4 which is already really old by now. Change-Id: I1801759913cc03c889ca3e2adc2f555c4fc8a21f
| | * ElasticSetting.Builder: Make methods return 'this'David Pursehouse2018-11-301-6/+5
| | | | | | | | | | | | | | | | | | | | | When the methods return the builder instance, calls to them can be chained together in a single statement. Change-Id: I8284a123969658e6501d7d396c0712cecd0a733a
| | * Add link to security documentation for Elasticsearch 6.5David Pursehouse2018-11-301-0/+1
| | | | | | | | | | | | Change-Id: I52eb2953d0f588ce25f9c229f4d8d1be50296166
| | * ElasticVersionTest: Add missing tests for 6.5.xDavid Pursehouse2018-11-271-0/+3
| | | | | | | | | | | | Change-Id: I37ad7c498a60ec17acdd77916e8ea395bb65fe60
* | | Update git submodulesLuca Milanesio2018-12-041-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/hooks from branch 'stable-2.16' to 25ac76fe18537c33f9f27c5463a081449c13ba67 - Adapt injection of UrlFormatter to DynamicItem Since I375245647 the UrlFormatter is not bound anymore directly but through a DynamicItem. Bug: Issue 10132 Change-Id: I621573b5246d1d2fcbc6ef03d3d1819c1525625e
* | | Do not create postgresql index on an inexisting tableHugo Arès2018-12-031-1/+0
|/ / | | | | | | | | | | | | This table was deleted, this leftover index was preventing from starting a new installation with postgresql. Change-Id: I10a74ced51c88562249e0e37d4d71cc07d092710
* | Merge "Fix assignee getting the owner's status on change list" into stable-2.16David Pursehouse2018-11-292-1/+5
|\ \
| * | Fix assignee getting the owner's status on change listPaladox none2018-11-272-1/+5
| | | | | | | | | | | | Change-Id: I243cf476eb6881522c08686bff1deb3c633a5479
* | | Fix IAE when listing reviewers of change that has reviewers by emailEdwin Kempin2018-11-292-14/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewers by email don't have an account ID but formatting reviewers as JSON tried to get account IDs of all reviewers and trying to get an account ID from a reviewer by email fails with an IllegalArgumentException. Reviewers by email only have an email and optionally a name. Since they don't have an account we must not invoke the account loader for them. In addition reviewers by email cannot have approvals so we can skip the approval format step. Listing reviewers of a change is not available through the extension API. This is why the test needs to make a REST call to test this functionality. Change-Id: I97226ddce397f2ae9cc3c3526fbc1c4861e4ee58 Signed-off-by: Edwin Kempin <ekempin@google.com> (cherry picked from commit b7a24723c121fc159962780b2f1ce0e176fe8e90)
* | | BugFix: Add documentation for 'read as' capabilitySabari Ajay Kumar2018-11-271-0/+6
| | | | | | | | | | | | | | | | | | | | | An earlier change that added the 'read as' capability was missing documentation. Change-Id: Id9d75621599177997728df4594f46a5e61f3c2c3
* | | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2018-11-272-3/+3
|\ \ \ | | |/ | |/| | | | | | | | | | | | | * stable-2.15: Upgrade elasticsearch-rest-client to 6.5.1 Change-Id: I57d998de50909f2780115b822f53c0d1884df730
| * | Upgrade elasticsearch-rest-client to 6.5.1David Pursehouse2018-11-222-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to the release notes [1], there are no REST client related bug fixes in this release. This is just to keep up to date with the latest version. Also update ElasticContainer to use version 6.5.1. [1] https://www.elastic.co/guide/en/elasticsearch/reference/current/release-notes-6.5.1.html Change-Id: I04a6c545b8d2e3394e1d02431394d4861244ed30
* | | Merge "Encode project name in download commands" into stable-2.16David Pursehouse2018-11-261-2/+2
|\ \ \ | |_|/ |/| |
| * | Encode project name in download commandsEryk Szymanski2018-11-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows to use download commands in case project name contains any special characters i.e. spaces Bug: Issue 10021 Change-Id: Iac4288559662b0a9beda3d33a06ef2e8c54bc338 Signed-off-by: Eryk Szymanski <eryksz@gmail.com> (cherry picked from commit 8a88d06df1f5dd5a572d1bae703710efa55d0acd)
* | | Document the UrlFormatter interfaceDavid Pursehouse2018-11-261-0/+10
| | | | | | | | | | | | Change-Id: I048b0c1cac8a8b24999170512f66829b032e7f6d
* | | Allow plugin to bind a different implementation of UrlFormatterDavid Pursehouse2018-11-261-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The UrlFormatter interface has a fixed binding to DefaultUrlFormatter which means an alternative binding cannot be provided by a plugin. Change it to a dynamic binding. Change-Id: I37524564793b7dc4cf2ead2161bf180f6266c9ab
* | | Merge "Correct javadoc @link to avoid warning in bazel build //..." into ↵David Pursehouse2018-11-261-2/+3
|\ \ \ | | | | | | | | | | | | stable-2.16
| * | | Correct javadoc @link to avoid warning in bazel build //...Hoa Tran2018-11-261-2/+3
| |/ / | | | | | | | | | | | | Bug: Issue 10004 Change-Id: I2dc7bd84623427d92fb939bcd4c58fbd185f535a
* / / Honor --slave and --headless options betterSaša Živkov2018-11-263-5/+9
|/ / | | | | | | | | | | | | | | | | | | | | Looks like serving PolyGerrit UI never honored the --headless option. In addition, the StaticModule was unnecessarily installed when running in the slave mode. Don't install the StaticModule when running in the slave mode. Don't serve PolyGerrit UI when running in the headless mode. Change-Id: I480a9c33d596feba4516028491684832785b8dc4
* | FakeGroupAuditService: Make audit listener members protectedDavid Pursehouse2018-11-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | The auditListeners is not used in this class, but is needed when running tests on plugins that use audit events. As a workaround to stop Eclipse complaining about it being unused, change its visibility to protected. Also change the other one to keep it consistent. Change-Id: I5769926f4a19079e2f7cd03ca25f6152e1def063
* | Fix some broken links on Change Endpoints documentationAlice Kober-Sotzek2018-11-221-3/+3
| | | | | | | | Change-Id: Ic08f341fabd927539f62e96ff8dd55810719c372
* | Use com.google.inject instead of javax.injectDavid Pursehouse2018-11-208-11/+11
| | | | | | | | | | | | | | Several imports from javax.inject seem to have crept into the code base. Replace them with the com.google.inject equivalents. Change-Id: I02739faf165a0c557aee0f741dbe6504fdfa6433
* | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2018-11-172-0/+2
|\| | | | | | | | | | | | | | | | | * stable-2.15: Add Lawrence Dubé to .mailmap Bazel: Export gerrit-util-cli:cli in plugin API Update git submodules Change-Id: I4c70d8d9638e5cdedb3dcdc3de48d9c92cdd046f
| * Add Lawrence Dubé to .mailmapDavid Pursehouse2018-11-161-0/+1
| | | | | | | | Change-Id: I1d7dc45e0a6906e21c21904603cd31bd46f28670
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-06 00:40:50 +0000