summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add integrating section to change dashboardv2.16.9-basedJukka Jokiniva2019-09-031-1/+8
| | | | | | Fixes: QTQAINFRA-2970 Change-Id: I7448c32b8bbbdd15975eb8518c9bd65fd3f3d7de Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Fix email token routingFrederik Gladhorn2019-08-052-1/+13
| | | | | | | | | | | | | | | page.js changes all '+' signs to spaces, which breaks the email verification confirmation tokens. This change was accepted upstream in the 2.16 branch, whenever we rebase, we can just drop this. In the meantime let's deploy with this patch. Bug: Issue 10062 Fixes: QTQAINFRA-3080 Change-Id: I006c29ffd36b95c7e2605b968a75c5fa7dc34c87 (cherry picked from commit 7fa8f2c5a5fd64c20d31b04ef111255f6a79c1e2) Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Add integrating and staged to search autocompletionFrederik Gladhorn2019-07-111-0/+2
| | | | | | | In the web ui, the search field does otherwise not complete our custom states. Change-Id: I1c863ad20b998608dbbfde40aa61fa5692e5833c Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
* Make chip colors visible for integrating and staged changesFrederik Gladhorn2019-07-111-0/+12
| | | | | | | | Also for deferred, although that's arguably less important. Fixes: QTQAINFRA-2996 Change-Id: I73263dafe6bc5ee715708d9f06113fc89bcbc847 Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
* In dark mode, use a dark header barFrederik Gladhorn2019-06-271-1/+1
| | | | | | | | | | | | The blue is hard on the eyes in any case, with the green logo of ours, it becomes horrible. Use some grey that is already in use for the side-bar and everything looks better. I don't think there is an easy way to override this in the plugin. Fixes: QTQAINFRA-2997 Change-Id: I39664697f6c25c9bbd1fdce9eb9d21f6654940fe Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Use postfix for QtFork in version numberFrederik Gladhorn2019-06-271-1/+1
| | | | | | | | | There are tools parsing the version number and using QtFork-version breaks them. It's generally against conventions (semver). Change-Id: Ie1b91539c2fcb8fe66a7da119e4277a88ef4d291 Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io> Reviewed-by: Aapo Keskimolo <aapo.keskimolo@qt.io>
* Add QtStage permissionJukka Jokiniva2019-06-275-1/+11
| | | | | | | QtStage permission controls stage and unstage functionality. Change-Id: Iea161ee5c2f86c48421c50ee8c6b87d8094d3c68 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Fix warnings when compiling with error_prone_warnings_toolchainPaul Wicking2019-06-271-0/+10
| | | | | | | | | | | | bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Fix submodule urlsFrederik Gladhorn2019-06-271-7/+7
| | | | | | | | | We do not want to mirror all plugins. Make it convenient to work on gerrit. Change-Id: I686e9952292ddcdf5036c3eba5be8ed934a11b44 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Review dialog label extension point for plugin customizationJukka Jokiniva2019-06-271-0/+2
| | | | | | Change-Id: I38d83a5ac33f3766535abbe622010cca42006a66 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Add new status values: staged, integrating and deferredJukka Jokiniva2019-06-275-3/+63
| | | | | | Change-Id: I38c18e98219b9e28863f57e6e70887f25d6c9dfa Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Top level dropdown menu extension point for plugin customizationJukka Jokiniva2019-06-271-0/+2
| | | | | | Change-Id: I8c50c8b42b4340ba305efe25865a8c765f52af78 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Modify Gerrit version string to indicate that this is a Qt forkJukka Jokiniva2019-06-271-1/+1
| | | | | | | Change-Id: I2248e110a327ffc1bb1cf033a6c319117df12d26 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
* Set version to 2.16.9v2.16.9Luca Milanesio2019-06-176-6/+6
| | | | Change-Id: I65c4b998056100c43444d7ad2275e7c0d5c42719
* Merge branch 'stable-2.15' into stable-2.16David Pursehouse2019-06-176-10/+16
|\ | | | | | | | | | | | | | | | | * stable-2.15: Use dom-if instead of css when hiding gr-http-password MysqlAccountPatchReviewStore: Fix duplicate key detection Bazel: Bump minimum supported version to 0.26.1 Change-Id: I0e3fa45a28498777a6d0917e3484a4151dbb9b86
| * Merge branch 'stable-2.14' into stable-2.15David Pursehouse2019-06-173-3/+4
| |\ | | | | | | | | | | | | | | | | | | | | | * stable-2.14: MysqlAccountPatchReviewStore: Fix duplicate key detection Bazel: Bump minimum supported version to 0.26.1 Change-Id: Ibe2385bc61f548422755dd00fbc1de82a01322b0
| | * Merge "Merge branch 'stable-2.13' into stable-2.14" into stable-2.14David Pursehouse2019-06-171-1/+1
| | |\
| | | * Merge branch 'stable-2.13' into stable-2.14David Ostrovsky2019-06-171-1/+1
| | | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.13: MysqlAccountPatchReviewStore: Fix duplicate key detection Change-Id: I66cafb63a530b2daf4c8811fb953507274b892d3
| | | | * MysqlAccountPatchReviewStore: Fix duplicate key detectionDavid Ostrovsky2019-06-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The detection code is checking against SQL error code, even though the SQL state is retrieved from the SQLException. As the consequence, duplicate key state is not detected and primary key violation error is reported during REST API call. To rectify, retrieve the error code number from the SQL exception to correctly detect duplicate key error. This approach is also based on gwtorm code that is also using SQLException#getErrorCode() method. Bug: Issue 10664 Change-Id: I678419a84af287edd8d121bddd2d11c2ed72eefe
| | * | | Bazel: Bump minimum supported version to 0.26.1David Ostrovsky2019-06-142-2/+3
| | |/ / | | | | | | | | | | | | | | | | | | | | Also harmonize the version used for Bazelisk to the same version. Change-Id: I084a4b260e2731b28aef3da37aa815bd06bf6a8d
| * | | Use dom-if instead of css when hiding gr-http-passwordPaladox none2019-06-163-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to prevent users from using css to reshow the gr-http-password screen. Change-Id: I42ca3b5285064b3f9475563927521396b928b7b8
* | | | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2019-06-151-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: Set version to 2.15.15-SNAPSHOT Update buildifier to 0.26 Change-Id: I8036ae88c922f53a00582efc8f6c4b44a9954adf
| * | | Merge branch 'stable-2.14' into stable-2.15David Pursehouse2019-06-151-1/+1
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.14: Update buildifier to 0.26 Change-Id: I4a141285def16fa6d5417bc01267f1ccedc266a8
| | * | Merge "Update buildifier to 0.26" into stable-2.14Luca Milanesio2019-06-141-1/+1
| | |\ \
| | | * | Update buildifier to 0.26David Pursehouse2019-06-111-1/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: Ibfac04b49d291e2116abdaedaabf04bf5e4b7989
| * | | | Set version to 2.15.15-SNAPSHOTDavid Pursehouse2019-06-136-6/+6
| | | | | | | | | | | | | | | | | | | | Change-Id: Id9307120c4c2632a6c3d7cee772635bd1d49b268
* | | | | Highlight .mjs as javascriptPaladox none2019-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: Issue 11020 Change-Id: I42927f81206df10347a266b4778e813f8c5c96d2
* | | | | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2019-06-130-0/+0
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: Set version to 2.15.14 Change-Id: Id7fdc8011fb4b9b303cd8225b59c77ff81d85aed
| * | | | Set version to 2.15.14v2.15.14David Pursehouse2019-06-136-6/+6
| | | | | | | | | | | | | | | | | | | | Change-Id: I028c2c96a9aa830c5494234d349444ebd2196ca3
* | | | | Merge branch 'stable-2.15' into stable-2.16David Ostrovsky2019-06-122-28/+53
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: Bazel: Make build tool chain forward compatible AccountIT: Add test that it is possible to delete all emails Change-Id: I6ed0558e119a538fa695cc2fd7a2081971c87414
| * | | | Merge branch 'stable-2.14' into stable-2.15David Ostrovsky2019-06-121-28/+32
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.14: Bazel: Make build tool chain forward compatible Change-Id: I05fefd79f3a4509aabf2425b52c39b7047e2b160
| | * | | Bazel: Make build tool chain forward compatibleDavid Ostrovsky2019-06-121-28/+32
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disallow rule implementation functions to return struct, and return a collection of provider instances instead. See this upstream issue for more details: [1]. [1] https://github.com/bazelbuild/bazel/issues/7347 Bug: Issue 11015 Change-Id: I376ceb9e22cd89eea6a100c23c7558b6e41b0da1
| * | | AccountIT: Add test that it is possible to delete all emailsDavid Pursehouse2019-06-121-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend the tests to cover the case where all emails are deleted from an account, leaving it with no emails. Change-Id: I6ed0558e119a538fa695cc2fd7a2081971c87414
* | | | Merge "Bump highlight.js version to 9.15.8 release" into stable-2.16Ben Rohlfs2019-06-111-68/+69
|\ \ \ \
| * | | | Bump highlight.js version to 9.15.8 releaseDavid Ostrovsky2019-06-091-68/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Latest highlight.js releases introduced some improvements: [1]. [1] https://github.com/highlightjs/highlight.js/blob/9.15.8/CHANGES.md Change-Id: I97dc6a0c17a2c659aa8777afa8d6d5c0bd95ba2b
* | | | | Merge "LDAP: support servers that do not allow anonymous" into stable-2.16David Pursehouse2019-06-112-6/+34
|\ \ \ \ \
| * | | | | LDAP: support servers that do not allow anonymousAlon Bar-Lev2019-06-102-6/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Although the standard method of transport security of LDAP is startTLS and although rootDSE should support anonymous access, there are some old LDAP implementations that are using non standard ldaps:// and reject anonymous bind. Add ldap.supportAnonymous option to support these servers, default is true per standard and best practice. Change-Id: I594404beececee9f7dcac911b81290e9cbd0b0f4 Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
* | | | | | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2019-06-111-1/+3
|\ \ \ \ \ \ | | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: NewChangeSender: Set "References" header Change-Id: I1afb1044ade36c3f2d8d7993df32b0b730080a9c
| * | | | | NewChangeSender: Set "References" headerDavid Pursehouse2019-06-111-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GMail has changed the way in which emails are threaded in "conversation view" [1] and now the "References" header must also be set on the first mail in a thread. [1] https://gsuiteupdates.googleblog.com/2019/03/threading-changes-in-gmail-conversation-view.html Bug: Issue 10943 Change-Id: I146a0495994c35697c8dcc97bf8385cca9507510
* | | | | | Merge branch 'stable-2.15' into stable-2.16Marco Miller2019-06-103-7/+24
|\| | | | | | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: Change bazel-genfiles to bazel-bin as per Bazel 0.25 AccountIT#deletePreferredEmail: Make assertions more explicit Avoid evaluating submit rules twice for open changes Change-Id: Ia911640d51803723fb22fcdcd6fbceb9a5206eaa
| * | | | Merge branch 'stable-2.14' into stable-2.15Marco Miller2019-06-101-4/+4
| |\ \ \ \ | | | |/ / | | |/| | | | | | | | | | | | | | | | | | | | | | * stable-2.14: Change bazel-genfiles to bazel-bin as per Bazel 0.25 Change-Id: I6b7275e3580c98dbec9fa7a9559bbbdf22ce1661
| | * | | Change bazel-genfiles to bazel-bin as per Bazel 0.25Luca Milanesio2019-06-101-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Bazel 0.25, the bazel-genfiles isn't used anymore as target directory. Everything, including plugins, is generated into bazel-bin. Change-Id: I9521cd7e572ece855cfa79841fcd0b066857fe04
| * | | | AccountIT#deletePreferredEmail: Make assertions more explicitDavid Pursehouse2019-06-101-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After deletion of the preferred email, assert that: - The list of other emails is not only "not empty" but contains exactly the previously existing email address. - The account's email is null. The latter is most likely not the correct behavior, but the intention here is only to document this via a test. If it needs to be fixed, it will be done in a separate commit. Change-Id: I2a500690f7aceeba39d8148c08085842982c73bd
| * | | | Avoid evaluating submit rules twice for open changesLuca Milanesio2019-06-101-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When getting the submit record for a change, the allowClosed() option is irrelevant for extracting the submit record. The change details REST-API ask for the submit record with both strict and lenient modes, which are exactly the same mode for an open change, but trigger two evaluations of the submit rule. When using complex Prolog rules that extract a lot of information, the extra execution could add significant delay and put unnecessary pressure to the CPU. When using plugins for submit rules that do extensive processing of the commit tree, the double evaluation causes even more stress to the filesystem bacause of the double processing Git tree and BLOBs. Bug: Issue 10790 Change-Id: I2d77cf93b53720d6c92745a701358c2489e7a9e7
* | | | | Update codemirror-plugin to latest revision on masterDavid Pursehouse2019-06-101-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The plugin doesn't have a stable-2.16 or stable-3.0 branch, and the additional commits on master are not branch specific: - Bazel: Fix lint warning flagged by buildifier - Add .mailmap - Remove CodeMirror modes that are not supported at Google - Add missing top-level LICENSE file Change-Id: I3d60c0a41ef72242f151febe52ab379faa7a5c5f
* | | | | Merge branch 'stable-2.15' into stable-2.16David Pursehouse2019-06-102-3/+7
|\| | | | | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | * stable-2.15: project.py: Add support for bazel wrapper bazelisk Bazel: Make build tool chain forward compatible Change-Id: Ie43b252be5aede11ce30d77a361017682d24d29f
| * | | Merge branch 'stable-2.14' into stable-2.15David Pursehouse2019-06-102-5/+8
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.14: project.py: Add support for bazel wrapper bazelisk Bazel: Make build tool chain forward compatible Change-Id: I8b1906305937ca3b1fffa05fce03a19d3cbdf882
| | * | Merge "project.py: Add support for bazel wrapper bazelisk" into stable-2.14David Pursehouse2019-06-091-4/+7
| | |\ \
| | | * | project.py: Add support for bazel wrapper bazeliskDavid Ostrovsky2019-06-091-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add --bazel option to allow to pass bazelisk. The default value for bazel executable is not changed and is still bazel. Change-Id: I1bc744b741d04f609c2e8b1c3d9144f820cd4f17
| | * | | Bazel: Make build tool chain forward compatibleDavid Ostrovsky2019-06-081-1/+1
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bazel 0.27 is going to flip incompatible Starlark flag: --incompatible_string_join_requires_strings, see: [1] for more details. [1] https://github.com/bazelbuild/bazel/issues/7802 Bug: Issue 10998 Change-Id: Ibd6c77af8ed1ce5dc86ce88996003f7cf695aa08
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-06 22:35:37 +0000