summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Added a check to prevent NumberFormatExceptionTomas Ljunggren2012-01-091-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since some parameters like review category will not be available at all time the boolean expression evaluator will evaluate expression containing these as false. Task-number: QTQAINFRA-220 Change-Id: Ic0471e52496c3ad74f51321d8a3bc721cdf1aaa1 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
| * | E-mail filter for publish commentsTomas Ljunggren2011-12-123-2/+437
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to have more precise control of when e-mail notifications is sent a filter expression can now be configured in site configuration. An example filter configuration for QT sanity review bot: [review] filter = SRVW < 0 || reviewer != qt_sanity_bot If filter evaluates true the e-mail will be sent Task-number: QTQAINFRA-220 Change-Id: I827c8083ab3fadd7cc898031a9ac046d777f83f8 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | Merge remote-tracking branch 'origin/corrections/qtqainfra-348' into ↵Tomas Ljunggren2012-01-241-8/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | integration/v2.2.1 Change-Id: I8e946c408abf32ec117b91bdcb540b7688b1f63b
| * | | Fixed cherry pick footer settingsOla Bjuremo2011-12-121-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry pick footer options were never read for projects without an access category in the project.config file. This has now been corrected. Task-number: QTQAINFRA-348 Change-Id: I2e8ee0da816a028969b740a5acd034d84e636a4a Reviewed-by: Ola Bjuremo <ola.bjuremo@tieto.com> Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | | Merge remote-tracking branch 'origin/corrections/qtqainfra-355' into ↵Tomas Ljunggren2012-01-244-26/+50
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | integration/v2.2.1 Change-Id: Ic3a458cec3868d2d915bb829dcdc57612493a4a2
| * | | | Hide review panel also on diff and topic pagesTomas Ljunggren2012-01-093-14/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sanity review radio buttons panel now hidden from start. All review panels has toggle visibility capability. Task-number: QTQAINFRA-355 Change-Id: I69c28719547d8d55b669dd1cea49efe0b52bfe7c Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
| * | | | Hide sanity review radio buttonsOla Bjuremo2011-12-072-18/+38
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sanity review category box now starts in hidden mode. All review categories are now expandable boxes. Task-number: QTQAINFRA-355 Change-Id: I28ba61d00aec52da95d2ae6f890d18ed13fce2ac Reviewed-by: Ola Bjuremo <ola.bjuremo@tieto.com>
* | | | Merge remote-tracking branch 'origin/corrections/qtqainfra-381' into ↵Tomas Ljunggren2012-01-241-109/+155
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | integration/v2.2.1 Change-Id: Idb037937e93f6491b45ff7f353777f2440ed2ac2
| * | | | Do not permit trailing slash when pushingOla Bjuremo2011-12-071-109/+155
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reject push to project names with trailing slash. This is to prevent errors when doing scripted reviews. Task-number: QTQAINFRA-381 Change-Id: I0108475f254efc22943eef6a8d58bb1e386e9432 Reviewed-by: Ola Bjuremo <ola.bjuremo@tieto.com>
| * | | Release of JIRA issues: 167 220 270 335 347 350 352 372 375 385 389V2.2.1-NQT-003BL-QTQAINFRA-381BL-QTQAINFRA-355BL-QTQAINFRA-348Tomas Ljunggren2011-12-051-1/+3
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consider sanity review column Fix typo in project config's topic review checkbox label Fixed automatic update of reviewer list Fixed gerrit email verification link requires insecure login Fixed late removal of review approvals Fixed review database update from StagingApprove Keep highlight on review request Release of JIRA issues: 167 270 335 347 350 352 Set patch approval changeOpen to false Change-Id: Ide51fd24b101eaa1c1af98f03190485baeff7d0e
* | \ \ \ Merge remote-tracking branch 'origin/corrections/qtqainfra-375' into ↵Tomas Ljunggren2012-01-241-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | integration/v2.2.1 Change-Id: I6417d592d97e75927a614f7bbfd835f487961488
| * | | | | Topic permalink copy to clipboard correctedTomas Ljunggren2011-12-121-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Topic permalink is no correctly copied to clipboard. Task-number: QTQAINFRA-375 Change-Id: Iea20031c19784e11f68514e0ed408f86afffbf60 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | | | Merge remote-tracking branch 'origin/corrections/qtqainfra-372' into ↵Tomas Ljunggren2012-01-241-8/+15
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | integration/v2.2.1 Change-Id: I85591fa1a3c6cfc632f0ecfebd74bdbcac685795
| * | | | Validate topic current change setTomas Ljunggren2011-12-121-8/+15
| |/ / / | | | | | | | | | | | | | | | | | | | | Change-Id: Ida30a70d86826073f48222257b27d202c512eb90 Task-number: QTQAINFRA-372 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | | Merged correction into integrationV2.2.1-NQT-002RC-V2.2.1-INT-005BL-QTQAINFRA-412BL-QTQAINFRA-411BL-QTQAINFRA-195Tomas Ljunggren2011-12-051-1/+3
|\ \ \ \ | |_|/ / |/| | / | | |/ | |/| | | | Merged 'origin/corrections/qtqainfra-385' into integration/v2.2.1 Change-Id: I7646cc4ad3929a5403b594c5b157fcc9f99f3754
| * | Keep highlight on review requestTomas Ljunggren2011-12-051-1/+3
| |/ | | | | | | | | | | | | | | | | | | Sanity review caused review request highlighting to disappear. Now the flag hasReview is not set to true if approval category equals SRVW Task-number: QTQAINFRA-385 Change-Id: I834a28d937671f7e14cde7586376cc164576c9c8 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | Merged correction into integrationTomas Ljunggren2011-12-052-4/+6
|\ \ | | | | | | | | | | | | | | | Merged 'origin/corrections/qtqainfra-389' into integration/v2.2.1 Change-Id: I78b3bd9af2c68adc4bb2acc6f764e2da3025470a
| * | Set patch approval changeOpen to falseTomas Ljunggren2011-12-052-4/+6
| |/ | | | | | | | | | | Task-number: QTQAINFRA-389 Change-Id: I1c503d392ed4f64d93a8b3637548fb0c47304b8e Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
| * Release of JIRA issues: 167 270 335 347 350 352BL-QTQAINFRA-389BL-QTQAINFRA-375BL-QTQAINFRA-372BL-QTQAINFRA-220Tomas Ljunggren2011-11-160-0/+0
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consider sanity review column Fix typo in project config's topic review checkbox label Fixed automatic update of reviewer list Fixed gerrit email verification link requires insecure login Fixed late removal of review approvals Fixed review database update from StagingApprove Change-Id: Iae780cea31cb0899487f67b566182c242f2ea859
* | \ RC-V2.2.1-INT-003V2.2.1-NQT-001Tomas Ljunggren2011-11-110-0/+0
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | Consider sanity review column Fix typo in project config's topic review checkbox label Fixed automatic update of reviewer list Fixed gerrit email verification link requires insecure login Fixed late removal of review approvals Fixed review database update from StagingApprove Change-Id: I7f1cdd6a104fd17e4a698f97adc9a67b4bb85d86
| * Consider sanity review columnRC-V2.2.1-INT-002Tomas Ljunggren2011-11-112-7/+15
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix typo in project config's topic review checkbox label Fixed automatic update of reviewer list Fixed gerrit email verification link requires insecure login Fixed late removal of review approvals Fixed review database update from StagingApprove Change-Id: I62a4850dc2e58e48670018bfe534665360286b47
* | \ RC-V2.2.1-INT-002Tomas Ljunggren2011-11-112-7/+15
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | Consider sanity review column Fix typo in project config's topic review checkbox label Fixed automatic update of reviewer list Fixed gerrit email verification link requires insecure login Fixed late removal of review approvals Fixed review database update from StagingApprove Change-Id: I0b20af2aa4d0b9b871eba7c081d5298dea610611
| * Consider sanity review columnTomas Ljunggren2011-11-112-7/+15
| | | | | | | | | | | | | | | | | | | | | | Changed the approval summary to consider the sanity review column as sanity reviews are automated. Previously the sanity review checkmark was only visible if reviewer self put +1 in sanity review. Now it accomodates for the approval made by the sanity bot. Change-Id: I64b803ff6f77ebc0c4bbb65ea308bc7a6b4aba72 Task-number: QTQAINFRA-350 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | Fixed gerrit email verification link requires insecure loginPeter Heubeck2011-11-100-0/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixed review database update from StagingApprove Fixed automatic update of reviewer list Fixed late removal of review approvals Fix typo in project config's topic review checkbox label Change-Id: I038838acacc712d0cd367850e19d5c637ce64362
| * | Fixed gerrit email verification link requires insecure loginPeter Heubeck2011-11-101-0/+9
| |/ | | | | | | | | Change-Id: I40e014882b0bff031fa5f2ad242c0ec040075b52 Reviewed-by: Peter Heubeck <peter.heubeck@tieto.com>
* | Merge remote-tracking branch 'origin/corrections/qtqainfra-335' into ↵Peter Heubeck2011-11-100-0/+0
|\ \ | | | | | | | | | integration/v2.2.1
| * | Fixed automatic update of reviewer listTomas Ljunggren2011-11-011-0/+1
| | | | | | | | | | | | | | | | | | Change-Id: I3ca3855bf4e1e4ed9c508c556d92fd8fb1b74ae6 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com> Reviewed-by: Peter Heubeck <peter.heubeck@tieto.com>
* | | Merge remote-tracking branch 'origin/corrections/qtqainfra-352' into ↵Peter Heubeck2011-11-101-1/+1
|\ \ \ | | | | | | | | | | | | integration/v2.2.1
| * | | Fix typo in project config's topic review checkbox labelSergio Ahumada2011-11-021-1/+1
| | |/ | |/| | | | | | | | | | Change-Id: Ied017b0e2c75af529f6cdbd5c93c07968597f464 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | Merge remote-tracking branch 'origin/corrections/qtqainfra-347' into ↵Peter Heubeck2011-11-108-5/+68
|\ \ \ | | | | | | | | | | | | integration/v2.2.1
| * | | Fixed late removal of review approvalsTomas Ljunggren2011-11-108-5/+68
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Added logic to prevent user performing review operation if status of change is INTEGRATING. Task-number: QTQAINFRA-347 Change-Id: Icc2bd5bed618d271041fe6a5669778795537d81c Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
* | | Merge remote-tracking branch 'origin/corrections/qtqainfra-270' into ↵Peter Heubeck2011-11-101-0/+3
|\ \ \ | | | | | | | | | | | | integration/v2.2.1
| * | | Fixed review database update from StagingApproveTomas Ljunggren2011-11-101-0/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a call to ChangeUtil to submit (to DB) all changes that was approved by the SSH command staging-approve. This should remove the changes from the dashboard review requests section. Task-number: QTQAINFRA-270 Change-Id: I5c96180b8868596a57e5cbd794654833e9d038ed Reviewed-by: Peter Heubeck <peter.heubeck@tieto.com>
* / / Fixed gerrit email verification link requires insecure loginPeter Heubeck2011-11-101-0/+9
|/ / | | | | | | Change-Id: I40e014882b0bff031fa5f2ad242c0ec040075b52
* / Fixed automatic update of reviewer listBL-QTQAINFRA-352BL-QTQAINFRA-350BL-QTQAINFRA-270BL-QTQAINFRA-167Tomas Ljunggren2011-11-011-0/+1
|/ | | | | | Change-Id: I3ca3855bf4e1e4ed9c508c556d92fd8fb1b74ae6 Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com> Reviewed-by: Peter Heubeck <peter.heubeck@tieto.com>
* Fixed applyTypeFloor NPEBL-QTQAINFRA-335Mika Hamalainen2011-10-151-1/+2
| | | | | | | | The NPE was caused by old-style staging approvals which were not filtered out as the submit approvals are. Change-Id: I55e1d40c6e2476bd48d371cdf980531af12662be Reviewed-by: Mika Hämäläinen <mika.hamalainen@accenture.com>
* Improved staging SSH command help textsMika Hamalainen2011-09-204-5/+5
| | | | | | | | Added better descriptions and examples for different branches used by staging commands. Change-Id: I4e10c032a10129dfe282de42c8d0abd816fa8598 Reviewed-by: Mika Hämäläinen <mika.hamalainen@accenture.com>
* Removed staging approval categoryMika Hamalainen2011-09-203-67/+0
| | | | | | | | | Removed staging approval category. Staging is handled like submit, and no approval category is used for tracking submit or staging in 2.x version. Change-Id: I90f943a99c4bb689128502e019a141b10c05ef90 Reviewed-by: Mika Hämäläinen <mika.hamalainen@accenture.com>
* Improved help message for staging-rebuild commandMika Hamalainen2011-09-151-1/+1
| | | | | | | | | | Changed branch example to indicate the correct ref for parameter --branch | -b. Change-Id: I51791cb3d73158f8f0f0526a662ccc6f1184f58b Reviewed-on: http://dev-codereview.qt-project.org/40 Reviewed-by: Mika Hämäläinen <mika.hamalainen@accenture.com> Sanity-Review: Mika Hämäläinen <mika.hamalainen@accenture.com>
* Fixed error when pushing to a staged changeMika Hamalainen2011-09-091-1/+3
| | | | | | | | Added check for staging category when analysing approval categories for an existing change. Staging state needs a similar handling as the submitted state. Change-Id: I4fdd0d0e80c6434899502ed6f8a72b8d01fbd2ea
* Fixed cherry pick options in All-ProjectsMika Hamalainen2011-09-091-3/+9
| | | | | | | | Cherry pick options was previously visible also in the All-Projects view. Fixed visibility for cherry pick options panel so that it is visible only for actual projects. Change-Id: I9b9fb131eba7b051a8a00ca1d248225622b44a0b
* Fixed warning from unused importsMika Hamalainen2011-09-062-3/+0
| | | | | | Fixed warnings by removing a few unused imports. Change-Id: I4d8a7f7bee42b0a19bc15ff6f410758acdcd8b2a
* Unstaging support for topicsMika Hamalainen2011-09-067-5/+213
| | | | | | | | | | | | Topics can be now removed from staging. The topic needs to be in STAGED state and the current user must be able to abandon the topic for the remove from staging button to be visible. Each change is separately set to NEW status and the staging branch is rebuild. Change-Id: If8ef39ba9d40e97bd3170a46047041b4939dc290
* Fixed staging button enabling in publish screenMika Hamalainen2011-09-061-0/+1
| | | | | | | | Staging button did not get disabled during RPC request. Fixed the button behavior so that it matches how the other buttons behave in this screen. Change-Id: I408ae8a4b27cff8ca526126c1f74eeb5a743853c
* Fixed add reviewer panel visibilityMika Hamalainen2011-09-061-3/+1
| | | | | | | Topic review feature integration had left add reviewer panel hidden permanently. Re-enabled its visibility. Change-Id: Ided01c7bb66b0273517892f20094ad14d6c0dbb0
* Renamed staging option for review SSH commandMika Hamalainen2011-09-061-1/+1
| | | | | | | The option that merges the patch set to staging is now --stage instead of the previous --staging. Change-Id: Idba8c3bb3681ad547e404eb953c470fa942a50e9
* Fixed a typo in staging-ls helpMika Hamalainen2011-09-051-1/+1
| | | | | | | Fixed a typo in staging-ls command help which is printed out when using --help option. Change-Id: I5aeee7ef3dbe54cf65eb1fdb179cc9ed8a7c8080
* Notification e-mails when build is approvedMika Hamalainen2011-09-026-0/+340
| | | | | | | | Added e-mail notifications for approved and rejected builds. This includes new e-mail templates and sender classes. The e-mails are send from the staging approve command. Change-Id: I159c166ed1e62ecddfbfea0155d6ca278afe1eb7
* Fixed staging-ls destination branch checkMika Hamalainen2011-08-184-24/+57
| | | | | | | | | | | | The destination branch check was not working correctly when listing changes in refs/staging or refs/builds. Added convertion from other branch for refs/heads when checking for destination branch. Staging-ls now requires a new paramater, --destination, to get information about the destination branch. Change-Id: I877c8d504e4eef0214f328b8cf94ed66da5b0210
* Prevent staging changes which belong to a topicMika Hamalainen2011-08-181-6/+6
| | | | | | | | Changes that are are part of a topic should be staged only when topic is staged. Removed option to stage a change if it is part of a topic. Change-Id: I11302ce88fec725e76cc0d18c47544782ecb1610
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-14 17:53:08 +0000