summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Release notes for 2.2.2.2v2.2.2.2Shawn O. Pearce2012-06-212-0/+25
| | | | Change-Id: Idb75651666d9c4570f89bd1db75f3094c1779542
* Fix permissions bug caused by directly inheriting from All-ProjectsShawn O. Pearce2012-06-213-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If any project on a server inherited explicitly from All-Projects using its project.config, for example: [access] inheritFrom = All-Projects and this project's permissions were evaluated early in the lifetime of a server's process, it could poison the permission_sort cache to include access sections from All-Projects twice, while ignoring an identically named section from a child project that inherits from All-Projects indirectly by not having an explicitly declared parent. A unit test has been added to RefControlTest that sets up this case, and thereby poisons the permission_sort cache during the first test of isVisible(). A second test with an unrelated project would fail to consider the READ permission on refs/* for group devs. Without fixes to ProjectState or SectionSortCache this test would fail. ProjectState incorrectly added All-Projects twice, because it did not consider after the loop exited that the project may have been added inside of the loop through an explicit parent reference. Fix this by tracking the All-Projects name in the seen collection just like any other parent reference. SectionSortCache can be poisoned by being fed an input List where the same AccessSection reference exists in multiple positions. If this happens, consider the cache entry to be poison and do not put the sorted result into the cache. Instead always sort these lists on the fly. Change-Id: I2c9d9ccd6b4fb991d317f9709428e681e5bde104
* Adding ReleaseNotes for stable 2.2.2.1 releasev2.2.2.1Martin Fick2012-02-152-0/+54
| | | | Change-Id: Ifb50ba4b133f79bc169801f669400c86a2cea32e
* Update top level SUBMITTING_PATCHESShawn O. Pearce2012-02-142-9/+8
| | | | | | | This document is out of date, the URLs are from last August. Direct readers to the new server. Change-Id: Ib4a66a397c96109bc375d5142c97aa9ef9dc4f7c
* Add contributing guideline documentMartin Fick2012-02-143-0/+243
| | | | Change-Id: Ic4a7c07de198bbbaf12e9d231a65a51f3fceae52
* Documentation: update version references for 2.2.2Carlo Marcelo Arenas Belon2012-02-101-82/+90
| | | | | | | | | | Correct wording and instructions to be sure they match what would be observed with the indicated version of gerrit. Expand instructions when needed to ensure all commands could be executed and were successful. Indent commands and output based on a run of the instructions Change-Id: Ia152069db99890ccc8e06a150100f726996985bd
* Fix change state in patch set approval if reviewer is added to closed changeEdwin Kempin2012-02-101-5/+9
| | | | | | | | | | | | | | | | | | If a reviewer is added to a change, a dummy patch set approval is created for the reviewer so that the change appears in the reviewer's dashboard. In this patch set approval the change state (whether the change is open) is cached. For the dummy patch set approval that is created when a reviewer is added the cached change state is always open, which is incorrect if a reviewer is added to a closed change. As a result the closed change will appear in the reviewers dashboard in the 'Review Requests' section and will stay there forever. This change ensures that the correct change state is cached in the dummy patch set approval when it is created. Bug: issue 1139 Change-Id: I74ee137045010fa0d674328e2179e5031d9c42ec Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Merge "Fix ownerin and reviewerin searches" into stableEdwin Kempin2012-02-083-16/+16
|\
| * Fix ownerin and reviewerin searchesBob Foerster2012-02-083-16/+16
| | | | | | | | | | | | | | | | Update the ownerin and reviewerin searches to use AccountGroup.UUID as required by commit e662fb3d4d7d0ad05791b8d2143ac5ce58117335. Bug: Issue 1171 Change-Id: I0a1b44f522946b219413612d0050f55d4ed46bcf
* | Display hash of the cherry-pick merge in commentDeniz Turkoglu2012-02-071-1/+1
|/ | | | | | | | | After merging a change via cherry-pick, we add the commit's hash to the comment. This was accidentally removed in commit 14246de3c0f81c06bba8d4530e6bf00e918c11b0 Bug: issue 871 Change-Id: I218baf1ea714cad6084ddce269eaa7a543c7081b
* Add index link to the 2.2.2 ReleaseNotesMartin Fick2012-01-271-0/+1
| | | | Change-Id: I8beaf212cbf425f5dfb1b90d96c6d03548986c2b
* Merge "Fix link and improve consistency in 'Prohibited by Gerrit' error doc" ↵v2.2.2Martin Fick2012-01-261-3/+4
|\ | | | | | | into stable
| * Fix link and improve consistency in 'Prohibited by Gerrit' error docEdwin Kempin2012-01-261-3/+4
| | | | | | | | | | Change-Id: I0c01e2de1797019704b58632cee485da1e223d90 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | Improve 'Push Merge Commit' access right documentationEdwin Kempin2012-01-262-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the documentation the 'Push Merge Commit' access right was named 'Push Merge'. Correct the name to be consistent with the name that is displayed in the Gerrit WebUI. In addition remove the link to the 'Push' access right from the documentation of the error 'you are not allowed to upload merges'. When the user gets this error he has already the 'Push' access right assigned and only 'Push Merge Commit' is missing. If 'Push' would be missing the user would get an 'Upload Denied' error. Also the 'Push Merge Commit' documentation explains that it requires 'Push'. This means just having the link to 'Push Merge Commit' should be sufficiant for the 'you are not allowed to upload merges' error description. Change-Id: Idfec58e52ba77c967abb97deb6cc90f42c3395d9 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* | Access control documentation: Linkify conversion tableFredrik Luthander2012-01-261-15/+17
|/ | | | | | | | | | | | This patch adds links to the respective categories referenced in the 2.1.x -> 2.2.x conversion table, hopefully making it more usable when trying to learn the new permission model. Also; Push Tag +3 never existed in 2.1.x, it is now replaced in the table with the old actual way to do it. Change-Id: I1bc5b0746f9383154b13ba4ae51830c778349d8a Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Merge changes Ifccd40c8,I3fc7a181 into stableShawn Pearce2012-01-244-71/+62
|\ | | | | | | | | | | * changes: Access control documentation: Final cleanup Access control documentation: Read and Submit
| * Access control documentation: Final cleanupFredrik Luthander2012-01-231-41/+28
| | | | | | | | | | | | | | | | | | | | | | | | * Removing the disclaimer for outdated documentation. * Add links between different sections, where referred. * Fixed examples where Exclusive flag isn't a prefixing '-' on branch references anymore, but instead it's own tick box. * Removes mention of previously reserved words in the category_id table. Change-Id: Ifccd40c8fe12c570618701c36aa3d1c0ab1705d4 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
| * Access control documentation: Read and SubmitFredrik Luthander2012-01-234-30/+34
| | | | | | | | | | | | | | | | | | | | | | Fine tuning the Read category, now that it's been stripped of all it's legacy surplus features and is a pure read permission. Also purging any old links to it that really should be push / push merge now. Submit category has it's link changed. Change-Id: I3fc7a181bb542cc647adb76df9a772f1fcfa6773 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* | Don't use graphic icons for notes, warnings, etc.Brad Larson2012-01-231-1/+0
|/ | | | | | | | | | | | | | | Change 30758 [1] fixed a bug with showing graphics in the tutorial, but also included the icons folder which attempted to provide graphics for notes, warnings, and other asciidoc sections. These graphics are not currently in our repository and there are licensing concerns with using them. To simplify things, we are not going to include graphics for these icons and will keep the previous 2.2.1 behavior. [1] https://gerrit-review.googlesource.com/#/c/30785/ Change-Id: Ic4132122d8011f4e590d15d5323c0b645835f604 Signed-off-by: Brad Larson <bklarson@gmail.com>
* Merge "Gerrit 2.2.2 Release Notes" into stableMartin Fick2012-01-201-0/+669
|\
| * Gerrit 2.2.2 Release NotesMartin Fick2012-01-191-0/+669
| | | | | | | | Change-Id: I8ec421d3e2ed697c7deb2e7e5afb0a2e14f8b6ec
* | Access control documentation: Push Annotated TagsFredrik Luthander2012-01-202-25/+16
| | | | | | | | | | | | | | | | This change describes what can be done with the Push Annotated Tags access. Change-Id: Ia7ba07208500e6fb85cc0ec67c508871d4596543 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* | Access control documentation: Push MergeFredrik Luthander2012-01-201-8/+11
| | | | | | | | | | | | | | | | This change replaces the Read +3 section under Upload with a new section for the Push merge permission. Change-Id: I6aba1d4fadffd208621ff2f87f24ead0ba142119 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* | Access control documentation: Owner and PushFredrik Luthander2012-01-204-54/+63
| | | | | | | | | | | | | | | | | | | | | | Owner category has it's link changed. Push category takes a lot of rewrite, since the +2 Read access is actually a tweak of push (to a different namespace) now. This impacts many error messages and other references in the documentation. Change-Id: I2a422ace35454b2dbb15ab93aa1243804e0e4b78 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* | Access control documentation: Forge identityFredrik Luthander2012-01-204-28/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This change divides the old forge identity section into three new sections, one for each of author, committer and server identities. The previous scale of permissions is now replaced by three individual permissions not dependant on each other. Some generic text about forging identities is copied to all three sections to increase the ease of use when using this page as a quick lookup reference page. Change-Id: Iff04dea2711560baf3d2f4454b1206dcac775a4c Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* | Access control documentation: Create referenceFredrik Luthander2012-01-202-2/+37
|/ | | | | | | | | Adds new section to cover the create reference permission that's new in Gerrit 2.2.x. Some examples of when to use this permission included. Change-Id: Iad959607394f13aea2b0e1a34e4eda9e22223f9b Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Merge "Fixing asciidoc makefile to include images." into stablev2.2.2-rc1Martin Fick2012-01-111-0/+2
|\
| * Fixing asciidoc makefile to include images.Philipp Altmann2012-01-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | With the next release of Gerrit there will be images in the documentation. With the current makefile they are not included. This patch will solve this problem and include them. With the advent of Internet Explorer 8 all major web browsers now support the data URI scheme for embedded images and this patch use this feature. Bug: issue 1231 Change-Id: I4e675ae42105f38c6ef1287621ac7d738930c82e
* | Merge "Allow loading Project Access when there is no refs/meta/config" into ↵Martin Fick2012-01-113-4/+14
|\ \ | | | | | | | | | stable
| * | Allow loading Project Access when there is no refs/meta/configShawn O. Pearce2012-01-113-4/+14
| |/ | | | | | | | | | | | | | | | | | | | | If the project does not have refs/meta/config the revision is null. Enable loading the access screen anyway with a null revision field, and on save of any edits require the branch to be new. This is already handled by MetaDataUpdate, provided that the base revision we supply is null, so make it @Nullable inside of the ChangeProjectAccess handler. Change-Id: I4417bf802e329eb7193a7cb514f7ebcd7d68f26e
* | Merge "prolog: Fix NoBlock and NoOp functions." into stableMartin Fick2012-01-111-2/+2
|\ \
| * | prolog: Fix NoBlock and NoOp functions.Johan Bjork2012-01-111-2/+2
| |/ | | | | | | | | | | | | Probably been broken since the prolog cafe introduction. The status was never updated, resulting in broken rules. Change-Id: If036577e9827be6263d7470efa2b3f466176d71f
* / Docu-Fix: Correct syntax of SQL statement for inserting approval categoryEdwin Kempin2012-01-111-1/+1
|/ | | | | Change-Id: I23a2219590fd2bd311e985d9c505d93b5276daed Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Documentation: Introducing a quick and dirty setup tutorialFredrik Luthander2011-12-293-0/+328
| | | | | | | | The new document covers quick installation, new project and first upload. It contains lots of quoted output, with a demo style to it. Change-Id: I9404376b527368a8348da507422c3912085e63d9 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: Code reviewFredrik Luthander2011-12-281-11/+17
| | | | | | | Update of the code review sections to reflect the current label. Change-Id: I6d861e894a6a1c90e1029fc2c19c23cee1c44bbe Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: Conversion table between 2.1 and 2.2Fredrik Luthander2011-12-281-0/+38
| | | | | | | | | | | | Since the permissions have been rewritten entirely between Gerrit release series 2.1.x and 2.2.x, a table to ease conversion from 2.1.x is added. The table tries to address the old permissions one by one except for the push tag permission which in effect needed two permissions to work properly. This should be familiar to the administrator used to the 2.1.x permission model however. Change-Id: Id5429138d1170e0881b5331123dfd3e810d3f1c9 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: Reformatted textFredrik Luthander2011-12-281-5/+5
| | | | | | | A short paragraph on access control behaviour is reformatted. Change-Id: I54be9e53d3116b5d178409fbd5a49fb2b311cc00 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: VerifyFredrik Luthander2011-12-281-11/+18
| | | | | | | | Updated some text in the Per project-section and edited the verified section to reflect the current label. Change-Id: I6460cb7a9e95d67730e3bc70e79779e27bdf815f Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: capabilitiesFredrik Luthander2011-12-281-4/+5
| | | | | | | | Adds general information about global capabilities, how the server ownership is administered. Change-Id: Id34eca1e92d25b9e0bfdd30fb14a1d880497ca48 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* First Cut of Gerrit Walkthrough Introduction documentation.Ed Costello2011-12-2812-0/+395
| | | | | | | | | Intended to be a complement for the existing reference documentation to allow potential users to easily get a feel for how Gerrit is used, where it fits and whether it will work for them. Change-Id: Ibbbba36873ee9185d5998eb337b26cc7761b215e Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: Added non-interactive usersFredrik Luthander2011-12-281-18/+39
| | | | | | | | | This change adds the non-interactive user group. It also adds that groups can be members of other groups. The groups are now sorted in alphabetical order. Change-Id: I2cc31de5bc9ede1b6177a005c228ff0c9f72e0e0 Signed-off-by: Fredrik Luthander <fredrik.luthander@sonyericsson.com>
* Access control documentation: Reordering categoriesFredrik Luthander2011-12-281-198/+198
| | | | | | | | Access categories are now sorted to match drop down box in UI This commit is made to prepare for the rewrite of categories in accordance with how they work in the Gerrit 2.2.x series. Change-Id: I7229335f86ce24ec1fceecaea71e3fa1158f15ca
* Added additional information on the install instructions.Fredrik Luthander2011-12-281-17/+58
| | | | | | | The installation instructions presumes much prior knowledge. This is an attempt at making some of that knowledge less implicit. Change-Id: I56195eedbe8c73248e2545a95f2237d16a1d54ed
* Provides a template to the download example.Fredrik Luthander2011-12-281-4/+15
| | | | | | Clarifies that the example host must be replaced with proper hostname. Change-Id: Ib6feef2957a540a3e4635672f70729be2a10f27c
* Provided an example on how to abandon a changeFredrik Luthander2011-12-281-0/+5
| | | | | | | | Added command line example to abandon a certain change. The example was made to be as similar as possible to the previous examples, reusing the same virtual SHA1. Change-Id: I7f2ed88c59856d2a173aed3f8c3e84e4ec187b66
* documentation: update links from kernel.org to code.google.comAugie Fackler2011-12-283-3/+3
| | | | Change-Id: Ie2448e778b10eaf0d35053f373c4fcb2571d3b00
* Update project configuration documentationEdwin Kempin2011-12-281-2/+1
| | | | | | | | | Since the projects are not anymore stored in the Gerrit database there is no SQL insert statement anymore to create new projects. Hence remove the textual reference to such a statement. Change-Id: Ib7eb8adefb41fd0e94d51647a5c0cb9032ca3523 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Rename '-- All Projects --' in documentation to 'All-Projects'Edwin Kempin2011-12-281-5/+5
| | | | | | | | | The wild project that is the root project for all other projects was renamed from '-- All Projects --' to 'All-Projects', but some places in the Gerrit documentation were not updated. Change-Id: I6b908b6e80c9e7861011a23f3b25608728943caf Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Explain 'Automatically resolve conflicts'Edwin Kempin2011-12-281-0/+5
| | | | | | | | In the Gerrit documentation explain the project option 'Automatically resolve conflicts'. Change-Id: Ib43316092001d5f02ba68507c95c7bfd3ad049ce Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
* Update documentation for testing SSH connectionEdwin Kempin2011-12-281-4/+15
| | | | | | | | The command output that is shown in the example and the description how to set the ssh username are outdated. Update both to be correct again. Change-Id: I1529e9c46ba35462ad3bf411b30cfaa4c74cead5 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>