summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'origin/v3.1.8-based' into v3.1.10-basedv3.1.10-basedJukka Jokiniva2020-11-2321-20/+144
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * origin/v3.1.8-based: Add integrating and staged to search autocompletion Make chip colors visible for integrating and staged changes Add integrating section to change dashboard Fix state handling: integrating, staged and deferred must be closed In dark mode, use a dark header bar Add QtStage permission Fix warnings when compiling with error_prone_warnings_toolchain Fix submodule urls Add new status values: staged, integrating and deferred Top level dropdown menu extension point for plugin customization Modify Gerrit version string to indicate that this is a Qt fork Change-Id: Ic4abc25b09adbb8bbb50d2c95601af49b2417c2a
| * Add integrating and staged to search autocompletionv3.1.8-basedFrederik Gladhorn2020-09-221-0/+2
| | | | | | | | | | | | | | | | In the web ui, the search field does otherwise not complete our custom states. Change-Id: I1c863ad20b998608dbbfde40aa61fa5692e5833c (cherry picked from commit 3eea477349b9bd953d36e333fa9442953a072c70) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Make chip colors visible for integrating and staged changesFrederik Gladhorn2020-09-221-0/+12
| | | | | | | | | | | | | | | | | | Also for deferred, although that's arguably less important. Fixes: QTQAINFRA-2996 Change-Id: I73263dafe6bc5ee715708d9f06113fc89bcbc847 (cherry picked from commit 43b3c2bac0996657aaeb907ba39b39d717fc39a0) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Add integrating section to change dashboardJukka Jokiniva2020-09-221-1/+8
| | | | | | | | | | | | | | Fixes: QTQAINFRA-2970 Change-Id: I7448c32b8bbbdd15975eb8518c9bd65fd3f3d7de (cherry picked from commit ff93582e16edfc833ef2197215636b76a823ae33) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Fix state handling: integrating, staged and deferred must be closedFrederik Gladhorn2020-09-221-1/+11
| | | | | | | | | | | | | | | | This is currently how we prevent making changes to them. Change-Id: I7ea146b66eb9f10a2936be89ffa943b71f1ef6c5 (cherry picked from commit b1a8d24cbf39ca79bc0899fee8fa3f714e99debd) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * In dark mode, use a dark header barFrederik Gladhorn2020-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The blue is hard on the eyes in any case, with the green logo of ours, it becomes horrible. Use some grey that is already in use for the side-bar and everything looks better. I don't think there is an easy way to override this in the plugin. Fixes: QTQAINFRA-2997 Change-Id: I39664697f6c25c9bbd1fdce9eb9d21f6654940fe (cherry picked from commit 46edaadfb6c826cf74a1bc381b2c06b851cf5cc0) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Add QtStage permissionJukka Jokiniva2020-09-226-2/+12
| | | | | | | | | | | | | | | | QtStage permission controls stage and unstage functionality. Change-Id: Iea161ee5c2f86c48421c50ee8c6b87d8094d3c68 (cherry picked from commit 3bf45d6f5b4fb0419c5a82a049b00a70d74883de) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Fix warnings when compiling with error_prone_warnings_toolchainPaul Wicking2020-09-221-0/+10
| | | | | | | | | | | | | | | | | | | | | | bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 (cherry picked from commit 2bc3643c321b47c524927f7657eb6312adfdc19e) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Fix submodule urlsFrederik Gladhorn2020-09-221-12/+13
| | | | | | | | | | | | | | | | | | We do not want to mirror all plugins. Make it convenient to work on gerrit. Change-Id: I686e9952292ddcdf5036c3eba5be8ed934a11b44 (cherry picked from commit bd73e96897fa5dceb3e2c3f0debf81383ac88cf7) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Add new status values: staged, integrating and deferredJukka Jokiniva2020-09-225-3/+63
| | | | | | | | | | | | Change-Id: I38c18e98219b9e28863f57e6e70887f25d6c9dfa (cherry picked from commit 2020fc379ebbb578ca42b8f79001932e3a257af3) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Top level dropdown menu extension point for plugin customizationJukka Jokiniva2020-09-224-0/+12
| | | | | | | | | | | | Change-Id: I8c50c8b42b4340ba305efe25865a8c765f52af78 (cherry picked from commit 4ca4a4adc12b2580d488a47c5573556f32c53358) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
| * Modify Gerrit version string to indicate that this is a Qt forkJukka Jokiniva2020-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And also: Use postfix for QtFork in version number There are tools parsing the version number and using QtFork-version breaks them. It's generally against conventions (semver). To make maintaining these changes easier, Ie1b91539c2fcb8fe66a7da119e4277a88ef4d291 was merged into this change. Change-Id: I2248e110a327ffc1bb1cf033a6c319117df12d26 (cherry picked from commit 906b52982263ec5fa06aa4d3a1d94ace9f529e5d) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* | Set version to 3.1.10v3.1.10Luca Milanesio2020-11-135-5/+5
| | | | | | | | Change-Id: I1becfc6730a04bc694cf9140e58a4cca085d01d6
* | Workaround Gitiles bug on All-Users visibilityLuca Milanesio2020-11-132-1/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gitiles has special FilteredRepository wrapper that allows to carefully hide refs based on the project's ACLs. There is however an optimisation that skips the filtering in case a user has READ permissions on every ACLs patterns. When the target repository is All-Users, the optimisation turns into a security issue because it allows seeing everything that belongs to everyone: - draft comments - PII of all users - external ids - draft edits Block Gitiles or any other part of Gerrit to abuse of this power when the target repository is All-Users, where nobody can be authorised to skip the ACLs evaluation. Cover the additional special case of the All-Users project access with two explicit positive and negative tests, so that the security check is covered. Bug: Issue 13621 Change-Id: Ia6ea1a9fd5473adff534204aea7d8f25324a45b7
* | Set version to 3.1.10-SNAPSHOTMarco Miller2020-11-125-5/+5
| | | | | | | | Change-Id: Ib0811a75b49475508b0edba53be51a9d812a6e97
* | Set version to 3.1.9Marco Miller2020-11-125-5/+5
| | | | | | | | Change-Id: I17fa745d38b17b94a63652ff21ed9006541d1e1d
* | Make PermissionBackend#ForRef authoritativePatrick Hiesel2020-11-1111-169/+965
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes a misconception that leads to data being accessible through Gerrit APIs that should be locked down. Gerrit had two components for determining if a Git ref is visible to a user: (Default)RefFilter and PermissionBackend#ForRef (ex RefControl). The former was always capable of providing correct results for all refs. The latter only had logic to decide if a Git ref is visible according to the Gerrit READ permissions. This includes all refs under refs/heads as well as any other ref that isn't a database ref or a Git tag. This component was unware of Git tags and database references. Hence, when asked for a database reference such as refs/changes/xx/yyyyxx/meta the logic would allow access if the user has READ permissions on any of the ref prefixes, such as the default "read refs/* Anonymous Users". That is problematic, because it bypasses documented behavior [1] where a user should only have access to a change if they can see the destination ref. The same goes for other database references. This change fixes the problem. It is intentionally kept to a minimally invasive code change so that it's easier to backport it. Add tests to assert the correct behavior. These tests would fail before this fix. We have included them in this change to be able to backport just a single commit. [1] https://gerrit-review.googlesource.com/Documentation/access-control.html Change-Id: Ice3a756cf573dd9b38e3f198ccc44899ccf65f75
* | Merge branch 'stable-3.0' into stable-3.1Marco Miller2020-11-040-0/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: Update git submodules Set version to 2.16.24-SNAPSHOT Set version to 2.16.23 Change-Id: Ia25617f76c94a6d796a2601163ed28e8fc6af791
| * \ Merge branch 'stable-2.16' into stable-3.0Marco Miller2020-11-040-0/+0
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Update git submodules Set version to 2.16.24-SNAPSHOT Set version to 2.16.23 Change-Id: I3ebaf0908c1b3e360fde02a96dc120dd48b096a9
| | * | Update git submodulesNasser Grainawi2020-10-301-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-2.16' to 8fdb0f9ac0a7f68b3f942cb4a9fd4c94e488ab57 - ReplicationStorageIT: Wait for all pushes without order Some tests don't have a predefined order for which events will be replicated first. Using a timeout based on a single replication event is flawed when we don't know the expected order. Instead, use a timeout for the group of events and ignore the order. For two events replicating to a single remote with a single thread, we expect the complete replication to take twice as long. Two events replicating to two remotes will use one thread each and therefore not take any longer than the single remote case. Change-Id: Ieb21b7eee32105eab5b5a15a35159bb4a837e363
| | * | Set version to 2.16.24-SNAPSHOTLuca Milanesio2020-10-306-6/+6
| | | | | | | | | | | | | | | | Change-Id: Ie3b33382fe2b8d64894f89afc25061ecd17ece90
| | * | Set version to 2.16.23v2.16.23Luca Milanesio2020-10-306-6/+6
| | | | | | | | | | | | | | | | Change-Id: Ia533bb65648b3799fc742ec982058e11712ac78e
* | | | Document jgit options respected by gerrit gcMatthias Sohn2020-11-041-0/+53
| | | | | | | | | | | | | | | | Change-Id: I097dd88d906008d7af1ee9483f6b8ec96380ff72
* | | | Merge branch 'stable-3.0' into stable-3.1Marco Miller2020-10-311-3/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: Update git submodules Documentation: Escape <= characters in user-search.txt Documentation: Provide examples for advanced regexp searching Change-Id: I48d09b04dbde42387a7378715adb54e4001c68dd
| * | | Merge "Merge branch 'stable-2.16' into stable-3.0" into stable-3.0Luca Milanesio2020-10-301-3/+8
| |\ \ \
| | * | | Merge branch 'stable-2.16' into stable-3.0Marco Miller2020-10-301-3/+8
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Documentation: Escape <= characters in user-search.txt Documentation: Provide examples for advanced regexp searching Change-Id: Ie18c40745ebfaca7a6ca0dd672b6aca86bbf36be
| | | * | Documentation: Escape <= characters in user-search.txtVitaliy Lotorev2020-10-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without escaping '<=' is rendered as ⇐ by AsciiDoc. Change-Id: I2223cca45f80c2aaee76d1e84c2de34e966d7620
| | | * | Merge "Documentation: Provide examples for advanced regexp searching" into ↵Marco Miller2020-10-301-0/+5
| | | |\ \ | | | | | | | | | | | | | | | | | | stable-2.16
| | | | * | Documentation: Provide examples for advanced regexp searchingVitaliy Lotorev2020-10-291-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dk.brics regexp syntax reference [1] doesn't contain examples. [1] https://www.brics.dk/automaton/doc/index.html?dk/brics/automaton/RegExp.html Change-Id: I9be2a3e4f1f387ec17f1702831a9bbebc85585be
| * | | | | Update git submodulesNasser Grainawi2020-10-301-0/+0
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.0' to 4604b01e43c3b4aee3d03cb84945b3238c150ede - Merge branch 'stable-2.16' into stable-3.0 * stable-2.16: ReplicationStorageIT: Wait for all pushes without order ReplicationTasksStorage: Add multi-primary unit tests Change-Id: I1d749621c189ee2e49f092ddc7558f83e508411f - ReplicationStorageIT: Wait for all pushes without order Some tests don't have a predefined order for which events will be replicated first. Using a timeout based on a single replication event is flawed when we don't know the expected order. Instead, use a timeout for the group of events and ignore the order. For two events replicating to a single remote with a single thread, we expect the complete replication to take twice as long. Two events replicating to two remotes will use one thread each and therefore not take any longer than the single remote case. Change-Id: Ieb21b7eee32105eab5b5a15a35159bb4a837e363 - Merge "ReplicationTasksStorage: Add multi-primary unit tests" into stable-2.16 - ReplicationTasksStorage: Add multi-primary unit tests These tests examine the replication scenarios under multi-primary setup making use of the api calls present in ReplicationTasksStorage class similarly as done in single primary setup. These tests ensure that the replication compatibility in multi-primary setup is not broken. Change-Id: I375b731829f3c0640d3a7a98635e1e5c526908ca
* | | | | Update git submodulesNasser Grainawi2020-10-301-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to e09b5a08e183d4f92410bfa06289a1784cefb43b - Merge branch 'stable-3.0' into stable-3.1 * stable-3.0: ReplicationStorageIT: Wait for all pushes without order ReplicationTasksStorage: Add multi-primary unit tests Change-Id: I3961368f7bcf7d4aa923d07f7f89beeaaeb307d3 - Merge branch 'stable-2.16' into stable-3.0 * stable-2.16: ReplicationStorageIT: Wait for all pushes without order ReplicationTasksStorage: Add multi-primary unit tests Change-Id: I1d749621c189ee2e49f092ddc7558f83e508411f - ReplicationStorageIT: Wait for all pushes without order Some tests don't have a predefined order for which events will be replicated first. Using a timeout based on a single replication event is flawed when we don't know the expected order. Instead, use a timeout for the group of events and ignore the order. For two events replicating to a single remote with a single thread, we expect the complete replication to take twice as long. Two events replicating to two remotes will use one thread each and therefore not take any longer than the single remote case. Change-Id: Ieb21b7eee32105eab5b5a15a35159bb4a837e363 - Merge "ReplicationTasksStorage: Add multi-primary unit tests" into stable-2.16 - ReplicationTasksStorage: Add multi-primary unit tests These tests examine the replication scenarios under multi-primary setup making use of the api calls present in ReplicationTasksStorage class similarly as done in single primary setup. These tests ensure that the replication compatibility in multi-primary setup is not broken. Change-Id: I375b731829f3c0640d3a7a98635e1e5c526908ca
* | | | | Update git submodulesMartin Fick2020-10-301-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to f3fdc78f71dd4afcf30152e7b653050debf85bef - Merge "ReplicationTasksStorage.Task: Add multi-primary unit tests" into stable-3.1 - ReplicationTasksStorage.Task: Add multi-primary unit tests These tests examine the replication scenarios under multi-primary setup making use of the api calls present in ReplicationTasksStorage.Task class similarly as done in single master setup. These tests ensure that the replication compatability in multi-primary setup is not broken. Change-Id: I980e8286bf11d31c6ab89e49ef065fdde1118181
* | | | | Update git submodulesNasser Grainawi2020-10-301-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to abf3bfd32057db1efab3222fb26a14733db90bd0 - Replication*IT: Share getRef method This helper is common to a couple test classes, so share it. Change-Id: I5839c31ad734c384e812e9e1c7bcba8ba05c23cc - ReplicationFanoutIT: Share setReplicationDestination Refactor setReplicationDestination to share the per-remote-file and single replication config file implementations more. Change-Id: Ic0a98ccf0f7703f14c01856a42b8a70e3d20aa8b - ReplicationFanoutIT: Split shouldReplicateNewBranch tests Split these into storage-based and e2e tests so that the storage tests can be reliably verified through use of replicationDelay large enough that task state on disk doesn't change during the tests. Keep them all in ReplicationFanoutIT for now since the setup for these tests is unique to that class. Also remove the unnecessary cleanup of tasks. Change-Id: I36e0a4affe1f5d1330ea27a496fd8ba295176763 - ReplicationFanoutIT: Remove generic waitUntil helper Using a non-specific timeout is a bad pattern. Tests should pick a timeout appropriate to the action being tested. Change-Id: I69a7e469df1dc532af6a777ac47d89852091797e - ReplicationFanoutIT: Inherit from ReplicationDaemon Reduces duplication across the replication IT classes. More dedup is possible with the helper methods, but leave that for a future change. Change-Id: Iddd6dca9a4fe84b065954cd4dcec7289d7ed68a2 - ReplicationFanoutIT: Refactor setRemoteReplicationDestination Simplify callers by providing a way to set the replicationDelay up front. Change-Id: I28cea83559aa1eb379ec2ff962a0beaf25fe4ca6 - ReplicationFanoutIT: Rename setReplicationDestination Distinguish the methods that set the per-remote config files vs the methods that set the global replication.config. This helps lead up to ReplicationFanoutIT inheriting from ReplicationDaemon. Change-Id: I6139d2dbde15c0b0449d7d7801c169253bc7449d - ReplicationFanoutIT: Cleanup shouldCreateIndividualReplicationTasksForEveryRemoteUrlPair Remove some dead code, use Integer.MAX_VALUE for the replicationDelay so that tasks stay in the waiting/ area of storage for the entire test, and use a dedicated listWaitingTasks() to show it only depends on tasks in that state. Change-Id: I0035a4edc656ed4833249322c45204124a66e20d
* | | | | Merge branch 'stable-3.0' into stable-3.1Marco Miller2020-10-290-0/+0
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: Update git submodules Change-Id: I8d0c764c2d5e335d16051f8dd15b0e0256232516
| * | | | Merge branch 'stable-2.16' into stable-3.0Marco Miller2020-10-290-0/+0
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Update git submodules Change-Id: I62a00efaf5ebe0555cb1db0b36e26d980c9fffb6
| | * | | Update git submodulesMartin Fick2020-10-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-2.16' to 53e083fd0f17d1403b4d150e66655907c1ea139d - Merge "ReplicationTasksStorage: Add multi-primary unit tests" into stable-2.16 - ReplicationTasksStorage: Add multi-primary unit tests These tests examine the replication scenarios under multi-primary setup making use of the api calls present in ReplicationTasksStorage class similarly as done in single primary setup. These tests ensure that the replication compatibility in multi-primary setup is not broken. Change-Id: I375b731829f3c0640d3a7a98635e1e5c526908ca
* | | | | Merge "Merge branch 'stable-3.0' into stable-3.1" into stable-3.1Marco Miller2020-10-293-4/+10
|\ \ \ \ \
| * | | | | Merge branch 'stable-3.0' into stable-3.1Luca Milanesio2020-10-283-4/+10
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: Update git submodules Bump Bazel version to 3.7.0 Documentation: Update dev-release's rc information Update git submodules Fix tests for stable-2.16 branch Remove generation for c.g.gwtexpui.* JavaDoc Fetch JGit JavaDoc from archive.eclipse.org Update git submodules Change-Id: I8a200bc075fe209f27e3fec846fe2d397d133820
| | * | | | Update git submodulesNasser Grainawi2020-10-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.0' to 8650a78b2682c90247435cfd807f0d0bacc84f9c - Move storage portion of replicateBranchDeletion ITs All other ITs split e2e and storage tests on stable-2.16, so this change only updates the new replicateBranchDeletion tests that were added in stable-3.0. The e2e check for if the destination branch is removed or not stays in ReplicationIT and the check that a task is created in storage when the branch delete API is invoked moves to ReplicationStorageIT. This split allows the best practices for verifying e2e and storage to be applied independently. Change-Id: Iec7ee090bd614e3442b1f9cb454437c9e05290be - Merge branch 'stable-2.16' into stable-3.0 * stable-2.16: Refactor Replication*IT tests to share a base class ReplicationIT: Add shouldMatch* e2e tests ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT ReplicationStorageIT: Add shouldFire*ChangeRefs tests Move storage-based ITs into ReplicationStorageIT ReplicationQueue: Remove unused method This change does not try to reimpose the breakdown of tests that was done in 2.16. That will be done in follow up change(s) to improve reviewability of this change. Change-Id: I83202997610c5ad0d8849cb477ca36db8df760f5 - Refactor Replication*IT tests to share a base class These classes have very similar setups and duplicate helper methods. Improve maintainability by reducing the duplication. ReplicationQueueIT is not modified because it is merged into ReplicationIT on stable-3.0. Change-Id: Ibc22ae4d0db2d09009f65c0e745f1095c67827ba - ReplicationIT: Add shouldMatch* e2e tests These new tests utilize creating a branch in a way that does not trigger replication so that scheduleFullSync() is responsible for replicating the update. In this way, the tests verify the destination receives the update because scheduleFullSync() matched the given URI. Change-Id: I4ae15d0301a308a12cbca3684915e89ca421e02f - ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT These tests are focused on verifying storage, so they belong in ReplicationStorageIT. Improve these tests to better verify storage correctness by switching the 'now' parameter to false such that replicationDelay is honored and follow the ReplicationStorageIT pattern using a very long delay. These improvements make these tests much more stable. The tests improve the ref matching slightly by comparing to the PushOne.ALL_REFS constant. Also removes the disableDeleteForTesting flag as there are no users of it now. A later change can add ReplicationIT e2e tests for these use cases. Change-Id: Iaa14a7429a40fb62325259efa1c7d7637deef95a - ReplicationStorageIT: Add shouldFire*ChangeRefs tests Copy the shouldFire*IncompleteUri tests as shouldFire*ChangeRefs to fill a gap in test coverage. Change-Id: Ia8df64a8574b776e6a9f7201c0862f1e6794687e - Move storage-based ITs into ReplicationStorageIT Tests in ReplicationStorageIT utilize very long replication delays such that tasks are never expected to complete during the test. This allows test writers to assume the task files are still there. Refactor tests from ReplicationIT into ReplicationStorageIT and focus them on verifying storage correctness. This is mostly a direct copy except that shouldFirePendingOnlyToStoredUri gets renamed and split into two tests. One that validates tasks are fired and another that validates replication completes to the expected destinations. This split is necessary because of the very long delay methodology mentioned above. Code sharing between ReplicationIT and ReplicationStorageIT will be improved in a later commit. Change-Id: I41179c20a10354953cff3628368dfd5f910cc940 - ReplicationQueue: Remove unused method And drop the misleading @VisibleForTesting annotation from the method the removed method was wrapping. scheduleFullSync() is public so that PushAll can call it. Change-Id: I0139e653654fcaf20de68dddfb5ea85560a323d0
| | * | | | Bump Bazel version to 3.7.0Orgad Shaneh2020-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/bazelbuild/bazel/releases/tag/3.7.0 Change-Id: I4ed5a44a16f57bc6d1a038fa419d20563b3d6fe8
| | * | | | Documentation: Update dev-release's rc informationMarco Miller2020-10-271-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I674cec44628c24002942a9f446bc13f3668fb1be
| | * | | | Merge branch 'stable-2.16' into stable-3.0Marco Miller2020-10-272-1/+2
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Update git submodules Fix tests for stable-2.16 branch Remove generation for c.g.gwtexpui.* JavaDoc Fetch JGit JavaDoc from archive.eclipse.org Update git submodules Change-Id: I8cf99479382398812c8f37630e045bec131f97bc
| | | * | | Merge changes from topic "make-stable-2.16-green-again" into stable-2.16Luca Milanesio2020-10-273-5/+2
| | | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * changes: Fix tests for stable-2.16 branch Remove generation for c.g.gwtexpui.* JavaDoc Fetch JGit JavaDoc from archive.eclipse.org
| | | | * | | Fix tests for stable-2.16 branchDmitrii Filippov2020-10-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the 'manual' tag to wct test_suite templates, so it is excluded from bazel test //... Change-Id: I73fdddc9c08eeaacff9401ea9531c95e6a782ced (cherry picked from commit ae42cd00bdfa8a34e75c563b62f0151a561cc82b)
| | | | * | | Remove generation for c.g.gwtexpui.* JavaDocLuca Milanesio2020-10-231-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The JavaDoc for com.google.gwtexpui.* cannot be generated because the source files are not accessible anymore. Failing to generate the JavaDocs caused the Gerrit build to fail with 'No source files for package com.google.gwtexpui...'. Change-Id: Ie36e650962636813d8f9f615e495a980b7280420
| | | | * | | Fetch JGit JavaDoc from archive.eclipse.orgLuca Milanesio2020-10-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I363ad0df632fdb25236b3d0a0c06fb15dbf8acf2
| | | * | | | Update git submodulesNasser Grainawi2020-10-271-0/+0
| | | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-2.16' to 4cb59f096b84f4369f62c8645db326c61826be79 - Refactor Replication*IT tests to share a base class These classes have very similar setups and duplicate helper methods. Improve maintainability by reducing the duplication. ReplicationQueueIT is not modified because it is merged into ReplicationIT on stable-3.0. Change-Id: Ibc22ae4d0db2d09009f65c0e745f1095c67827ba - ReplicationIT: Add shouldMatch* e2e tests These new tests utilize creating a branch in a way that does not trigger replication so that scheduleFullSync() is responsible for replicating the update. In this way, the tests verify the destination receives the update because scheduleFullSync() matched the given URI. Change-Id: I4ae15d0301a308a12cbca3684915e89ca421e02f - ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT These tests are focused on verifying storage, so they belong in ReplicationStorageIT. Improve these tests to better verify storage correctness by switching the 'now' parameter to false such that replicationDelay is honored and follow the ReplicationStorageIT pattern using a very long delay. These improvements make these tests much more stable. The tests improve the ref matching slightly by comparing to the PushOne.ALL_REFS constant. Also removes the disableDeleteForTesting flag as there are no users of it now. A later change can add ReplicationIT e2e tests for these use cases. Change-Id: Iaa14a7429a40fb62325259efa1c7d7637deef95a - ReplicationStorageIT: Add shouldFire*ChangeRefs tests Copy the shouldFire*IncompleteUri tests as shouldFire*ChangeRefs to fill a gap in test coverage. Change-Id: Ia8df64a8574b776e6a9f7201c0862f1e6794687e - Move storage-based ITs into ReplicationStorageIT Tests in ReplicationStorageIT utilize very long replication delays such that tasks are never expected to complete during the test. This allows test writers to assume the task files are still there. Refactor tests from ReplicationIT into ReplicationStorageIT and focus them on verifying storage correctness. This is mostly a direct copy except that shouldFirePendingOnlyToStoredUri gets renamed and split into two tests. One that validates tasks are fired and another that validates replication completes to the expected destinations. This split is necessary because of the very long delay methodology mentioned above. Code sharing between ReplicationIT and ReplicationStorageIT will be improved in a later commit. Change-Id: I41179c20a10354953cff3628368dfd5f910cc940
| | | * / / Update git submodulesNasser Grainawi2020-10-211-0/+0
| | | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-2.16' to 64617a846c9fa06215031b2ad34a30d58003a732 - ReplicationQueue: Remove unused method And drop the misleading @VisibleForTesting annotation from the method the removed method was wrapping. scheduleFullSync() is public so that PushAll can call it. Change-Id: I0139e653654fcaf20de68dddfb5ea85560a323d0
* | | | | Update git submodulesNasser Grainawi2020-10-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 2be86dab82510bcda4740b9a003e9f64ad43033b - Merge changes I0ef708ab,I81d27fd4 into stable-3.1 * changes: Move shouldCleanupTasksAfterNewProjectReplication test Merge branch 'stable-3.0' into stable-3.1 - Move shouldCleanupTasksAfterNewProjectReplication test This test is focused on the storage level, so move it to ReplicationStorageIT. Slightly improve it to use the new best practices for specifying test timeouts. Change-Id: I0ef708ab7813ee09d6f115d3151d2d12b9984a80 - Merge branch 'stable-3.0' into stable-3.1 * stable-3.0: Move storage portion of replicateBranchDeletion ITs Refactor Replication*IT tests to share a base class ReplicationIT: Add shouldMatch* e2e tests ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT ReplicationStorageIT: Add shouldFire*ChangeRefs tests Move storage-based ITs into ReplicationStorageIT ReplicationQueue: Remove unused method This change does not try to reimpose the breakdown of tests that was done in 3.0. That will be done in follow up change(s) to improve reviewability of this change. Change-Id: I81d27fd47da8eecad3aca36d8e6400679fb564a3 - Move storage portion of replicateBranchDeletion ITs All other ITs split e2e and storage tests on stable-2.16, so this change only updates the new replicateBranchDeletion tests that were added in stable-3.0. The e2e check for if the destination branch is removed or not stays in ReplicationIT and the check that a task is created in storage when the branch delete API is invoked moves to ReplicationStorageIT. This split allows the best practices for verifying e2e and storage to be applied independently. Change-Id: Iec7ee090bd614e3442b1f9cb454437c9e05290be - Merge branch 'stable-2.16' into stable-3.0 * stable-2.16: Refactor Replication*IT tests to share a base class ReplicationIT: Add shouldMatch* e2e tests ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT ReplicationStorageIT: Add shouldFire*ChangeRefs tests Move storage-based ITs into ReplicationStorageIT ReplicationQueue: Remove unused method This change does not try to reimpose the breakdown of tests that was done in 2.16. That will be done in follow up change(s) to improve reviewability of this change. Change-Id: I83202997610c5ad0d8849cb477ca36db8df760f5 - Refactor Replication*IT tests to share a base class These classes have very similar setups and duplicate helper methods. Improve maintainability by reducing the duplication. ReplicationQueueIT is not modified because it is merged into ReplicationIT on stable-3.0. Change-Id: Ibc22ae4d0db2d09009f65c0e745f1095c67827ba - ReplicationIT: Add shouldMatch* e2e tests These new tests utilize creating a branch in a way that does not trigger replication so that scheduleFullSync() is responsible for replicating the update. In this way, the tests verify the destination receives the update because scheduleFullSync() matched the given URI. Change-Id: I4ae15d0301a308a12cbca3684915e89ca421e02f - ReplicationStorageIT: Move shouldMatch* tests from ReplicationIT These tests are focused on verifying storage, so they belong in ReplicationStorageIT. Improve these tests to better verify storage correctness by switching the 'now' parameter to false such that replicationDelay is honored and follow the ReplicationStorageIT pattern using a very long delay. These improvements make these tests much more stable. The tests improve the ref matching slightly by comparing to the PushOne.ALL_REFS constant. Also removes the disableDeleteForTesting flag as there are no users of it now. A later change can add ReplicationIT e2e tests for these use cases. Change-Id: Iaa14a7429a40fb62325259efa1c7d7637deef95a - ReplicationStorageIT: Add shouldFire*ChangeRefs tests Copy the shouldFire*IncompleteUri tests as shouldFire*ChangeRefs to fill a gap in test coverage. Change-Id: Ia8df64a8574b776e6a9f7201c0862f1e6794687e - Move storage-based ITs into ReplicationStorageIT Tests in ReplicationStorageIT utilize very long replication delays such that tasks are never expected to complete during the test. This allows test writers to assume the task files are still there. Refactor tests from ReplicationIT into ReplicationStorageIT and focus them on verifying storage correctness. This is mostly a direct copy except that shouldFirePendingOnlyToStoredUri gets renamed and split into two tests. One that validates tasks are fired and another that validates replication completes to the expected destinations. This split is necessary because of the very long delay methodology mentioned above. Code sharing between ReplicationIT and ReplicationStorageIT will be improved in a later commit. Change-Id: I41179c20a10354953cff3628368dfd5f910cc940 - ReplicationQueue: Remove unused method And drop the misleading @VisibleForTesting annotation from the method the removed method was wrapping. scheduleFullSync() is public so that PushAll can call it. Change-Id: I0139e653654fcaf20de68dddfb5ea85560a323d0
* | | | | Update git submodulesAdithya Chakilam2020-10-281-0/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 61321228045db5c612f321896c9bd07569c44820 - Merge "ReplicationTasksStorage: Add multi-primary unit tests" into stable-3.1 - ReplicationTasksStorage: Add multi-primary unit tests These tests examine the replication scenarios under multi-primary setup making use of the api calls present in ReplicationTasksStorage class similarly as done in single primary setup. These tests ensure that the replication compatability in multi-primary setup is not broken. Change-Id: Ib2d0017c4d2ac3f4cfc7262b68b09a3a357e1337
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 02:08:04 +0000