summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add integrating and staged to search autocompletionv3.1.4-basedFrederik Gladhorn2020-07-021-0/+2
| | | | | | | | | | | In the web ui, the search field does otherwise not complete our custom states. Change-Id: I1c863ad20b998608dbbfde40aa61fa5692e5833c Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io> (cherry picked from commit e599c08e5dcd602ffa403f89218d6d0ce695819a) Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit a9760bd52a1045dc18e645c8a757c2e8b3a21efa) Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Make chip colors visible for integrating and staged changesFrederik Gladhorn2020-07-021-0/+12
| | | | | | | | | | | | Also for deferred, although that's arguably less important. Fixes: QTQAINFRA-2996 Change-Id: I73263dafe6bc5ee715708d9f06113fc89bcbc847 Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io> (cherry picked from commit 28a90db532f2182589aad1bae1c193d467227e08) Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit c300b82db450540fb7224292ceca4901e835ca29) Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Add integrating section to change dashboardJukka Jokiniva2020-07-021-1/+8
| | | | | | | | | Fixes: QTQAINFRA-2970 Change-Id: I7448c32b8bbbdd15975eb8518c9bd65fd3f3d7de Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit b55bcb6893c07dbdb2934051c0b3611771ee4322) Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 1522706179d5fad529ca05259f294edefdb57f07)
* Fix state handling: integrating, staged and deferred must be closedFrederik Gladhorn2020-05-271-1/+11
| | | | | | | | This is currently how we prevent making changes to them. Change-Id: I7ea146b66eb9f10a2936be89ffa943b71f1ef6c5 (cherry picked from commit 07181e06b62134473a7b4086499ee5d02c4e50e1) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* In dark mode, use a dark header barFrederik Gladhorn2020-05-271-1/+1
| | | | | | | | | | | | | The blue is hard on the eyes in any case, with the green logo of ours, it becomes horrible. Use some grey that is already in use for the side-bar and everything looks better. I don't think there is an easy way to override this in the plugin. Fixes: QTQAINFRA-2997 Change-Id: I39664697f6c25c9bbd1fdce9eb9d21f6654940fe Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io> (cherry picked from commit b1d1393a090aeb0f2141a20fa320a163ce4c7239)
* Add QtStage permissionJukka Jokiniva2020-05-276-2/+12
| | | | | | | | | QtStage permission controls stage and unstage functionality. Change-Id: Iea161ee5c2f86c48421c50ee8c6b87d8094d3c68 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 463ea6ef009efa4438745f1831849c48d9d6bb9c) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Fix warnings when compiling with error_prone_warnings_toolchainPaul Wicking2020-05-271-0/+10
| | | | | | | | | | | | | | bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 1e8b667c6fdec5ccc911ba0195878f1237b2d708) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Fix submodule urlsFrederik Gladhorn2020-05-271-12/+13
| | | | | | | | | | We do not want to mirror all plugins. Make it convenient to work on gerrit. Change-Id: I686e9952292ddcdf5036c3eba5be8ed934a11b44 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 331975f737a7e50cc0bd6acd03118826bff2a47c)
* Add new status values: staged, integrating and deferredJukka Jokiniva2020-05-275-3/+63
| | | | | | | | Change-Id: I38c18e98219b9e28863f57e6e70887f25d6c9dfa Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit a94c4951293b837c5bd57610550b508848186dc9) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Top level dropdown menu extension point for plugin customizationJukka Jokiniva2020-05-274-0/+12
| | | | | | | | Change-Id: I8c50c8b42b4340ba305efe25865a8c765f52af78 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 186517bc01425480310aefc13cc433bcf6f56bc5) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Modify Gerrit version string to indicate that this is a Qt forkJukka Jokiniva2020-05-271-1/+1
| | | | | | | | | | | | | | | | | | And also: Use postfix for QtFork in version number There are tools parsing the version number and using QtFork-version breaks them. It's generally against conventions (semver). To make maintaining these changes easier, Ie1b91539c2fcb8fe66a7da119e4277a88ef4d291 was merged into this change. Change-Id: I2248e110a327ffc1bb1cf033a6c319117df12d26 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> (cherry picked from commit 6b00b326863962f3c50188111ba838de339c9985) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Set version to 3.1.4v3.1.4David Pursehouse2020-03-275-5/+5
| | | | Change-Id: I35a0e35528ffb8c071f0b67c235b604f7851ca7f
* Merge branch 'stable-3.0' into stable-3.1David Pursehouse2020-03-260-0/+0
|\ | | | | | | | | | | | | | | * stable-3.0: Set version to 3.0.9-SNAPSHOT Set version to 3.0.8 Change-Id: I2babaaa2bf369e2c9f9538447d9f2b1385a39744
| * Set version to 3.0.9-SNAPSHOTDavid Pursehouse2020-03-265-5/+5
| | | | | | | | Change-Id: If14b8433bb87475f3af777b00d499bf376133cfe
| * Set version to 3.0.8v3.0.8David Pursehouse2020-03-265-5/+5
| | | | | | | | Change-Id: I7aefa623fba9767b64e4b09176e74cb506b9dba9
* | Update git submodulesMarcin Czech2020-03-251-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 89518b87c184345edd34b7e67ab2896253643611 - Use ReplicationConfig interface instead of ReplicationFileBasedConfig ReplicationFileBasedConfing is an implementation of the ReplicationConfig interface. Using ReplicationFileBasedConfig directly is causing unnecessary code coupling and makes use of different ReplicationConfig implementation difficult. Feature: Issue 12450 Change-Id: Icda484ce6bd4a9246c530b8705910331c12d6c8f
* | Merge branch 'stable-3.0' into stable-3.1Marco Miller2020-03-241-3/+5
|\| | | | | | | | | | | | | * stable-3.0: Update rules_closure to latest version Change-Id: I0540cc0de3dc474a090cc26feff45a1d2f6808c8
| * Merge branch 'stable-2.16' into stable-3.0David Pursehouse2020-03-241-3/+5
| |\ | | | | | | | | | | | | | | | | | | * stable-2.16: Update rules_closure to latest version Change-Id: I970100160dcdafee8a14cb3acf91a260902a5826
| | * Merge "Update rules_closure to latest version" into stable-2.16David Pursehouse2020-03-231-3/+5
| | |\
| | | * Update rules_closure to latest versionDavid Ostrovsky2020-03-151-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This update upgrades Protobuf to v3.11.4 and replaces default value of closure_js_binary#dependency_mode with PRUNE_LEGACY. This upgrade switched to forked rules_closure version, until this PR is merged: [1]. [1] https://github.com/bazelbuild/rules_closure/pull/478 Change-Id: I6d4ac2ae24545f302fec9a39bbcd019974f574be
* | | | Update git submodulesMarcin Czech2020-03-241-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 01357c2442feb7b7e0c07da87eaf27220dc9dad4 - Fix failing AutoReloadConfigDecorator tests Currently configuration is loaded in ReplicationFileBasedConfig constructor instead of ConfigParser.parseRemotes method. Adjust AutoReloadConfigDecorator tests to load initial state correctly. Feature: Issue 12450 Change-Id: Iaa9163bd409c56789b1f190293c89b35d632a2a3
* | | | Update git submodulesMarcin Czech2020-03-231-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 00ff9091494ccd81744bde643c981ebdead57894 - Move replication config parsing out of DestinationsCollection DestinationsCollection class is breaking single responsibility principle because is mixing ReplicationDestination and ConfigParser functionality. This split allows better code decoupling and is a prerequisite for replacing ReplicationFileBasedConfig with ReplicationConfig interface. Feature: Issue 12450 Change-Id: I33e3350596884e24bc32eacc4b51b73048e3f18c
* | | | Update git submodulesNasser Grainawi2020-03-231-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/replication from branch 'stable-3.1' to 1341a7168c42221114fbc7cde2954f8516eda9c9 - Extract destinations logic into a new class The config file is never loaded by ReplicationFileBasedConfig and thus is empty in its constructor. config.load() is later called by DestinationsCollection.validateConfig(), but that doesn't affect the values stored in ReplicationFileBasedConfig. It seems DestinationsCollection.validateConfig() shouldn't be reading config values or calling load() directly, but I'll address that in a follow-up change. Change-Id: I3f53237a1f0ac03948b72ae388722aed65716b4b
* | | | gr-rest-api-interface.js: Remove unnecesary Promise resolutionSven Selberg2020-03-231-3/+1
| | | | | | | | | | | | | | | | Change-Id: Id7945152162528bf2207af27f33931febddce29d
* | | | Merge branch 'stable-3.0' into stable-3.1David Pursehouse2020-03-222-9/+41
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: LuceneQueryChangesTest: Remove unneeded override of visible() ChangeQueryBuilder: Throw error on ambiguous visibleto by display name Change-Id: I5b14b4b14f057bfe7c55e2ae25cfcbd2d25add57
| * | | LuceneQueryChangesTest: Remove unneeded override of visible()David Pursehouse2020-03-221-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This was added during testing of the merge from stable-2.16 and was unintentionally committed. Change-Id: I8a4f15b448ff2af363b3f903f858ec05a6f90111
| * | | Merge branch 'stable-2.16' into stable-3.0David Pursehouse2020-03-213-9/+47
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: ChangeQueryBuilder: Throw error on ambiguous visibleto by display name Change-Id: I12897851d2769b0e9bf400f4feac1ce140d0be80
| | * | ChangeQueryBuilder: Throw error on ambiguous visibleto by display nameDavid Pursehouse2020-03-192-9/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the given account identifier resolved to more than one user, the visibleto would only use the first user from the result. This was OK for queries by username or account ID because they always resolve to either no user or exactly one user. However when querying by display name it is possible that multiple users will be returned, and in this case it was incorrect to only use the first one. Fix it to instead throw an error when multiple accounts are resolved, and extend the tests to cover this use case. This has been broken since change I87e58dda4 which was introduced in 2012 and was discovered by Sonar Lint which reported the following message on the broken code: Loops with at most one iteration should be refactored (squid:S1751) A loop with at most one iteration is equivalent to the use of an if statement to conditionally execute one piece of code. No developer expects to find such a use of a loop statement. If the initial intention of the author was really to conditionally execute one piece of code, an if statement should be used instead. At worst that was not the initial intention of the author and so the body of the loop should be fixed to use the nested return, break or throw statements in a more appropriate way. Change-Id: Ibb16a70e6cc61c22516f5d9ac3e1b6b461c94dc2
* | | | Merge changes from topics "json-constant-renamed", "non-core-scenarios" into ↵David Pursehouse2020-03-2213-20/+66
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stable-3.1 * changes: e2e-tests: Rename the now reused json filename constant e2e-tests: Refactor documentation about functional e2e-tests: Move core json files into scala package e2e-tests: Support adding/running non-core scenarios
| * | | | e2e-tests: Rename the now reused json filename constantMarco Miller2020-03-205-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As that constant is now reused by both core and non-core (added in, plugin) scenarios. Change-Id: I91dcd2383a0780f81e741a4411eb21ecce6df576
| * | | | e2e-tests: Refactor documentation about functionalMarco Miller2020-03-202-15/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add functional e2e testing information to the documentation, alongside the previous load-only text. Clarify the Gerrit test scopes along the way, thus how to cover them in this newly emerging e2e test framework context. Refactor the related documentation paragraphs to support this. Change-Id: Ic20c5c8f96d0aaa3fb568c282b1d5ef77167627f
| * | | | e2e-tests: Move core json files into scala packageMarco Miller2020-03-1911-14/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the core resources data file structure consistent with the one used to add non-core scenario files in. Modify the documentation accordingly. Change-Id: Ic352488a81cc43211fa38f0f2454b4fa944e9da6
| * | | | e2e-tests: Support adding/running non-core scenariosMarco Miller2020-03-198-2/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Document how to locally add non-core scenarios, for example from Gerrit plugins, to then run them like regular core scenarios. Include the companion .gitignore files, meant for the involved destination folders. Make the test data feeders private to scenarios now, while still reusing the standard resource paths. This is to support non-core scenarios, which require their resource path to slightly differ from core's. This is so that non-core scenario resource files can be git-ignored when added in, as per this change. Doing so also paves the way for more structured resource data files based on scala package. Change-Id: I499f9ed4765f64cf757aa244e427d7116c80d321
* | | | | Merge "e2e-tests: Add create/delete project to CloneUsingBothProtocols" into ↵Marco Miller2020-03-219-15/+136
|\| | | | | | | | | | | | | | | | | | | stable-3.1
| * | | | e2e-tests: Add create/delete project to CloneUsingBothProtocolsMarco Miller2020-03-199-15/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the CreateProject and DeleteProject scenarios and have the CloneUsingBothProtocols scenario compose them. Make that scenario and potential similar ones no longer require project creation outside of them. Delete the project created by that scenario once done with it. Clarify how to set the necessary http credentials in the documentation. Refactor the GitSimulation class to fit with the hereby introduced GerritSimulation one. The latter is meant to cover all things Gerrit, including the added http support, while the former now only adds the git specific harness to that. Adapt ReplayRecordsFromFeeder accordingly, without adding create/delete project support to that scenario yet. This can be done through another change once needed. Change-Id: Ifa72b7657c709266aca05cedb1e38d5e7fe4cd81
* | | | | Merge "RevisionActions: Do not alter server response" into stable-3.1David Pursehouse2020-03-216-102/+23
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | RevisionActions: Do not alter server responseSven Selberg2020-03-206-102/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of setting values in the response from the server. Keep the server response as-is and calculate necessary values from the response. After 21f0ac88 - 'Removing Current Actions from Change load' server response were altered twice: * First in gr-rest-api-interface, were new attr rebaseOnCurrent was added set to !!rebase.enabled after which rebase.enabled was set to true since the rebase button should only be disabled on inital commit. * Later in gr-change-actions were the logic was duplicated with the effect that rebaseOnCurrent was always true in the end regardless of which response was sent from the server. Parent not current tooltip: rebase.enabled is used to calculate whether or not the "Not Current" tooltip on the parent commit-info list in gr-change-metadata. But since the server response was altered so that rebase.enable was always true the tooltip was always shown. Rebase dialog: Since rebase.enable was always set to true and rebase.rebaseOnCurrent was set to !!rebase.enable, rebase.rebaseOnCurrent was always set to true. This meant that the option to rebasen the current target was always enabled. But using it led to an error if the change was already up-to-date. Instead in gr-change-actions calculate wether the rebase action button should be disabled or not and whether it rebase on current target is neccessary based on the original, unaltered, server-response. Alter the tests to test for this behavior. Bug: Issue 12474 Change-Id: Id29ea8a0c59de0079a776e4ed7ea4122ae2d89c8
* | | | | Documentation: Remove obsolete dev-release-jgit.txtDavid Pursehouse2020-03-191-52/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since JGit is now consumed as a git submodule, we don't need to build custom artifacts for JGit, and this documentation is not needed. It is no longer linked from anywhere and can be simply removed. Change-Id: I98f2062d1cac3c99181923ceb439bc6de0c002ab
* | | | | Merge branch 'stable-3.0' into stable-3.1David Pursehouse2020-03-197-5/+115
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.0: Set version to 2.16.18-SNAPSHOT Set version to 2.16.17 Schema_151: Attempt to add created_on column if it doesn't exist Update documentation links of 'numberOfShards' and 'numberOfReplicas' Support 'max_result_window' config for Elasticsearch indexes Add Zuul config Fix a typo in gr-file-list.js: dynmic -> dynamic Support displaying dynamic headers in gr-file-list Support displaying dynamic content and summary cells in gr-file-list Add headers to gr-file-list Add Zuul config Document dependency from account deactivator to autoUpdateAccountActiveStatus Introduce NamedFluentLogger Change-Id: I4eaf94df9b512fb7b36db4ac4741b32b001e21b5
| * | | | Merge branch 'stable-2.16' into stable-3.0David Pursehouse2020-03-193-2/+18
| |\ \ \ \ | | | |/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Set version to 2.16.18-SNAPSHOT Set version to 2.16.17 Schema_151: Attempt to add created_on column if it doesn't exist Update documentation links of 'numberOfShards' and 'numberOfReplicas' Support 'max_result_window' config for Elasticsearch indexes Change-Id: I62ea02789da59fbca7da586ed7f39e1e4ace152c
| | * | | Set version to 2.16.18-SNAPSHOTLuca Milanesio2020-03-186-6/+6
| | | | | | | | | | | | | | | | | | | | Change-Id: I26aa61d0e2df10401224379cc19159893199b285
| | * | | Set version to 2.16.17v2.16.17Luca Milanesio2020-03-186-6/+6
| | | | | | | | | | | | | | | | | | | | Change-Id: Id771437517b471326f3d4e4734424f72a291a1c4
| | * | | Schema_151: Attempt to add created_on column if it doesn't existDavid Pursehouse2020-03-182-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the created_on column does not exist, attempt to create it. This allows the direct migration from 2.14 to 2.16 to succeed without requiring an intermediate migration to 2.15. Bug: Issue 10248 Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
| | * | | Merge "Support 'max_result_window' config for Elasticsearch indexes" into ↵David Pursehouse2020-03-183-0/+16
| | |\ \ \ | | | | | | | | | | | | | | | | | | stable-2.16
| | | * | | Support 'max_result_window' config for Elasticsearch indexesDyrone Teng2020-03-183-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gerrit supports Elasticsearch as the index for search API. This is very convenient for users to choose the index type they want. But when there exists a large number of documents in the index of Elasticsearch, some relative functions such as the front pages and APIs will become unusable. This is because of the default Elasticsearch 'max_result_window' setting being 10000. When the query result (from + size) is greater than it, the query will fail. When gerrit executes a query on the index (such as the user is searching on the Gerrit front pages, which makes a request to the Gerrit backend API), then Gerrit will execute an HTTP request to the Elasticsearch API to query the relative data and return the data back to the front user to view the data they want. But if the result set that exists in the index is greater than the default value 10000, Gerrit will encounter this issue because Elasticsearch API will return an error response to tip the invoker that the result window is exceeded with the query. There are three different solutions to the problem: 1. Support 'max_result_window' config for Elasticsearch indexes. It is the simplest solution and the common solution for multiple releases of Gerrit (all Elasticsearch versions supported by Gerrit support this setting). 2. Use Elasticsearch Scroll Query API instead. This way decreases the costs of query performance, but brings other problems. Elasticsearch does not support traditional pagination by using scroll API and has some limitation with the '_scoll_id'; it is not recommended to use it for real-time user requests. 3. Use Elasticsearch Search After API instead. It's the best way in Elasticsearch to solve the costly deep pagination. But, it only supports Elasticsearch versions greater than 6.2, while Gerrit still supports 5.6. [1] https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-body.html#request-body-search-scroll [2] https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-body.html#request-body-search-search-after Bug: Issue 12444 Change-Id: I39da7d1d50df7bbe9dc88411632bb029c77f9f36
| | * | | | Update documentation links of 'numberOfShards' and 'numberOfReplicas'Dyrone Teng2020-03-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: Issue 12473 Change-Id: Icba063936b98858dc7b7bd085a9eb271daabafc9
| * | | | | Merge branch 'stable-2.16' into stable-3.0David Pursehouse2020-03-182-3/+11
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-2.16: Add Zuul config Document dependency from account deactivator to autoUpdateAccountActiveStatus Change-Id: I8e0e4ffe7942e4a6c798b257a676fc94e3eb79a2
| | * | | | Merge "Document dependency from account deactivator to ↵David Pursehouse2020-03-182-3/+11
| | |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | autoUpdateAccountActiveStatus" into stable-2.16
| | | * | | | Document dependency from account deactivator to autoUpdateAccountActiveStatusSaša Živkov2020-03-172-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a non-obvious dependency from the AccountDeactivator task to the auth.autoUpdateAccountActiveStatus. A properly configured account deactivator task wouldn't be scheduled if the autoUpdateAccountActiveStatus was set to false and the reason wasn't obvious to a Gerrit admin. Also log a warning if the account deactivation task is configured but will not be scheduled. Change-Id: Icf13c1b306c52c815438c01d23aa38df0ba30793
| | * | | | | Add Zuul configJames E. Blair2020-03-171-0/+32
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a branch-aware job ("gerrit-build") to build Gerrit. The version of this job that runs on this branch will have the specified submodule repos checked out as well. Other branches will have their own versions. The bulk of the job is inherited from gerrit-build-base which is defined in the zuul/jobs repository. Depends-On: https://gerrit-review.googlesource.com/255652 Change-Id: I6ae4e4474643c34b245344553f43a192901e8f69
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 10:26:55 +0000