summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Set version to 3.7.0-rc0v3.7.0-rc0Luca Milanesio2022-09-305-5/+5
| | | | | Release-Notes: skip Change-Id: Ieebb0b71cadbc9563ca0727486a38f9f3b206581
* Add the selected patchset for Checks as a URL parameterBen Rohlfs2022-09-304-38/+49
| | | | | | | | | | | | Since we have a dedicated URL parameter for the checks patchset, we stop mirroring the files patchset over to the checks patchset. That was only a one-way sync and likely a bit confusing. It was also a stop-gap, such that users could point to checks for a specific patchset using the files patchset. Release-Notes: skip Google-Bug-Id: b/235185477 Change-Id: Ief5b2274c0cb8dbe63ede260f3455bee0387a4e6
* Move `attempt` and `filter` into URL parametersBen Rohlfs2022-09-3011-57/+119
| | | | | | Release-Notes: skip Google-Bug-Id: b/235185477 Change-Id: I12b90af3c4b373801723764a17dc9a81aad03715
* Do not allow state updates with deep equal state objectsBen Rohlfs2022-09-303-3/+7
| | | | | | | | | | | | | | | | | | Most places use `select()`, which contains `distinctUntilChanged`, but we also have some subscribers that do not explicitly pipe using this operator. Instead of checking this at all call or subscription sites, it seems most efficient to just prevent state updates that are not actually an update. This change will be needed in change 347036, which subscibes to view model state changes, but really only wants to listen on actual changes. Had to fix bulk-actions-model, which was relying on the array in state being the same array as in the `updateState()` call, even if the state did not need an update at all. Release-Notes: skip Change-Id: Id9c9960840ff712a12506113da3096fe5894eb83
* Merge "Add a `comment` plugin endpoint"Ben Rohlfs2022-09-302-208/+242
|\
| * Add a `comment` plugin endpointBen Rohlfs2022-09-292-208/+242
| | | | | | | | | | | | | | Screenshot https://imgur.com/a/ekmAsQI Release-Notes: skip Change-Id: If75c759f5972d9d7332d7e05921d45c7dab08bbf
* | Merge "Prepare bulk actions model to take RelatedChangeAndCommitInfo"Dhruv Srivastava2022-09-304-31/+31
|\ \ | |/ |/|
| * Prepare bulk actions model to take RelatedChangeAndCommitInfoDhruv Srivastava2022-09-304-31/+31
| | | | | | | | | | | | | | | | | | | | | | Change 346455 is adding bulk actions for related changes which means the input to the sync() method can be of type RelatedChangeAndCommitInfo which has the same change number but with the property _change_number. Google-bug-id: b/246912339 Release-Notes: skip Change-Id: Ia004826a63de4e69ceb316e1b845dfcd7ba41532
* | Merge "Open all links in new tabs in comments and checks"Chris Poucet2022-09-292-4/+30
|\ \
| * | Open all links in new tabs in comments and checksFrank Borden2022-09-292-4/+30
| | | | | | | | | | | | | | | | | | Google-Bug-Id: b/249083604 Release-Notes: skip Change-Id: I8491cb6b3e4a9f970f04bc30caf82e468bd6da15
* | | Ensure that quoted messages show up in the reply commentChris Poucet2022-09-293-60/+61
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GrReplyDialog had both a `patchsetLevelComment` and `patchsetLevelDraftMessage` field that represent the same information. The former is used for what is shown in `gr-comment` but was not always updated when `patchsetLevelDraftMessage` changed. Get rid of `patchsetLevelDraftMessage` as this is duplicative. Additionally, ensure that when gr-comment's comment changes, the messageText is updated to reflect that. Google-Bug-Id: b/249567511 Release-Notes: skip Change-Id: I0245a93d814e9ee12f7a4104cf2b4a817b4eee4a
* | restore gr-linked-text and link-text-parserFrank Borden2022-09-296-11/+1109
| | | | | | | | | | | | | | | | There have been several reports since my rewrite does not match the old semantics. Release-Notes: skip Change-Id: I5fe93ff9caf54bbdd0b9e56b7004b84138dccb0a
* | Merge "Revert "Use HTMLPatched for all html stanzas leading down to files.""Chris Poucet2022-09-291-3/+3
|\ \
| * | Revert "Use HTMLPatched for all html stanzas leading down to files."Chris Poucet2022-09-291-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 84f2a15e6db22a8d0b764b857643fe0a606df88c. Reason for revert: This breaks in compiled mode Change-Id: I927dfab546f3b1b7c9afa3a450be686e5b2f2ba8
* | | Merge "Revert "Avoid that comments autoclose.""Chris Poucet2022-09-291-2/+2
|\ \ \
| * | | Revert "Avoid that comments autoclose."Chris Poucet2022-09-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4576322ceff9577c42a40b5368fc3b85ceac3a71. Reason for revert: This breaks in compiled mode. Change-Id: Id75ab6178a66e18de6ce4a1c9bac8f8d2edbbcf0
* | | | Merge "Add prefix, suffix, text parameters to comment links."Kamil Musin2022-09-294-6/+62
|\ \ \ \
| * | | | Add prefix, suffix, text parameters to comment links.Kamil Musin2022-09-294-6/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The backend support for them was added in https://gerrit-review.googlesource.com/c/gerrit/+/345817 We are planning to deprecate html option for the commentLinks. Most common usecase for raw html matches is to make links not extend over token boundaries or to configure the text of the link. In order to fill the gap in functionality we are adding prefix, suffix and text fields. The generated link will look like this: PREFIX<a href="LINK">TEXT</a>SUFFIX Release-Notes: Add ability to specify prefix, suffix and text fields for commentLinks of type `link`. Google-Bug-Id: b/216788721 Change-Id: Ia9e7dc88b719d31c5572b3047428bab3a55d0be0
* | | | | Merge "Always take reviewers from new change"Dhruv Srivastava2022-09-292-72/+1
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | Always take reviewers from new changeDhruv Srivastava2022-09-292-72/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently new change does not have complete reviewer info but old change has. Hence we were explicitly taking the reviewer info from old change but this does not work for stacked changes where old change has reviewers undefined. Change 346700 that GrAccountLabel requests detailed account if partial account is sent hence we can always rely on new change data. Given that we are always relying to new change data we don't need special merging logic anymore. Downside is that GrAccountLabel needs to request this information but we are fine making the tradeoff to make the codebase simpler. Google-bug-id: b/246912339 Release-Notes: skip Change-Id: I365226b661f8b57e78dab16e5d788fc0682db2d0
* | | | | Merge "Remove usage of LookBehind Regexp"Dhruv Srivastava2022-09-291-1/+1
|\ \ \ \ \
| * | | | | Remove usage of LookBehind RegexpDhruv Srivastava2022-09-291-1/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Safari does not have support of this yet(added in Change 346394). https://caniuse.com/js-regexp-lookbehind Issue: Bug 16287 Release-Notes: skip Change-Id: Ibc0e3505ccce335287ad2567b809fa4338e28a89
* | | | | Merge "Ignore check runs without name or status"Ben Rohlfs2022-09-292-0/+31
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Ignore check runs without name or statusBen Rohlfs2022-09-282-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Google-Bug-Id: b/249128220 Change-Id: I1be1f49d1d4b1ad89078eda722fa13c1dfa31e3d
* | | | | Merge "Use HTMLPatched for all html stanzas leading down to files."Chris Poucet2022-09-281-3/+3
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | Use HTMLPatched for all html stanzas leading down to files.Chris Poucet2022-09-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change 343814 introduced a patched version of Lit's html operator to work around the fact that Chrome does not actually return the same strings-array for the same template as it should. This is getting fixed upstream in Chrome, but in the interim, leverage the HTMLPatched operator for all html calls down to the gr-diff-host to avoid that it gets recreated. Release-Notes: skip Google-Bug-Id: b/235808180 Change-Id: I2e9fef04e20374218a96b8b51976ac322c74dff5
* | | | | Merge "Change test timeout from 5min to 15min"Frank Borden2022-09-281-0/+1
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Change test timeout from 5min to 15minFrank Borden2022-09-281-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have seen several times the CI hits this 5min limit https://bazel.build/reference/test-encyclopedia#role-test-runner Release-Notes: skip Change-Id: I80abb35d96266a52ce928692e4eb3bc81622874c
* | | | | Merge "Avoid that comments autoclose."Chris Poucet2022-09-281-2/+2
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | Avoid that comments autoclose.Chris Poucet2022-09-281-2/+2
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change 343814 introduced a patched version of the html operator that guarantees that the strings template remains the same across multiple invocations. Lit relies on this to determine whether or not to recreate a node. That being said, it was not applied on all `html` stanzas that eventually contain comments. Hopefully adding this should mitigate the issue, but without the ability to replicate the issue it is hard to confirm. Google-Bug-Id: b/228974289 Release-Notes: skip Change-Id: Ief18bc3d854561222ea166ffc6c8ecf8cb7f7e1a
* | | | Merge "Revert "Move behavior from component into view model for ↵Chris Poucet2022-09-2817-371/+306
|\ \ \ \ | |/ / / |/| | | | | | | change-list-view""
| * | | Revert "Move behavior from component into view model for change-list-view"Ben Rohlfs2022-09-2817-371/+306
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c8a096deb789a0cabb41a7d8a40ce47823988b28. Reason for revert: Files are not shown on change page when not logged in. Change-Id: I9c5dafe4e76e0d34c0233b2a76c29d6645937dc3
* | | | Fix margin on saved draftFrank Borden2022-09-281-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GrMarkdown migration removed GrFormattedText's :host {display: block;} rule, and margin did not apply to display: inline element. Block should instead be set in GrComment who is the one adding the margin. https://imgur.com/a/2bnzcEd Release-Notes: skip Change-Id: I0edb32ca51e9ab960cbb20f55108533bb9cc29db
* | | | Merge "Update JGit Submodule to 2021ce342."Han-Wen Nienhuys2022-09-281-0/+0
|\ \ \ \
| * | | | Update JGit Submodule to 2021ce342.Nitzan Gur-Furman2022-09-281-0/+0
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This includes the following changes: 2021ce342 (HEAD -> insync, origin/master, origin/HEAD) ObjectDirectory: avoid using File.getCanonicalPath() eb5124c74 AutoCRLFOutputStream: use BufferedOutputStream f71fcbf36 CloneCommand: set HEAD also when not checking out 4f4204914 Pass on shallowSince only if not null ccad49a28 Fix wrong @since tag 21a497843 Merge "Split out ApplyCommand logic to PatchApplier class" acde6c8f5 (newapplier) Split out ApplyCommand logic to PatchApplier class Release-Notes: Update jgit to 2021ce342. Change-Id: I265aadb19d56d2eb1269debc9688c67805ac2c87
* | | | Merge "Update change.maxPatchSets value from 1500 to 1000"Prabhu kondarangi2022-09-282-2/+2
|\ \ \ \
| * | | | Update change.maxPatchSets value from 1500 to 1000Prabhu Kondarangi2022-09-282-2/+2
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever a maxPatchSets value increases, maxUpdates value is also getting increased. So user can possibly create 1000 patch-sets by default in a change, not 1500. Because maxUpdates will not allow any further updates in a change beyond 1000. Release-Notes: To set change.maxPatchSets value as same as change.maxUpdates value. Forward-Compatible: checked Change-Id: I8e76f0ed42b2f42f092e419436e1c5d6d1b5e33a
* | | | Merge "Convert gr-change-reply-js-api_test to Typescript"Frank Borden2022-09-282-87/+74
|\ \ \ \
| * | | | Convert gr-change-reply-js-api_test to TypescriptFrank Borden2022-09-272-87/+74
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | Compare to PS1 for code changes. Release-Notes: skip Change-Id: I8141eb42fafcccec7336e42841ed7e62de587195
* | | | Add selectableChangeNums to bulk model stateDhruv Srivastava2022-09-282-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | selectableChangeNums are changes the user can select before sync is finished. Setting this in state instead of allChanges allows us to avoid setting allChanges in Loading state. Google-bug-id: b/246912339 Release-Notes: skip Change-Id: Ib1d19d8b081a4d98de64abf5b4c49d7005549460
* | | | Remove unused selector allChanges$Dhruv Srivastava2022-09-281-5/+0
| |/ / |/| | | | | | | | | | | | | | Google-bug-id: b/246912339 Release-Notes: skip Change-Id: I32561a76121d41965c3b0c1dae021f6ef4c00e12
* | | Merge "Convert gr-attribute-helper_test to typescript"Frank Borden2022-09-272-75/+82
|\ \ \
| * | | Convert gr-attribute-helper_test to typescriptFrank Borden2022-09-272-75/+82
| |/ / | | | | | | | | | | | | | | | | | | The helper only works on Polymer elements so cannot test with Lit. Release-Notes: skip Change-Id: Idf0c9b7c7b53c7ee9fca28502b2ce795eeb8eb2d
* / / Convert gr-plugin-rest-api_test to TypescriptFrank Borden2022-09-273-121/+124
|/ / | | | | | | | | | | | | Compare to PS1 for code changes. Release-Notes: skip Change-Id: Iaed316aca360edf3132e912dd5c68dd95cbeb335
* | Merge "Replace mentions with gr-account-labels"Chris Poucet2022-09-273-4/+122
|\ \
| * | Replace mentions with gr-account-labelsChris Poucet2022-09-273-4/+122
| | | | | | | | | | | | | | | | | | Screenshot: https://imgur.com/a/5MBiyaa Release-Notes: skip Change-Id: Iddc887afa978d862678fb1d939f3b7fff791c15b
* | | Merge "Move behavior from component into view model for change-list-view"Ben Rohlfs2022-09-2617-306/+371
|\ \ \ | |/ / |/| / | |/
| * Move behavior from component into view model for change-list-viewBen Rohlfs2022-09-2617-306/+371
| | | | | | | | | | | | Release-Notes: skip Google-Bug-Id: b/248247819 Change-Id: Ided3d5bfd21be9f112ad9f7a5f71c4cb654c933c
* | Merge "Replace gr-formatted-text with gr-markdown"Frank Borden2022-09-2615-1551/+556
|\ \
| * | Replace gr-formatted-text with gr-markdownFrank Borden2022-09-2615-1551/+556
| | | | | | | | | | | | | | | | | | | | | | | | gr-formatted-text was already deferring to gr-markdown, but now callers do not need to pass in config or commentlinks. Release-Notes: skip Change-Id: I53046ab403543f3218825c06f69892978a2fb3ec
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-07 08:18:41 +0000