summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Set version to 3.8.3v3.8.3v3.8.3-basedLuca Milanesio2023-11-245-5/+5
| | | | | Release-Notes: skip Change-Id: I6bb24e7a9b01fa506dd9804b8f3273e847ee602e
* Merge branch 'stable-3.7' into stable-3.8Luca Milanesio2023-11-244-2/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Set version to 3.7.7-SNAPSHOT Set version to 3.7.6 Set version to 3.6.9-SNAPSHOT Set version to 3.6.8 Update jgit to 82e277c81339 Fire `ref-updated` stream events on online edit refs update Fix documentation attributes bug Introduce Documentation:searchfree_safe with local-only fonts NOTE: The fix "Fire `ref-updated` stream events on online ..." has been reverted in this change because there is a similar fix on stable-3.8. The problem is captured in Issue 312949142. Release-Notes: skip Change-Id: I034f4cd31940d601acbcc750782a9047b183ffa8
| * Set version to 3.7.7-SNAPSHOTLuca Milanesio2023-11-245-5/+5
| | | | | | | | | | Release-Notes: skip Change-Id: I0ef642fd986de6a7d4c7bcaf3203c837ee597243
| * Set version to 3.7.6v3.7.6Luca Milanesio2023-11-245-5/+5
| | | | | | | | | | Release-Notes: skip Change-Id: I57b1214d366e26411c5ad7cf63e7611cd8ac15bc
| * Merge branch 'stable-3.6' into stable-3.7Luca Milanesio2023-11-245-6/+49
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.6: Set version to 3.6.9-SNAPSHOT Set version to 3.6.8 Update jgit to 82e277c81339 Fire `ref-updated` stream events on online edit refs update Fix documentation attributes bug Introduce Documentation:searchfree_safe with local-only fonts Release-Notes: skip Change-Id: I3f65ae41849ff6f0fae09199eea3122cfd02155a
| | * Set version to 3.6.9-SNAPSHOTLuca Milanesio2023-11-235-5/+5
| | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I18fe7e4e606fd08caa08990f7bca10751090fee0
| | * Set version to 3.6.8v3.6.8Luca Milanesio2023-11-235-5/+5
| | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I8e5bd26712eae0b5c71b13195ceee5fbf03b9f7f
| | * Update jgit to 82e277c81339Matthias Sohn2023-11-231-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ git log --oneline --no-merges 5ae8d28faaf..82e277c81339 88ca88a32 Add verification in GcKeepFilesTest that bitmaps are generated 3a6eec9bb Express the explicit intention of creating bitmaps in GC ac8d7838f GC: prune all packfiles after the loosen phase dd92c1aa9 Prepare 5.13.3-SNAPSHOT builds 5aa8a7e27 JGit v5.13.2.202306221912-r f6928f573 Revert "RefDirectory: Throw exception if CAS of packed ref list fails" 9932f9b41 [bazel] Move ToolTestCase to src folder (6.2) 2fd050c56 GcConcurrentTest: @Ignore flaky testInterruptGc 2aaa56113 Fix CommitTemplateConfigTest 70bc5aad3 Fix after_open config and Snapshotting RefDir tests to work with bazel 61d4e3134 [bazel] Skip ConfigTest#testCommitTemplatePathInHomeDirecory f3a3a2e87 Demote severity of some error prone bug patterns to warnings 032eef5b1 Parse pull.rebase=preserve as alias for pull.rebase=merges 064691e90 UploadPack: Fix NPE when traversing a tag chain b9b90d1d3 Add missing since tag for SshBasicTestBase 4f662a26f Add missing since tag for SshTestHarness#publicKey2 631858183 Silence API errors 96d9e3eb1 Prevent infinite loop rescanning the pack list on PackMismatchException f371bfb3e Remove blank in maven.config f73efea21 Remove blank in maven.config d3ba40c80 Ensure parsed RevCommitCG has derived data from commit-graph 17fac8a27 Downgrade maven-site-plugin to 3.12.1 fc613e26d Use wagon-ssh-external to deploy Maven site 23b9693a7 DirCache: support option index.skipHash Release-Notes: Update jgit to 82e277c81339 Change-Id: I2c74ddc810b7be0f6fff06e483c3e697c93696c9
| | * Merge "Fire `ref-updated` stream events on online edit refs update" into ↵Marcin Czech2023-11-232-5/+24
| | |\ | | | | | | | | | | | | stable-3.6
| | | * Fire `ref-updated` stream events on online edit refs updateMarcin Czech2023-11-232-5/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During the online edit `refs/users/xx/xxxxxxx/edit-x/x` ref is created and removed when edit is published or deleted. Make sure all `refs/users/xx/xxxxxxx/edit-x/x` updates generate `ref-updated` stream events. Release-Notes: Generate `ref-updated` stream events from online edits Bug: Issue 40014568 Change-Id: I34192259b7092dab215d7a78e3b59f6a5f15cc71
| | * | Fix documentation attributes bugAntonio Barone2023-11-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit addresses a bug (introduced by Ide4369ca194) related to documentation attributes in the _genasciidoc_htmlonly_zip function. Previously, a bug existed where the attributes argument was not being populated correctly, leading to incomplete documentation attributes such as "Table of Contents" and "revision version". The root cause was the misuse of a ternary operator that failed to modify the attributes list as intended, resulting in a mismatch between expected and actual attributes. Use parentheses to ensure proper order of operations and association when populating the "attributes" argument. This change guarantees that the intended attributes, including "Table of Contents" and "revision version", are consistently appended to the attributes list when needed. Release-Notes: Fix documentation attributes bug Change-Id: I872ddfdca0b2db6d5fbaa410719076f207abeb3c (cherry picked from commit 6e1fc45eeaff7ad19f85da817bb99f609aa42912)
| | * | Introduce Documentation:searchfree_safe with local-only fontsLuca Milanesio2023-11-233-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gerrit documentation uses asciidoc webfonts [1] which can be flagged as a security issue because of Content Security Policies [2]. [1] https://docs.asciidoctor.org/asciidoctor/latest/html-backend/default-stylesheet/#disable-or-modify-the-web-fonts [2] https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP Release-Notes: Allow generating safe local-only documentation Change-Id: Ide4369ca19473822fc5305aa0fc21665a2bc6f0c
* | | | Merge branch 'stable-3.7' into stable-3.8Luca Milanesio2023-11-225-6/+47
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Use project and changeNum for listing files in a patch-set Document ChecksApi.updateResult() Document `check-result-expanded` plugin endpoint Fix type of RevisionInfo.commit_with_footers Release-Notes: skip Change-Id: I2fe2b8f514d62bd565ffe6c50415c0a264c1b5af
| * | | Merge branch 'stable-3.6' into stable-3.7Luca Milanesio2023-11-225-6/+47
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.6: Use project and changeNum for listing files in a patch-set Document ChecksApi.updateResult() Document `check-result-expanded` plugin endpoint Fix type of RevisionInfo.commit_with_footers Release-Notes: skip Change-Id: I9bd07f2ebd7cbc127c33d404f70837c66ed6c022
| | * | Use project and changeNum for listing files in a patch-setLuca Milanesio2023-11-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ListFiles REST-API for listing files included in a patch-set was relying on a lookup by change number only, which would fail when the change is imported from a different Gerrit server-id. Also, the lookup by change number alone would need a reverse lookup in Lucene, whilst using the project as well would skip that step and will be therefore faster. It is unclear to me why the project name was not used, and there is little comments, explanation or discussion associated with the change that introduced this regression (see I1bb2ff2). See for example the change [1] has the project name in the URL and can be discovered as expected, however, the listing of the files of the patch-set 1 failed because the lookup happened using only the change number 5819 internally, resulting in 404 popup errors. Example: ```` GET /changes/5819/files ``` Use both project and changeNum in the lookup and return the list of files more reliably. [1] https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/5819 Release-Notes: Support listing of patch-set files also for imported projects Change-Id: I0ccd90cf6aac2a60baa9ea45f30bebac7cfdd318
| | * | Merge changes Ie0e40ee9,Ifcc30aaa into stable-3.6Ben Rohlfs2023-11-223-4/+45
| | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | * changes: Document ChecksApi.updateResult() Document `check-result-expanded` plugin endpoint
| | | * | Document ChecksApi.updateResult()Ben Rohlfs2023-11-221-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The call was added by Ie485bc031f65b18c78746ca64d8a0dbab1f03c47 released in Gerrit 3.5.0. It was added for the Chromium buildbucket plugin in: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/2973596 The documentation is a copy of the API documentation. Release-Notes: document `ChecksApi.updateResult()` Co-Authored-With: Antoine Musso <hashar@free.fr> Change-Id: Ie0e40ee9598137e544db54b43f02077cb14d816b
| | | * | Document `check-result-expanded` plugin endpointAntoine Musso2023-11-222-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the Check UI, a CheckResult can optionally have a `message` which is raw unformatted text. A summary is displayed and when the result row is clicked, it is expanded and the full message is shown. I8dc5befc6a8fe4297709988b36ba489de5065b7b add `check-result-expanded` endpoint to the expanded component. That lets one add a Web Component with rich formatting. This was done for Chromium buildbucket plugin back in early 2021 and released in Gerrit 3.4.0, it was however left undocumented. Document the plugin end point. The code pass two parameters `result` and `run` which are set to be the `result`, I think it is a mistake in the original code which probably wanted to also pass the run, short of fixing the issue, document the `run` parameter is the same as the `result` one. I found out about the expanded results via the TypeScript API documentation. Remove the TBD comment about making CheckResults.message to support richer formatting and hint about using that endpoint which, as far as I am concerned, fulfill my need to beautify a check result. Test plan: bazel build Documentation xdg-open bazel-bin/Documentation/pg-plugin-endpoints.html Bug: Issue 308818104 Release-Notes: document `check-result-expanded` plugin endpoint Change-Id: Ifcc30aaa2c293bc515cac76052e3fc8b2d17471b
| | * | | Fix type of RevisionInfo.commit_with_footersOrgad Shaneh2023-11-201-1/+1
| | | |/ | | |/| | | | | | | | | | | | | Release-Notes: skip Change-Id: I300a6fcf638d88770a9e69af583d7ba433792bc3
* | | | Merge branch 'stable-3.7' into stable-3.8Diego Zambelli Sessona2023-11-1612-22/+198
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Make gr-comment-thread test reliable in stable-3.6 Bazel: Remove left over --java_toolchain option Optionally skip submit rules evaluation on closed changes Optimise the way that `SubmitRuleEvaluator.evaluate` loads objects SubmitRuleEvaluator: Simply logic that checks that change and project exist Update Jetty to 9.4.53.v20231009 for security updates Bump JGit to v5.13.2.202306221912-r (5aa8a7e27) Release-Notes: skip Change-Id: I1e9f5684e4f3932a3e633531c47f9c1b9e657193
| * | | Merge branch 'stable-3.6' into stable-3.7Diego Zambelli Sessona2023-11-1612-22/+198
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.6: Make gr-comment-thread test reliable in stable-3.6 Bazel: Remove left over --java_toolchain option Optionally skip submit rules evaluation on closed changes Optimise the way that `SubmitRuleEvaluator.evaluate` loads objects SubmitRuleEvaluator: Simply logic that checks that change and project exist Update Jetty to 9.4.53.v20231009 for security updates Bump JGit to v5.13.2.202306221912-r (5aa8a7e27) Release-Notes: skip Change-Id: I7eea63100cf461b7889fbeced0afee7dc8688f56
| | * | Merge branch 'stable-3.5' into stable-3.6Diego Zambelli Sessona2023-11-150-0/+0
| | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.5: Update Jetty to 9.4.53.v20231009 for security updates Bump JGit to v5.13.2.202306221912-r (5aa8a7e27) Release-Notes: skip Change-Id: If5478ba6c7de9d681c196c718ac15492a2899f45
| | | * \ Merge branch 'stable-3.4' into stable-3.5Diego Zambelli Sessona2023-11-071-10/+10
| | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.4: Update Jetty to 9.4.53.v20231009 for security updates Bump JGit to v5.13.2.202306221912-r (5aa8a7e27) Release-Notes: skip Change-Id: Ibdcf22c5b29f5157995004592e930e57a22d6091
| | | | * \ Merge branch 'stable-3.3' into stable-3.4Diego Zambelli Sessona2023-11-071-10/+10
| | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.3: Update Jetty to 9.4.53.v20231009 for security updates Release-Notes: skip Change-Id: Iebbfe9ea1fc69e91e74208e30ea9a1b0a71ab1bd
| | | | | * \ Merge branch 'stable-3.2' into stable-3.3Diego Zambelli Sessona2023-10-251-10/+10
| | | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.2: Update Jetty to 9.4.53.v20231009 for security updates Release-Notes: skip Change-Id: If1d4dfc04d9407f0bab937a996d9321358a7b6a8
| | | | | | * | Update Jetty to 9.4.53.v20231009 for security updatesLuca Milanesio2023-10-241-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Jetty 9.4.53.v20231009 includes the following two security fixes: - CVE-2023-36478 [1] - zero-days security issue discovered on the 10th of October, also known as "HTTP/2 Rapid Reset" - CVE-2023-44487 [2] - HTTP/2 Stream Cancellation Attack [1] https://nvd.nist.gov/vuln/detail/CVE-2023-36478 [2] https://nvd.nist.gov/vuln/detail/CVE-2023-44487 Release-Notes: Update Jetty to 9.4.53.v20231009 with critical security fixes Change-Id: Ie93fbcb8b35d9e4997dc0578893a8856b56b173c (cherry picked from commit c49057e05d35ff2ad1a7307aa9168b84ae7588db)
| | | | * | | | Bump JGit to v5.13.2.202306221912-r (5aa8a7e27)Luca Milanesio2023-08-291-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we need to keep 3.4 compatible with Java 8, we can't update it past the JGit stable-5.13 branch as 6.0+ is Java 11 only. * modules/jgit 035e0e23f25..5aa8a7e27 (7): f6928f573 Revert "RefDirectory: Throw exception if CAS of packed ref list fails" 2fd050c56 GcConcurrentTest: @Ignore flaky testInterruptGc 2aaa56113 Fix CommitTemplateConfigTest 61d4e3134 [bazel] Skip ConfigTest#testCommitTemplatePathInHomeDirecory f3a3a2e87 Demote severity of some error prone bug patterns to warnings b9b90d1d3 Add missing since tag for SshBasicTestBase 4f662a26f Add missing since tag for SshTestHarness#publicKey2 631858183 Silence API errors 96d9e3eb1 (origin/stable-5.9) Prevent infinite loop rescanning the pack list on PackMismatchException f371bfb3e Remove blank in maven.config f73efea21 Remove blank in maven.config 23b9693a7 DirCache: support option index.skipHash 3212c8fa3 GC: Close File.lines stream d9f75e8bb If tryLock fails to get the lock another gc has it 1691e3877 Fix GcConcurrentTest#testInterruptGc 49f527386 Don't swallow IOException in GC.PidLock#lock a6da439b4 Check if FileLock is valid before using or releasing it 8eee800fb Acquire file lock "gc.pid" before running gc 380f091fa Silence API errors introduced by 9424052f 9424052f2 Add pack options to preserve and prune old pack files ed2cbd9e8 Allow to perform PackedBatchRefUpdate without locking loose refs e55bad514 Document option "core.sha1Implementation" introduced in 59029aec 21e902dd7 Shortcut during git fetch for avoiding looping through all local refs 765083200 FetchCommand: fix fetchSubmodules to work on a Ref to a blob 8040936f8 Silence API warnings introduced by I466dcde6 ad977f157 Allow the exclusions of refs prefixes from bitmap e4529cd39 PackWriterBitmapPreparer: do not include annotated tags in bitmap 611412a05 BatchingProgressMonitor: avoid int overflow when computing percentage cd3fc7a29 Speedup GC listing objects referenced from reflogs 2011fe06d FileSnapshotTest: Add more MISSING_FILE coverage aa9f736c3 Silence API warnings 48316309b [benchmarks] Remove profiler configuration c20e9676c Add SHA1 benchmark 4fac79658 [benchmarks] Set version of maven-compiler-plugin to 3.8.1 8d53a1433 Fix running JMH benchmarks 59029aec3 Add option to allow using JDK's SHA1 implementation 924491d4d Ignore IllegalStateException if JVM is already shutting down Release-Notes: Bump JGit to v5.13.2.202306221912-r Change-Id: I4cc1acbf1761336fa4556450791b814b275c3370
| | * | | | | | Make gr-comment-thread test reliable in stable-3.6Diego Zambelli Sessona2023-11-141-21/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on the version of the browser that the CI gets to execute the polygerrit tests, the test was unreliable because the whitespaces in the stlye attribute was getting stripped off. The test now checks the equality of the dom for the `view-diff-container` element as before, while checking stlyle, id and classes indipendently for the `gr-diff` elememt. Bug: Issue 310756438 Release-Notes: skip Change-Id: I96186544fb435b9d0b167e7a30e41555070540c1
| | * | | | | | Bazel: Remove left over --java_toolchain optionDavid Ostrovsky2023-11-133-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change Ib3b923db7b switched to using toolchain resolution for java rules and bumped Bazel version to 5.x. The new Bazel version deprecated --java_toolchain option, so that option effectively turned to be a no-op. However in some places this option was missed to be removed. That's why `tool/maven/api.sh install` utility is reporting this warning WARNING: Option 'java_toolchain' is deprecated Release-Notes: skip Change-Id: Ic72859e24c9da037b9ac4a16278f14350038fdf1
| | * | | | | | Optionally skip submit rules evaluation on closed changesDariusz Luksza2023-11-098-1/+182
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a `change.skipCurrentRulesEvaluationOnClosedChanges` configuration option to control submit rule evaluation on closed (merged and abandoned) changes. The default value for this option is `true` to keep the current behaviour of Gerrit. This means that each time closed change is viewed, submit rules will be revaluated. This may result in labels being added or removed depending on the most recent project configuration. This also means that labels on the closed changes may not represent the stale of them when it was submitted. When `change.skipCurrentRulesEvaluationOnClosedChanges` is set to `true` Gerrit will show the exact state of review labels the change was merged with. Bug: Issue 298084094 Release-Notes: Allow disable rules evaluation on closed changes Change-Id: I2499271b84edceba0c34c3347dea2f8508eca00f
| | * | | | | | Optimise the way that `SubmitRuleEvaluator.evaluate` loads objectsJacek Centkowski2023-11-061-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `ProjectState` retrieval is performed only when needed (previously it was always performed). Release-Notes: skip Change-Id: Ifaf6ead5c869ba705967256ab419ea59f87e1eae
| | * | | | | | SubmitRuleEvaluator: Simply logic that checks that change and project existEdwin Kempin2023-11-061-18/+13
| | | |_|_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. check that change exists We do not need a local variable for the change, but we can just use cd.change() after checking that cd.change() is not null. 2. check that project exists The old code throw a NoSuchProjectException just to catch it can wrap it into an IllegalStateException, just throw the IllegalStateException directly. Release-Notes: skip Change-Id: I3fe3849608b2cd2ed3589fa4ab3075b35cc91bbb Signed-off-by: Edwin Kempin <ekempin@google.com>
* | | | | | | user-inline-edit.txt: Fix edit url examplesSven Selberg2023-11-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A 'repos/edit' part is missing. Release-Notes: skip Change-Id: I6b3b203442e1afa1627bb810d2f083113d342f98
* | | | | | | Document the Edit URL featureSven Selberg2023-10-312-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I8d14dde5ea938cda2aad80a81003cf51eaeacb6f
* | | | | | | Merge branch 'stable-3.7' into stable-3.8Nasser Grainawi2023-10-257-30/+84
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Allow uploading changes to group refs project-configuration: Fix old UI references Setup operator aliases with submit requirement expressions Update Jetty to 9.4.53.v20231009 for security updates Explain in ls-projects SSH API when the "parent" field is "?-N" Change-Id: If82069a4e88006edcc3dd5ae70478447f0ee57a8 Release-Notes: skip
| * | | | | | Merge branch 'stable-3.6' into stable-3.7Nasser Grainawi2023-10-257-30/+84
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.6: Allow uploading changes to group refs project-configuration: Fix old UI references Setup operator aliases with submit requirement expressions Update Jetty to 9.4.53.v20231009 for security updates Explain in ls-projects SSH API when the "parent" field is "?-N" Change-Id: I0e7984e3b780864c2c0eaa57bbb349f9a159e5fb Release-Notes: skip
| | * | | | | Merge branch 'stable-3.5' into stable-3.6Nasser Grainawi2023-10-255-20/+59
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.5: Allow uploading changes to group refs project-configuration: Fix old UI references Setup operator aliases with submit requirement expressions Change-Id: I58c960319d39ae1b4f570619530a2bf2a9dfc08b Release-Notes: skip
| | | * | | | Merge "project-configuration: Fix old UI references" into stable-3.5Nasser Grainawi2023-10-251-5/+6
| | | |\ \ \ \
| | | | * | | | project-configuration: Fix old UI referencesNasser Grainawi2023-10-201-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The menu names for getting to the project listing changed a while ago. Also add a link to the `gerrit set-head` SSH command. Change-Id: Ic5430bf21c4b6a7a044c58e0ae9aa5185000452c Release-Notes: documentation improvements
| | | * | | | | Allow uploading changes to group refsPrudhvi Akhil Alahari2023-10-233-12/+46
| | | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update to group files is not supported because there are no validations on the changes being done to these files, without which the group data might get corrupted. Thus don't allow merges into All-Users group refs which updates group files (i.e., group.config, members and subgroups). But it is still useful to allow users to update files apart from group files. For example, users can maintain task config [1] in group refs which allows users to collaborate and review changes on group specific task configs. [1] https://gerrit.googlesource.com/plugins/task/+/refs/heads/stable-3.5/src/main/resources/Documentation/task.md Release-Notes: users can now upload changes to group refs except changes to group files Change-Id: I993f7a2d9e2db73744bb13313d058917322768d1
| | | * | | | Setup operator aliases with submit requirement expressionsKaushik Lingarkar2023-10-121-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submit requirements currently cannot be configured with aliased operators as aliases are ignored with submit requirement predicates. Fix this by setting up the aliases in ChangeQueryBuilder's constructor so that the query builder for submit requirement expressions also includes them. Release-Notes: Aliased operators now work with submit requirements Change-Id: I54a472785d1b5addf54c4dea4be2778bfed59e96
| | * | | | | Update Jetty to 9.4.53.v20231009 for security updatesLuca Milanesio2023-10-121-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Jetty 9.4.53.v20231009 includes the following two security fixes: - CVE-2023-36478 [1] - zero-days security issue discovered on the 10th of October, also known as "HTTP/2 Rapid Reset" - CVE-2023-44487 [2] - HTTP/2 Stream Cancellation Attack [1] https://nvd.nist.gov/vuln/detail/CVE-2023-36478 [2] https://nvd.nist.gov/vuln/detail/CVE-2023-44487 Release-Notes: Update Jetty to 9.4.53.v20231009 with critical security fixes Change-Id: Ie93fbcb8b35d9e4997dc0578893a8856b56b173c
| | * | | | | Merge "Explain in ls-projects SSH API when the "parent" field is "?-N"" into ↵Luca Milanesio2023-10-121-0/+15
| | |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | stable-3.6
| | | * | | | | Explain in ls-projects SSH API when the "parent" field is "?-N"Alvaro Vilaplana Garcia2023-10-101-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change I301ae1e158 extended the /project/ REST API documentation to explain the meaning of the 'parent' field being set to "?-N". Similarly, this change updates the ls-projects SSH API documentation to document the same behaviour. Release-Notes: Explain in ls-projects SSH API when the "parent" field is "?-N" Change-Id: Ia7e45c7125b6b228288f8bf0a6e7add851f5f2bf
* | | | | | | | Merge branch 'stable-3.7' into stable-3.8Yash Chaturvedi2023-10-154-5/+57
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Fix bug where changing preferred email results in duplicate emails Explain in /projects/ REST API when the "parent" field is "?-N" Fix the warning to not appear while loading a plugin Change-Id: Ibd4a98f8bb87ddeaf88c3698b60fd6363af48035 Release-Notes: skip
| * | | | | | | Merge branch 'stable-3.6' into stable-3.7Yash Chaturvedi2023-10-144-8/+63
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.6: Fix bug where changing preferred email results in duplicate emails Explain in /projects/ REST API when the "parent" field is "?-N" Fix the warning to not appear while loading a plugin Change-Id: Icbc90d92de7e1459bb824fe65c4184a3ed92c2b0 Release-Notes: skip
| | * | | | | | Merge branch 'stable-3.5' into stable-3.6Yash Chaturvedi2023-10-123-4/+45
| | |\ \ \ \ \ \ | | | |/ / / / / | | |/| / / / / | | | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.5: Fix bug where changing preferred email results in duplicate emails Fix the warning to not appear while loading a plugin Change-Id: If2f6fdc23c1b8537423136fa3cf51dde32c393b9 Release-Notes: skip
| | | * | | | Fix bug where changing preferred email results in duplicate emailsYash Chaturvedi2023-10-112-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While changing preferred email, the client-side cache is incorrectly updated, resulting in duplicate emails in the cache. Fix the issue by updating the relevant logic. Bug: Issue 304335624 Release-Notes: Changing preferred email does not result in duplicate emails Change-Id: Ifea0d2a91426acc27b8b89720b39c858f859f31e
| | | * | | | Merge "Fix the warning to not appear while loading a plugin" into stable-3.5Aniket Kumar2023-10-051-2/+18
| | | |\ \ \ \
| | | | * | | | Fix the warning to not appear while loading a pluginAniket Kumar2023-10-021-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this change, warning [1] was observed in the error logs for a plugin which has exclusively bindings for SshExecuteCommandInterceptor/ SshCreateCommandInterceptor in the ssh module as outlined in the documentation provided in references [2] and [3]. Fix this by skipping the warning if those bindings are found. [1] WARN com.google.gerrit.sshd.SshPluginStarterCallback : Plugin <plugin_name> did not define its top-level command nor any DynamicOptions com.google.inject.ConfigurationException: Guice configuration errors: [Guice/MissingImplementation]: No implementation for Command annotated with @CommandName("<plugin_name>") was bound. [2] https://gerrit-review.googlesource.com/Documentation/dev-plugins.html#ssh-command-creation-interception [3] https://gerrit-review.googlesource.com/Documentation/dev-plugins.html#ssh-command-execution-interception Bug: Issue 302408544 Change-Id: I80a2de37f2d38766b66315359779f7678f7062db Release-Notes: Eliminated startup warning for plugins whose SshModule only provides Ssh*CommandInterceptors
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 02:19:44 +0000