From a7124b38f54423d2a85b82e02dbb41564e2838ef Mon Sep 17 00:00:00 2001 From: Ismo Haataja Date: Mon, 20 Oct 2014 15:39:16 +0300 Subject: Fix NPE in staging approve command The class member variable 'emailMessages' was never properly allocated and this caused NPE (null pointer exception) when accessing it. Task-number: QTQAINFRA-905 Change-Id: I99d91a3345ca6ef8b05d4b0436929fff33d7e2da Reviewed-by: Oswald Buddenhagen --- .../src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java index e1959ca8d3..c44754e37b 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java @@ -217,7 +217,7 @@ public class StagingApprove extends SshCommand { } // Create list for possible email notification messages sent to user at the end - List emailMessages = new ArrayList(); + emailMessages = new ArrayList(); // Use current message or read it from stdin. prepareMessage(); -- cgit v1.2.3