From c39b80e630a4ad4906069e066af9cb0e05d0f57a Mon Sep 17 00:00:00 2001 From: Paul Wicking Date: Tue, 18 Dec 2018 17:32:42 +0100 Subject: Fix warnings when compiling with error_prone_warnings_toolchain bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 (cherry picked from commit 2bc3643c321b47c524927f7657eb6312adfdc19e) Reviewed-by: Jukka Jokiniva --- java/com/google/gerrit/common/PageLinks.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/java/com/google/gerrit/common/PageLinks.java b/java/com/google/gerrit/common/PageLinks.java index 38de5b15a1..30708b8c18 100644 --- a/java/com/google/gerrit/common/PageLinks.java +++ b/java/com/google/gerrit/common/PageLinks.java @@ -141,11 +141,15 @@ public class PageLinks { public static String topicQuery(Status status, String topic) { switch (status) { case ABANDONED: + case DEFERRED: return toChangeQuery(status(status) + " " + op("topic", topic)); case MERGED: case NEW: return toChangeQuery( op("topic", topic) + " (" + status(Status.NEW) + " OR " + status(Status.MERGED) + ")"); + case INTEGRATING: + case STAGED: + return toChangeQuery(status(status) + " " + op("topic", topic)); } return toChangeQuery(status(status) + " " + op("topic", topic)); } @@ -168,6 +172,12 @@ public class PageLinks { return "status:abandoned"; case MERGED: return "status:merged"; + case INTEGRATING: + return "status:integrating"; + case DEFERRED: + return "status:deferred"; + case STAGED: + return "status:staged"; case NEW: default: return "status:open"; -- cgit v1.2.3