From f0d58169270d0947f8e048a59577549eda753fa2 Mon Sep 17 00:00:00 2001 From: Ismo Haataja Date: Wed, 22 Oct 2014 14:50:42 +0300 Subject: Remove incorrect information message when commenting an old patch set Information message about dropped scores was incorrectly shown always when commenting an old patch set. Size check of the score list added to get message shown only when necessary. Task-number: QTQAINFRA-874 Change-Id: I11b392b68b9fa0ab144c78ed7f6221997e83a96f Reviewed-by: Orgad Shaneh Reviewed-by: Oswald Buddenhagen Reviewed-by: Ismo Haataja --- .../src/main/java/com/google/gerrit/server/change/PostReview.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java index 9fb6b75477..2c8c93f81b 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java @@ -185,7 +185,7 @@ public class PostReview implements RestModifyView { Output output = new Output(); output.labels = input.labels; output.message = ""; - if (input.labels != null && input.changeReviewable) { + if (input.labels != null && !input.labels.isEmpty() && input.changeReviewable) { if (change.getStatus().isCI()) { output.message = "The change was staged while you were reviewing it. " + -- cgit v1.2.3