From c9c4272b77e79d12c78b5650b0cb7781fad17950 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 31 Dec 2012 16:46:08 +0200 Subject: TrivialRebase: Pipe subprocesses directly Change-Id: Ic45a8752cb2b6f5a1b85835700658a5cd8127369 --- contrib/trivial_rebase.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'contrib') diff --git a/contrib/trivial_rebase.py b/contrib/trivial_rebase.py index d81c946821..4728499378 100755 --- a/contrib/trivial_rebase.py +++ b/contrib/trivial_rebase.py @@ -142,10 +142,10 @@ class TrivialRebase: def GetPatchId(self, revision): git_show_cmd = ['git', 'show', revision] patch_id_cmd = ['git', 'patch-id'] - patch_id_process = subprocess.Popen(patch_id_cmd, stdout=subprocess.PIPE, - stdin=subprocess.PIPE) git_show_process = subprocess.Popen(git_show_cmd, stdout=subprocess.PIPE) - return patch_id_process.communicate(git_show_process.communicate()[0])[0] + patch_id_process = subprocess.Popen(patch_id_cmd, stdout=subprocess.PIPE, + stdin=git_show_process.stdout) + return patch_id_process.communicate()[0] def SuExec(self, as_user, cmd): suexec_cmd = ['ssh', '-l', "Gerrit Code Review", '-p', self.port, self.server, '-i', -- cgit v1.2.3