| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This fix aims to adapt to "scp: error: unexpected filename ."
error seen in online repository builds. This was caused by
change in OpenSSH server code due to a security vulnerability
CVE-2018-20685.
Change-Id: Ie05065d3c24b59ac17cc814d8324e66eef49eb29
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Copy the data directory if that exists to the content.
This is a shortcut for not compressed files in a package.
Binarycreator does the compressing job then.
Remove static_component it is not used and makes not so much
sense if every component can have static data.
Change-Id: Ie0894a99f3a998be20c324dd728aefc312d16ff3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
New component configs 'component_sha1_uri' and 'component_sha1_file' can
define a URI to a downloadable file and file path inside a downloadable
archive, respectively. The file is used to read a sha1 for the component,
which can then be used with substitution '%COMPONENT_SHA1%'.
Task-number: AUTOSUITE-760
Change-Id: If0d2a30c6e07f61df89609194ce96077e81fa9a8
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
| |
Rename the package components and template files using
all substitutions, instead of just the predefined
QT_PKG_VERSION.
Change-Id: Iaedef6ac3bd7e4a316e445c6a05297d0ce4aa845
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current implementation of create_installer.py uses eight CPU cores
as maximum. Add maximum CPU count for create_installer.py as optional
parameter in order to limit build to e.g. single core on local
builds where output log readability is more important than performance.
Default value is kept on eight CPU cores. Setting higher value is
possible but futile as create_installer.py already limits use of CPU
cores to hardware real maximum with multiprocessing cpu_count method.
Note that maximum CPU count option is not intended for production builds
and therefore no release description file substitution support is added.
Suppress also one unrelated pylint warning.
Change-Id: I53444193e8320a63c023fe0a246fb4bd3ca0288d
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Previous implementation checked dSYM folders only for first package
tree element. We need to check recursively for whole package tree in
order to find dSYM folders also from plugins subfolders.
Change-Id: Ib9d0d12bf17aaf818414e008f0825312afb1016f
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Generic Qt package templates have version substitutions
on package names. Add package name version substitution handling
for QT_PKG_VERSION and QT_PKG_VERSION_MINOR variables.
Change-Id: I2ccdd72da7a09b9b0215c0fbba03a8e80d7f38dd
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Enables handling all offline packaging jobs where the
offline template file is used.
Remove unnecessary parameter when creating build job from
batch_process_installer_bld.py.
Change-Id: Ie001615fec6db7fae69d9e559a736a7305fe5ac8
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fixing issues with another patch set on top of this change.
This reverts commit ed017afe477b55bd01bd16185ac83d3558ac1c5b.
Change-Id: Ia0a3ce99b23c53082d4fcb2a37d4b36db1495ca9
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
| |
Causes multitude of problems, reverting and fixing.
This reverts commit 3055eab4c65a45d292c76335a965777a019942bf.
Change-Id: I5639fbf6f02d90312cf068720b9b9d29126b4b87
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support to 'include_filter' parameter used in packaging
configuration to separate between commercial and lgpl build.
For example for license repository commercial and lgpl
licenses are marked 'include_filter: opensource' or
'include_filter: enterprise', components without the
include filter are always included.
Change-Id: I4ce81a79e7fdf2320eb4ae0f89dd950e84bd1f93
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current implementation of removing debug information files assume that
host and target are same operating system. Extend implementation to
accept also debug information file type as configuration parameter
instead of just 'True' and 'False' values.
Extended implementation doesn't validate file type and skip host check
completely. This allows e.g. removal of MSVC pdb files on Linux host
repository builds.
With 'True' and 'False' values feature continues to work as before
because we don't want to break existing configurations.
Change-Id: I22cb0603ea2832696825c2582b2d2c775cf47249
Reviewed-by: Mikko Gronoff <mikko.gronoff@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current implementation of REMOVE_DEBUG_INFORMATION_FILES is to check
and remove debug information files from all archives during installer
and repository creation.
Change implementation so that we skip always debug information specific
archives. If surch archives are present in package configurations it
definitely means that debug information is intended to be part of
installer and reposity regardless of removal flag usage.
Change-Id: I3c69f90d4f0a0637f88b004b1d94457078209f46
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Due to insufficient if statement condition check all debug libraries are
unintentionally removed from online repository and offline installer
builds. Add missing condition check to both debug library and debug
information files removals.
Change-Id: Ib42f8dad774e4b6777f24525a0e70f3abdfd0700
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extend debug libraries and debug information files removal to
macOS and Linux host packaging. Patch introduces two new
substitution parameters for controlling debug file removal.
Current packaging configurations and releases already use previous
Windows specific parameter names so those are kept as alternative
values for backward compatibility reasons.
Change-Id: I70389dcffb39a3c143024657df29f8b7809cda8d
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
During packaging we don't necessarily have reliable source
for library names. We trust Windows debug library filenames to
follow *d.dll | *d.lib industry standard naming convention.
We must consider that library filenames can end with letter 'd'
in release build and exclude those from removable items.
Change-Id: I1727042c36c0038a354e9df7a81d045e5591f7ac
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
| |
Fix function name.
Change-Id: Ia147b795459c64192b59dbf71dd73916450b507b
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
| |
We've never used the "devmode" actually so remove it. The ifw tools
are built separately using the bld_ifw_tools.py. The create_installer
takes the ifw tools archive as an argument for the script.
Change-Id: Ieb18032e6e7c83ab4fffe3ba3e589133ddf735d2
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
|
|
|
|
|
|
|
|
|
| |
The removed options were used for installer name only long time ago.
Nowadays we explicitly define the final installer name with another
option switch.
Change-Id: Ic937f727ef5ff8fe4b934e4fbc30024c83e647e0
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
|
|
|
|
|
|
|
|
| |
We do not use nor support legacy ifw tools anymore.
Change-Id: I865b52d2b118ded9557632396407b861dc726162
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Device Creation emulator packaging is not done on Windows platform.
Removing the Win OS requirement allows Device Creation Windows Emulator
packaging with pdb files removed.
Task-number: QTBUG-64838
Change-Id: I03eb85a850bfc1d67e9479f40280150970a61cae
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows emulator component for Device Creation needs this
as well and as the removal is explicitly defined with the
REMOVE_PDB_FILES variable, removing the offline clause
from the pdb removal part enables the use also for emulator
(online installer).
Task-number: QTBUG-64838
Change-Id: I5700ff263d4cef2edc5216c7238a4fbe2c4a6096
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
|
|
|
|
|
| |
Change-Id: I14173f0e038b36982205bbda7334229483d38464
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
| |
Change-Id: Idefd935584878e4567dde1e9dd6383544618d504
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
| |
Change-Id: I878a9669b6e4a3642ea76cbcafbefedb46351efd
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to provide single offline installer for Windows
pdb files has to be removed from installer and packaged
separately. Otherwise installer size is more than 4GB
and becomes invalid win32 application.
This patch introduces --remove-pdb-files command line
option for excluding pdb files from offline installer
during installer build. By default --remove-pdb-files
option is false.
Implementation is limited to Windows and offline installer only.
Using option on other platforms or with online installer build
doesn't stop build but prints out only informative message
about option usage limitations.
Change-Id: I222ba55089791dab0d8bb3f2b635a50c001aabec
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
| |
Change-Id: I8844ab39924208b438a77376e6d09bf46aca8672
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add possibility to add multiple package namespaces using comma
separated list.
Example:
[PackageNamespace]
name: qt, mycompany, foobar
Change-Id: I80ca5a524f3307842152ff5f948790e77eece6d9
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
| |
This will be reverted when the problem is solved.
Change-Id: Id1514adc9f129945f6fa323f127f11e14a32dfdc
Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
|
|
|
|
|
|
|
|
| |
Do not assume that '7z' exists as such in the directory names
specified by the $PATH. Instead try to find the executable.
Change-Id: Ic8c3a4aa21012b6968d74a5a05fdb8795be86bc4
Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
|
|
|
|
|
|
|
|
|
| |
Creating combined android-ios package failed with
devicehdiutil: create failed - No space left on device --> Increased
size from 3 to 4g
Change-Id: I473c30595c609e382c09e1d0efcbf19b0fb36d07
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We are now raising exception instead of using sys.exit() so we can
switch back to use multiple threads safely.
This reverts commit 809ded7f79ab3d93640e3ec8f65b6b7d2c5ee4d7.
Change-Id: Ia98a208bea09e260b47f0274f77513fe3f08e2c8
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
|
|
|
|
|
|
|
|
|
| |
The sys.exit terminates just the current thread. This is an issue
if using the threadedwork.py with multiple threads as any failure
should terminate the whole script.
Change-Id: I9926c4cf9c6754a5182d331dae5a2e66c5ff95b6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
|
|
| |
The release configurations contain arg_substitution_list entries which
are used for the various configuration files. Also use them
for the package meta data.
Change-Id: I0e5be8ea082a5eee7172214a9a3c84637aa97a46
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
| |
The @ that currently is used, is also used by 'regular' installer
variables. Use % to make origin clear and avoid potential conflicts
when we also substitute in package.xml and installscript.qs files.
Change-Id: Ifb71a21561c23011f8779dc1999210e75b062e47
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
| |
This follows the rebranding of Apple's desktop operating system.
Change-Id: Ied1e167f65772c2a79f39ca79d3c929925c374a7
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Error handling is not implemented properly if using multiple threads.
When using multiple threads any error gets silently ignored
and the script happily continues execution. This will lead into silent
errors in the produced installers.
Force single threaded usage for now.
Change-Id: I1c0b356af20e27cc13c1b5ace05590eebf640b65
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Openssl usage on Windows only for static builds.
Exclude dbus from dynamic Qt builds as it is not needed
when creating documentation packages.
No need to bundle qt_menu.nib anymore in Mac packages.
Prepend OS and architecture in the generated ifw installer
packages.
Change-Id: Iccd90e29f71f06c6fc9724f086cdc4946ea7905c
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
Reviewed-by: Katja Marttila <katja.marttila@theqtcompany.com>
|
|
|
|
|
|
|
| |
Function signatures changed in bld_ifw_tools.py.
Change-Id: I23c54299b75b52d9411d8ce47113fb2eaa4db524
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Temporary paths exceed 255 characters on Windows which cause errors
when handling the paths. Use win32api to generate Windows short style
paths.
Change-Id: I7863258024f922c39b475bde9f003d799e429102
Reviewed-by: Jani Heikkinen <jani.heikkinen@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
Random string ends up in offline/online repository archive
names but not in metadata so it will not work.
This reverts commit eb7e0ccf0df760d3f8d13a146b896297180cd6e5.
Change-Id: I665624516c700dfa328ee46650b892162e50909b
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prepend the downloaded archives with random
string so that they are unique.
The packages are downloaded into same directory
thus the filenames must not collide.
Packages from qt-ci may have same filenames
hence this change is needed.
Change-Id: I2671e6a16795902ee45a68504507aa06fad7a657
Reviewed-by: Jani Heikkinen <jani.heikkinen@theqtcompany.com>
Reviewed-by: Matti Paaso <matti.paaso@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
Verify the output when executing subprocesses or attempting to delete
directories. Abort script if failure occurs.
Change-Id: I0ca27513b9a133ea50e1f08cc1a7240de9fed804
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
|
|
| |
- Caused regression in offline build
Change-Id: I691931e950b4a75d844ea3f6a3a817e44274d627
Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
- use better defaults
- remove hidden boolean arguments
Change-Id: I4272f3bb2063f0a70afabda42f0f335eb0f6ef48
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
|
|
| |
Always ensure that new IFW tools are used.
Change-Id: I99f679e78162b62b5bd6fd96802e8cfeb91f1037
Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If license.qrc exists in the config template directory then compile
the given resource as a part of the installer binary.
The license.qrc can be e.g.
<!DOCTYPE RCC><RCC version="1.0">
<qresource>
<file>license.txt</file>
</qresource>
</RCC>
It is up to the license checker plugin to parse the contents.
Change-Id: I778a53e6fccb41210fc91db3dc4a290ec7a62801
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Creating combined android-ios package failed with
devicehdiutil: create failed - No space left on device --> Increased
size from 2 to 3g
Change-Id: Ic3c61805dd56f8ba45f7d7d9cd459b87e0135d2f
Reviewed-by: Antti Kokko <antti.kokko@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I3a2a4e9451a6815891aee5f3f94bc36301708125
Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* remove unused imports
* remove unused variables
* replace unused variables with 'dummy', this is the suggested and
most common way to deal with variables that need to be defined
but are never used and it also makes pylint not to complain, eg:
for root, dir, files in os.walk(directory):
for basename in files:
if fnmatch.fnmatch(basename, '*.pro'):
filename = os.path.join(root, basename)
since 'dirs' is never used, we replace it with 'dummy'
for root, dummy, files in os.walk(directory):
for basename in files:
if fnmatch.fnmatch(basename, '*.pro'):
filename = os.path.join(root, basename)
Change-Id: I850c2c2a8ae60035d0cc5bf6c3429ff8640f9f11
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
|