From f9dcbf008b430aadd464985b7a618eca8173d264 Mon Sep 17 00:00:00 2001 From: Robert Griebl Date: Thu, 23 Feb 2017 15:11:13 +0100 Subject: [PATCH 1/3] Fix QQmlExpression leaking QQmlError objects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the user doesn't clear any potential errors manually via clearError(), then do it automatically in the destructor. Found with valgrind. [ChangeLog][QtQml][QQmlExpression] Fixed memory leak Change-Id: If5b1181850c7463c939a7ba536d74e7054c53d60 Reviewed-by: Simon Hausmann Signed-off-by: Gordan Markuš --- src/qml/qml/qqmlexpression.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qml/qml/qqmlexpression.cpp b/src/qml/qml/qqmlexpression.cpp index 6afbd05..5cb3d4d 100644 --- a/src/qml/qml/qqmlexpression.cpp +++ b/src/qml/qml/qqmlexpression.cpp @@ -200,6 +200,7 @@ QQmlExpression::QQmlExpression(QQmlContextData *ctxt, QObject *scope, */ QQmlExpression::~QQmlExpression() { + clearError(); } /*! -- 2.9.3