diff options
| author | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2023-09-06 08:38:12 +0200 |
|---|---|---|
| committer | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2023-09-08 06:58:08 +0000 |
| commit | 7986776f58d038359a7d36585c9dd44191c4069a (patch) | |
| tree | 182938d5389a69653ee04e28b0fccf753609c0ac | |
| parent | 9b25ab5329acf4c5ef1d824f4726909269f67e89 (diff) | |
Terminal: Fix incorrect signal connection
The "process" exiting does not necessarily correspond to the
stub exiting. As an example, on linux, gnome-terminal will immediately
spawn a new process for the new terminal window and exit itself.
The stub will then simply run in the detached terminal window.
Fixes: QTCREATORBUG-29488
Change-Id: Ifac0795495901b80638bd10d720b036c09f0146c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| -rw-r--r-- | src/libs/utils/externalterminalprocessimpl.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libs/utils/externalterminalprocessimpl.cpp b/src/libs/utils/externalterminalprocessimpl.cpp index 9ac01a7ee7..5cff874eb7 100644 --- a/src/libs/utils/externalterminalprocessimpl.cpp +++ b/src/libs/utils/externalterminalprocessimpl.cpp @@ -111,8 +111,6 @@ expected_str<qint64> ProcessStubCreator::startStubProcess(const ProcessSetupData if (detached) QObject::connect(process, &Process::done, process, &Process::deleteLater); - QObject::connect(process, &Process::done, m_interface, &TerminalInterface::onStubExited); - process->setWorkingDirectory(setupData.m_workingDirectory); if constexpr (HostOsInfo::isWindowsHost()) { |