aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVikas Pachdha <vikas.pachdha@qt.io>2018-04-18 10:40:54 +0200
committerVikas Pachdha <vikas.pachdha@qt.io>2018-04-19 06:30:34 +0000
commit717c7bfd9f14c6928f231f522078a8ba333810a1 (patch)
tree2432af656cacc097ec178024d9b64043ad03ed82
parentcc0c7f2ccde5765132629f1bf77477d951c913ab (diff)
Android: Add explicit tag for google_apis system images
Task-number: QTCREATORBUG-20298 Change-Id: I9bc4d9192584ffbc1180ae7b69f334c915ca16f4 Reviewed-by: BogDan Vatra <bogdan@kdab.com>
-rw-r--r--src/plugins/android/androidavdmanager.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/plugins/android/androidavdmanager.cpp b/src/plugins/android/androidavdmanager.cpp
index 5af95e7a26..954053b08b 100644
--- a/src/plugins/android/androidavdmanager.cpp
+++ b/src/plugins/android/androidavdmanager.cpp
@@ -53,6 +53,7 @@ const char avdInfoPathKey[] = "Path:";
const char avdInfoAbiKey[] = "abi.type";
const char avdInfoTargetKey[] = "target";
const char avdInfoErrorKey[] = "Error:";
+const char googleApiTag[] = "google_apis";
const int avdCreateTimeoutMs = 30000;
@@ -111,13 +112,17 @@ static CreateAvdInfo createAvdCommand(const AndroidConfig config, const CreateAv
return result;
}
- QStringList arguments({"create", "avd", "-k", result.sdkPlatform->sdkStylePath(), "-n", result.name});
+ QStringList arguments({"create", "avd", "-n", result.name});
if (!result.abi.isEmpty()) {
SystemImage *image = Utils::findOrDefault(result.sdkPlatform->systemImages(),
Utils::equal(&SystemImage::abiName, result.abi));
if (image && image->isValid()) {
arguments << "-k" << image->sdkStylePath();
+ // Google api system images requires explicit abi as
+ // google-apis/ABI or --tag "google-apis"
+ if (image->sdkStylePath().contains(googleApiTag))
+ arguments << "--tag" << googleApiTag;
} else {
QString name = result.sdkPlatform->displayText();
qCDebug(avdManagerLog) << "AVD Create failed. Cannot find system image for the platform"