aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCristian Adam <cristian.adam@qt.io>2023-10-20 15:00:44 +0200
committerCristian Adam <cristian.adam@qt.io>2023-10-20 13:57:34 +0000
commit55cccfa59eb68dd59de90939063acda56241c082 (patch)
tree8256c41b14409c10fc1484464278259553eec1eb
parent69815af272d40092db04cb452f06e02315e265c6 (diff)
CMakePM: clang-tidy fix for 'no-automatic-move'
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang- tidy/checks/performance/no-automatic-move.html Change-Id: If265c9b0e2aea49e5923f079cd621e10bb958286 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildstep.cpp2
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp2
-rw-r--r--src/plugins/cmakeprojectmanager/cmaketool.cpp2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
index 8187311a88..31a6ae23c0 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
@@ -372,7 +372,7 @@ GroupItem CMakeBuildStep::runRecipe()
const auto onEnd = [this] {
updateDeploymentData();
};
- const Group root {
+ Group root {
ignoreReturnValue() ? finishAllAndDone : stopOnError,
ProjectParserTask(onParserSetup, {}, onParserError),
defaultProcessTask(),
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
index 7f7ebccdd0..7c0001c6a8 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
@@ -1532,7 +1532,7 @@ void CMakeBuildSystem::runCTest()
if (bt != -1) {
QSet<int> seen;
std::function<QJsonObject(int)> findAncestor = [&](int index){
- const QJsonObject node = nodes.at(index).toObject();
+ QJsonObject node = nodes.at(index).toObject();
const int parent = node.value("parent").toInt(-1);
if (parent < 0 || !Utils::insert(seen, parent))
return node;
diff --git a/src/plugins/cmakeprojectmanager/cmaketool.cpp b/src/plugins/cmakeprojectmanager/cmaketool.cpp
index f9d7149a34..fdaf5e6bfc 100644
--- a/src/plugins/cmakeprojectmanager/cmaketool.cpp
+++ b/src/plugins/cmakeprojectmanager/cmaketool.cpp
@@ -228,7 +228,7 @@ FilePath CMakeTool::cmakeExecutable(const FilePath &path)
}
}
- const FilePath resolvedPath = path.canonicalPath();
+ FilePath resolvedPath = path.canonicalPath();
// Evil hack to make snap-packages of CMake work. See QTCREATORBUG-23376
if (path.osType() == OsTypeLinux && resolvedPath.fileName() == "snap")
return path;