aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSemih Yavuz <semih.yavuz@qt.io>2024-02-23 11:44:17 +0100
committerSemih Yavuz <semih.yavuz@qt.io>2024-02-26 11:38:32 +0000
commit1b53c931c5bd544811cbdb51441c76b17c482b2a (patch)
tree3b9f16bde0307830eae9e3c0b7657bccaab88b2a
parent98ffe3d9d05cbcb3b7f12d9912e108a8e19b203d (diff)
qmllssettings: Fix incorrect detecting of latest version
Update the latestVersion in the loop. Otherwise we always compare to initial value and consequently the last installed version incorrecyly becomes the latest version. Fixes: QTCREATORBUG-30423 Change-Id: I7083928c5e371f0337677eacf1b3b4da50358a7c Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
-rw-r--r--src/plugins/qmljseditor/qmllssettings.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/plugins/qmljseditor/qmllssettings.cpp b/src/plugins/qmljseditor/qmllssettings.cpp
index 76ce535fa7..15cb8908af 100644
--- a/src/plugins/qmljseditor/qmllssettings.cpp
+++ b/src/plugins/qmljseditor/qmllssettings.cpp
@@ -49,6 +49,7 @@ static FilePath evaluateLatestQmlls()
if (latestQmakeFilePath == qmakeNow && latestUniqueId >= v->uniqueId())
continue;
}
+ latestVersion = vNow;
latestQmlls = qmllsNow;
latestQmakeFilePath = qmakeNow;
latestUniqueId = uniqueIdNow;