diff options
| author | hjk <hjk@qt.io> | 2024-02-27 15:34:32 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2024-02-27 14:47:42 +0000 |
| commit | af712dc0e7e74fa4542aac37844360edb8d33ee2 (patch) | |
| tree | 8e67b46f449244f35f7c2fbbf3984ee8c1158ab6 | |
| parent | e8b3887dbf584460973ed0212a66f9b400bcc464 (diff) | |
Axivion: Fix clazy warning about mixing const and mutable iterators
Change-Id: Ief898ff2febb958f3f68a64ddcb614479854600f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
| -rw-r--r-- | src/plugins/axivion/axivionplugin.cpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/plugins/axivion/axivionplugin.cpp b/src/plugins/axivion/axivionplugin.cpp index 6e04af7e30..43316c4f8b 100644 --- a/src/plugins/axivion/axivionplugin.cpp +++ b/src/plugins/axivion/axivionplugin.cpp @@ -69,14 +69,15 @@ QIcon iconForIssue(const std::optional<Dto::IssueKind> &issueKind) return {}; static QHash<Dto::IssueKind, QIcon> prefixToIcon; + auto it = prefixToIcon.constFind(*issueKind); - if (it == prefixToIcon.constEnd()) { - const auto prefix = Dto::IssueKindMeta::enumToStr(*issueKind); - const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"), - Theme::PaletteButtonText}}, Icon::Tint); - it = prefixToIcon.insert(*issueKind, icon.icon()); - } - return it.value(); + if (it != prefixToIcon.constEnd()) + return *it; + + const QLatin1String prefix = Dto::IssueKindMeta::enumToStr(*issueKind); + const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"), + Theme::PaletteButtonText}}, Icon::Tint); + return prefixToIcon.insert(*issueKind, icon.icon()).value(); } QString anyToSimpleString(const Dto::Any &any) |