diff options
| author | Thomas Hartmann <thomas.hartmann@qt.io> | 2020-08-21 17:18:53 +0200 |
|---|---|---|
| committer | Thomas Hartmann <thomas.hartmann@qt.io> | 2020-08-24 08:03:13 +0000 |
| commit | 1d53e37b6de255b2abcf62dedcac83128970f1ba (patch) | |
| tree | 7ac0cba133059260b3ed442f743253a37ca48db7 | |
| parent | 52622a036bc565049a8b99d7061d64afac946657 (diff) | |
QmlDesigner: Remove unused custom notification
This notification is only for debugging and breaks encapsulation.
Change-Id: I20faeb76d24cc42417b3cc2e289041c70edd6157
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
| -rw-r--r-- | src/plugins/qmldesigner/components/debugview/debugview.cpp | 5 | ||||
| -rw-r--r-- | src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp | 3 |
2 files changed, 1 insertions, 7 deletions
diff --git a/src/plugins/qmldesigner/components/debugview/debugview.cpp b/src/plugins/qmldesigner/components/debugview/debugview.cpp index 6805f7b44f..61c6830b11 100644 --- a/src/plugins/qmldesigner/components/debugview/debugview.cpp +++ b/src/plugins/qmldesigner/components/debugview/debugview.cpp @@ -422,10 +422,7 @@ void DebugView::instancesChildrenChanged(const QVector<ModelNode> & nodeList) void DebugView::customNotification(const AbstractView *view, const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data) { - if (identifier == "PuppetStatus" && data.count() == 1) { - m_debugViewWidget->setPuppetStatus(data.constFirst().toString()); - - } else if (isDebugViewEnabled()) { + if (isDebugViewEnabled()) { QTextStream message; QString string; message.setString(&string); diff --git a/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp b/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp index bdae76c0d3..136b51150d 100644 --- a/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp +++ b/src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp @@ -495,9 +495,6 @@ QProcessEnvironment PuppetCreator::processEnvironment() const } #ifndef QMLDESIGNER_TEST - auto view = QmlDesignerPlugin::instance()->viewManager().nodeInstanceView(); - view->emitCustomNotification("PuppetStatus", {}, {QVariant(m_qrcMapping)}); - // set env var if QtQuick3D import exists QmlDesigner::Import import = QmlDesigner::Import::createLibraryImport("QtQuick3D", "1.0"); if (m_model->hasImport(import, true, true)) |