diff options
author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-16 23:30:07 +0100 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-11-16 22:49:40 +0000 |
commit | b6a51f046fe5190793c04abd48be781028f14281 (patch) | |
tree | ec852386ae0a6f04b32f72899db84e5f9cede376 | |
parent | eaba657d90c896e45fbd2ab24276b7cc86ec5653 (diff) |
Use static version of QFileInfo::exists()
Docs say it's faster than creating QFileInfo object and calling
exists().
Change-Id: I0c10216bf72ab11ebf97b66a113d85ac0768d918
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
4 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp index 2d433f1b93..f43e8fb49e 100644 --- a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp +++ b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp @@ -1413,7 +1413,7 @@ QString getTemplateDialog(const Utils::FilePath &projectPath) dialog->exec(); - if (!result.isEmpty() && !QFileInfo(result).exists()) { + if (!result.isEmpty() && !QFileInfo::exists(result)) { result = templateFiles.at(names.indexOf(result)); result = templatesPath.pathAppended(result).toString(); } @@ -1489,7 +1489,7 @@ void mergeWithTemplate(const SelectionContext &selectionContext) const QString templateFile = getTemplateDialog(projectPath); - if (QFileInfo(templateFile).exists()) + if (QFileInfo::exists(templateFile)) styleMerge(selectionContext, templateFile); } diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp index 62999ba193..af2a34de7c 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp @@ -129,7 +129,7 @@ ItemLibraryAssetImportDialog::ItemLibraryAssetImportDialog(const QStringList &im if (importPath.startsWith(targetDir)) { const bool isDefaultFolder = importPath.endsWith(defaultAssetFolder); const QString assetFolder = importPath + quick3DFolder; - const bool exists = QFileInfo(assetFolder).exists(); + const bool exists = QFileInfo::exists(assetFolder); if (exists) { if (isDefaultFolder) { // Priority one location, stop looking diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimporter.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimporter.cpp index 322040c82c..e244db9381 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimporter.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimporter.cpp @@ -334,7 +334,7 @@ void ItemLibraryAssetImporter::parseQuick3DAsset(const QString &file, const QVar // Generate qmldir file if importer doesn't already make one QString qmldirFileName = outDir.absoluteFilePath(QStringLiteral("qmldir")); - if (!QFileInfo(qmldirFileName).exists()) { + if (!QFileInfo::exists(qmldirFileName)) { QSaveFile qmldirFile(qmldirFileName); QString version = QStringLiteral("1.0"); @@ -451,7 +451,7 @@ void ItemLibraryAssetImporter::copyImportedFiles() // by filesystem watchers. QHash<QString, QString>::const_iterator it = assetFiles.begin(); while (it != assetFiles.end()) { - if (QFileInfo(it.key()).exists()) { + if (QFileInfo::exists(it.key())) { QDir targetDir = QFileInfo(it.value()).dir(); if (!targetDir.exists()) targetDir.mkpath("."); diff --git a/src/plugins/qmldesigner/designercore/metainfo/subcomponentmanager.cpp b/src/plugins/qmldesigner/designercore/metainfo/subcomponentmanager.cpp index 755ceeabc1..f951524268 100644 --- a/src/plugins/qmldesigner/designercore/metainfo/subcomponentmanager.cpp +++ b/src/plugins/qmldesigner/designercore/metainfo/subcomponentmanager.cpp @@ -404,7 +404,7 @@ void SubComponentManager::parseQuick3DAssetDir(const QString &assetPath) QString iconName = qmlIt.fileInfo().absolutePath() + '/' + Constants::QUICK_3D_ASSET_ICON_DIR + '/' + name + Constants::QUICK_3D_ASSET_LIBRARY_ICON_SUFFIX; - if (!QFileInfo(iconName).exists()) + if (!QFileInfo::exists(iconName)) iconName = iconPath; itemLibraryEntry.setLibraryEntryIconPath(iconName); itemLibraryEntry.setTypeIcon(QIcon(iconName)); @@ -444,7 +444,7 @@ QStringList SubComponentManager::quick3DAssetPaths() const QStringList retPaths; for (const auto &impPath : impPaths) { const QString assetPath = impPath + QLatin1String(Constants::QUICK_3D_ASSETS_FOLDER); - if (QFileInfo(assetPath).exists()) + if (QFileInfo::exists(assetPath)) retPaths << assetPath; } return retPaths; |