diff options
author | hjk <hjk@qt.io> | 2022-06-22 15:43:33 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2022-06-24 14:44:13 +0000 |
commit | 2496ffe3ce80a6b365b8908d34cb442df39c3941 (patch) | |
tree | 861ae626ebe3b932ab3c762316d7da1867067b5d | |
parent | 31db28601be3de19ec039044335d50208a2e6cba (diff) |
Code cosmetics
Mostly unused #include's, also sort them or reduce scope.
A few namespaces, ...
Change-Id: I9ee71e07de7157c9942125672addf87dd41e78f1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
71 files changed, 164 insertions, 135 deletions
diff --git a/src/plugins/android/androiddevice.cpp b/src/plugins/android/androiddevice.cpp index de06abbd9d5..037049a95a8 100644 --- a/src/plugins/android/androiddevice.cpp +++ b/src/plugins/android/androiddevice.cpp @@ -38,6 +38,7 @@ #include <projectexplorer/devicesupport/devicemanager.h> #include <projectexplorer/devicesupport/idevicewidget.h> #include <projectexplorer/kitinformation.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/session.h> #include <projectexplorer/target.h> diff --git a/src/plugins/android/androidqmlpreviewworker.cpp b/src/plugins/android/androidqmlpreviewworker.cpp index b739c1de768..e43654d4c8d 100644 --- a/src/plugins/android/androidqmlpreviewworker.cpp +++ b/src/plugins/android/androidqmlpreviewworker.cpp @@ -28,7 +28,6 @@ #include "androidavdmanager.h" #include "androiddevice.h" #include "androiddeviceinfo.h" -#include "androidglobal.h" #include "androidmanager.h" #include <coreplugin/icore.h> @@ -38,6 +37,7 @@ #include <projectexplorer/environmentaspect.h> #include <projectexplorer/kit.h> #include <projectexplorer/project.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> #include <qmlprojectmanager/qmlprojectconstants.h> diff --git a/src/plugins/android/androidqmlpreviewworker.h b/src/plugins/android/androidqmlpreviewworker.h index 9b6bd5cce97..b1605b3992a 100644 --- a/src/plugins/android/androidqmlpreviewworker.h +++ b/src/plugins/android/androidqmlpreviewworker.h @@ -24,6 +24,7 @@ ****************************************************************************/ #pragma once + #include "androidconfigurations.h" #include <projectexplorer/runcontrol.h> diff --git a/src/plugins/baremetal/baremetalplugin.cpp b/src/plugins/baremetal/baremetalplugin.cpp index 9f9f09c6b8b..239a169b088 100644 --- a/src/plugins/baremetal/baremetalplugin.cpp +++ b/src/plugins/baremetal/baremetalplugin.cpp @@ -45,6 +45,7 @@ #include <coreplugin/icore.h> #include <projectexplorer/deployconfiguration.h> +#include <projectexplorer/projectexplorerconstants.h> using namespace ProjectExplorer; diff --git a/src/plugins/boot2qt/qdbmakedefaultappstep.cpp b/src/plugins/boot2qt/qdbmakedefaultappstep.cpp index 008230028a9..2e42a77fa51 100644 --- a/src/plugins/boot2qt/qdbmakedefaultappstep.cpp +++ b/src/plugins/boot2qt/qdbmakedefaultappstep.cpp @@ -28,6 +28,7 @@ #include "qdbconstants.h" #include <projectexplorer/devicesupport/idevice.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <projectexplorer/target.h> diff --git a/src/plugins/clangcodemodel/clangcodemodelplugin.cpp b/src/plugins/clangcodemodel/clangcodemodelplugin.cpp index 4a1d53a8acd..c92de68c04c 100644 --- a/src/plugins/clangcodemodel/clangcodemodelplugin.cpp +++ b/src/plugins/clangcodemodel/clangcodemodelplugin.cpp @@ -47,6 +47,7 @@ #include <projectexplorer/project.h> #include <projectexplorer/projectpanelfactory.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/session.h> #include <projectexplorer/target.h> #include <projectexplorer/taskhub.h> diff --git a/src/plugins/clangtools/clangtool.cpp b/src/plugins/clangtools/clangtool.cpp index cfcad7f87a7..72eb1c1bcdf 100644 --- a/src/plugins/clangtools/clangtool.cpp +++ b/src/plugins/clangtools/clangtool.cpp @@ -33,7 +33,6 @@ #include "clangtoolsdiagnosticmodel.h" #include "clangtoolsdiagnosticview.h" #include "clangtoolslogfilereader.h" -#include "clangtoolsplugin.h" #include "clangtoolsprojectsettings.h" #include "clangtoolssettings.h" #include "clangtoolsutils.h" @@ -54,6 +53,7 @@ #include <projectexplorer/buildconfiguration.h> #include <projectexplorer/kitinformation.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectexplorericons.h> #include <projectexplorer/session.h> #include <projectexplorer/target.h> diff --git a/src/plugins/clangtools/clangtoolsunittests.cpp b/src/plugins/clangtools/clangtoolsunittests.cpp index 14c4d7305ec..0e4d35fc733 100644 --- a/src/plugins/clangtools/clangtoolsunittests.cpp +++ b/src/plugins/clangtools/clangtoolsunittests.cpp @@ -28,16 +28,18 @@ #include "clangtool.h" #include "clangtoolsdiagnostic.h" #include "clangtoolssettings.h" -#include "clangtoolsutils.h" #include <coreplugin/icore.h> + #include <cppeditor/clangdiagnosticconfig.h> #include <cppeditor/cppmodelmanager.h> #include <cppeditor/cpptoolsreuse.h> #include <cppeditor/cpptoolstestcase.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/kitmanager.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/toolchain.h> #include <qtsupport/qtkitinformation.h> diff --git a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp index 80b0f67e2cb..bc182a81240 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp @@ -55,6 +55,7 @@ #include <projectexplorer/namedwidget.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> #include <projectexplorer/taskhub.h> diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp index 9c0aa294106..98364ee7732 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp @@ -39,6 +39,7 @@ #include <projectexplorer/processparameters.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/target.h> #include <projectexplorer/xcodebuildparser.h> diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdatabasetests.cpp b/src/plugins/compilationdatabaseprojectmanager/compilationdatabasetests.cpp index 17840e92544..85a180e4e95 100644 --- a/src/plugins/compilationdatabaseprojectmanager/compilationdatabasetests.cpp +++ b/src/plugins/compilationdatabaseprojectmanager/compilationdatabasetests.cpp @@ -30,11 +30,14 @@ #include <coreplugin/icore.h> #include <cppeditor/cpptoolstestcase.h> #include <cppeditor/projectinfo.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/kitmanager.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/toolchain.h> #include <projectexplorer/toolchainmanager.h> + #include <utils/algorithm.h> #include <utils/hostosinfo.h> diff --git a/src/plugins/cppcheck/cppcheckplugin.cpp b/src/plugins/cppcheck/cppcheckplugin.cpp index 6d338a1df36..fed438d9ee3 100644 --- a/src/plugins/cppcheck/cppcheckplugin.cpp +++ b/src/plugins/cppcheck/cppcheckplugin.cpp @@ -32,10 +32,11 @@ #include "cppcheckdiagnosticsmodel.h" #include "cppcheckmanualrundialog.h" -#include <projectexplorer/session.h> -#include <projectexplorer/projectexplorer.h> -#include <projectexplorer/project.h> #include <projectexplorer/kitinformation.h> +#include <projectexplorer/project.h> +#include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> +#include <projectexplorer/session.h> #include <projectexplorer/target.h> #include <coreplugin/actionmanager/actioncontainer.h> diff --git a/src/plugins/cppeditor/cppmodelmanager.cpp b/src/plugins/cppeditor/cppmodelmanager.cpp index 289151cfbce..6258c9355a7 100644 --- a/src/plugins/cppeditor/cppmodelmanager.cpp +++ b/src/plugins/cppeditor/cppmodelmanager.cpp @@ -32,19 +32,16 @@ #include "cppcodemodelinspectordumper.h" #include "cppcurrentdocumentfilter.h" #include "cppeditorconstants.h" -#include "cppeditorplugin.h" #include "cppfindreferences.h" #include "cppincludesfilter.h" #include "cppindexingsupport.h" #include "cpplocatordata.h" #include "cpplocatorfilter.h" #include "cppbuiltinmodelmanagersupport.h" -#include "cpprefactoringchanges.h" #include "cppsourceprocessor.h" #include "cpptoolsjsextension.h" #include "cpptoolsreuse.h" #include "editordocumenthandle.h" -#include "stringtable.h" #include "symbolfinder.h" #include "symbolsfindfilter.h" @@ -57,13 +54,17 @@ #include <cplusplus/ASTPath.h> #include <cplusplus/TypeOfExpression.h> #include <extensionsystem/pluginmanager.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/kitmanager.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectmacro.h> #include <projectexplorer/session.h> + #include <texteditor/textdocument.h> + #include <utils/fileutils.h> #include <utils/hostosinfo.h> #include <utils/qtcassert.h> diff --git a/src/plugins/debugger/loadcoredialog.cpp b/src/plugins/debugger/loadcoredialog.cpp index ac0da69d36f..39a753f3eb7 100644 --- a/src/plugins/debugger/loadcoredialog.cpp +++ b/src/plugins/debugger/loadcoredialog.cpp @@ -32,6 +32,8 @@ #include <projectexplorer/devicesupport/filetransfer.h> #include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/kitchooser.h> +#include <projectexplorer/projectexplorerconstants.h> + #include <utils/pathchooser.h> #include <utils/processinterface.h> #include <utils/qtcassert.h> diff --git a/src/plugins/debugger/loadcoredialog.h b/src/plugins/debugger/loadcoredialog.h index de181c9844e..6935773f496 100644 --- a/src/plugins/debugger/loadcoredialog.h +++ b/src/plugins/debugger/loadcoredialog.h @@ -35,8 +35,6 @@ namespace Utils { class FilePath; } namespace Debugger { namespace Internal { -class AttachCoreDialogPrivate; - class AttachCoreDialog : public QDialog { Q_OBJECT @@ -71,9 +69,8 @@ private: void coreFileChanged(const QString &core); void selectRemoteCoreFile(); - AttachCoreDialogPrivate *d; + class AttachCoreDialogPrivate *d; }; - } // namespace Debugger } // namespace Internal diff --git a/src/plugins/debugger/unstartedappwatcherdialog.cpp b/src/plugins/debugger/unstartedappwatcherdialog.cpp index edfc8cff44f..9463128f6ae 100644 --- a/src/plugins/debugger/unstartedappwatcherdialog.cpp +++ b/src/plugins/debugger/unstartedappwatcherdialog.cpp @@ -26,29 +26,31 @@ #include "unstartedappwatcherdialog.h" #include "debuggeritem.h" -#include "debuggerdialogs.h" #include "debuggerkitinformation.h" #include <utils/pathchooser.h> +#include <projectexplorer/buildconfiguration.h> #include <projectexplorer/kit.h> -#include <projectexplorer/target.h> -#include <projectexplorer/project.h> +#include <projectexplorer/kitchooser.h> #include <projectexplorer/kitmanager.h> +#include <projectexplorer/project.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projecttree.h> #include <projectexplorer/runconfiguration.h> -#include <projectexplorer/buildconfiguration.h> +#include <projectexplorer/runcontrol.h> +#include <projectexplorer/target.h> -#include <QVBoxLayout> -#include <QHBoxLayout> -#include <QPushButton> #include <QCheckBox> #include <QDialogButtonBox> +#include <QFileDialog> +#include <QFormLayout> +#include <QHBoxLayout> #include <QKeyEvent> #include <QLabel> -#include <QFormLayout> #include <QLineEdit> -#include <QFileDialog> +#include <QPushButton> +#include <QVBoxLayout> using namespace ProjectExplorer; using namespace Utils; diff --git a/src/plugins/mcusupport/mcukitmanager.cpp b/src/plugins/mcusupport/mcukitmanager.cpp index bcf17168079..05e2aaa229a 100644 --- a/src/plugins/mcusupport/mcukitmanager.cpp +++ b/src/plugins/mcusupport/mcukitmanager.cpp @@ -37,13 +37,18 @@ #include <cmakeprojectmanager/cmakekitinformation.h> #include <cmakeprojectmanager/cmaketoolmanager.h> #include <coreplugin/icore.h> + #include <debugger/debuggeritem.h> #include <debugger/debuggeritemmanager.h> #include <debugger/debuggerkitinformation.h> -#include <utils/algorithm.h> + +#include <projectexplorer/projectexplorerconstants.h> + #include <qtsupport/qtkitinformation.h> #include <qtsupport/qtversionmanager.h> +#include <utils/algorithm.h> + #include <QMessageBox> #include <QPushButton> diff --git a/src/plugins/mcusupport/mcusupportplugin.cpp b/src/plugins/mcusupport/mcusupportplugin.cpp index d059fb98295..4944e6d68ec 100644 --- a/src/plugins/mcusupport/mcusupportplugin.cpp +++ b/src/plugins/mcusupport/mcusupportplugin.cpp @@ -44,6 +44,7 @@ #include <projectexplorer/devicesupport/devicemanager.h> #include <projectexplorer/jsonwizard/jsonwizardfactory.h> #include <projectexplorer/kitmanager.h> +#include <projectexplorer/projectexplorerconstants.h> #include <utils/infobar.h> diff --git a/src/plugins/mcusupport/test/unittest.cpp b/src/plugins/mcusupport/test/unittest.cpp index 818183de1b0..259ea35bf97 100644 --- a/src/plugins/mcusupport/test/unittest.cpp +++ b/src/plugins/mcusupport/test/unittest.cpp @@ -49,11 +49,14 @@ #include <cmakeprojectmanager/cmakekitinformation.h> #include <gmock/gmock-actions.h> #include <gmock/gmock.h> + #include <projectexplorer/customtoolchain.h> #include <projectexplorer/kitinformation.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/toolchain.h> #include <projectexplorer/toolchainmanager.h> + #include <utils/algorithm.h> #include <utils/filepath.h> diff --git a/src/plugins/mesonprojectmanager/mesonactionsmanager/mesonactionsmanager.cpp b/src/plugins/mesonprojectmanager/mesonactionsmanager/mesonactionsmanager.cpp index 6d616b983c8..516e4404402 100644 --- a/src/plugins/mesonprojectmanager/mesonactionsmanager/mesonactionsmanager.cpp +++ b/src/plugins/mesonprojectmanager/mesonactionsmanager/mesonactionsmanager.cpp @@ -31,7 +31,9 @@ #include <project/mesonbuildsystem.h> #include <project/projecttree/mesonprojectnodes.h> + #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projecttree.h> #include <utils/parameteraction.h> diff --git a/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp b/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp index bd2e120d513..b12fa8591e7 100644 --- a/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp +++ b/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp @@ -25,11 +25,9 @@ #include "mesonprojectplugin.h" -#include "exewrappers/mesonwrapper.h" #include "machinefiles/machinefilemanager.h" #include "mesonactionsmanager/mesonactionsmanager.h" #include "project/mesonbuildconfiguration.h" -#include "project/mesonbuildsystem.h" #include "project/mesonproject.h" #include "project/mesonrunconfiguration.h" #include "project/ninjabuildstep.h" @@ -39,8 +37,10 @@ #include "settings/tools/toolssettingsaccessor.h" #include "settings/tools/toolssettingspage.h" +#include <coreplugin/fileiconprovider.h> #include <coreplugin/icore.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectmanager.h> #include <projectexplorer/runcontrol.h> diff --git a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp index bfc3b6ee0ea..6fdcc4f9647 100644 --- a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp +++ b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp @@ -31,7 +31,9 @@ #include <projectexplorer/desktoprunconfiguration.h> #include <projectexplorer/environmentaspect.h> #include <projectexplorer/localenvironmentaspect.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> +#include <projectexplorer/target.h> #include <utils/environment.h> #include <utils/hostosinfo.h> diff --git a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.h b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.h index 7e657201ca9..a31439883d2 100644 --- a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.h +++ b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.h @@ -25,9 +25,7 @@ #pragma once -#include <projectexplorer/desktoprunconfiguration.h> #include <projectexplorer/runconfiguration.h> -#include <projectexplorer/target.h> namespace MesonProjectManager { namespace Internal { diff --git a/src/plugins/nim/nimplugin.cpp b/src/plugins/nim/nimplugin.cpp index 4bd3a326dd6..418032f6e90 100644 --- a/src/plugins/nim/nimplugin.cpp +++ b/src/plugins/nim/nimplugin.cpp @@ -27,7 +27,6 @@ #include "nimconstants.h" #include "editor/nimeditorfactory.h" -#include "editor/nimhighlighter.h" #include "project/nimblerunconfiguration.h" #include "project/nimblebuildconfiguration.h" #include "project/nimbuildconfiguration.h" @@ -45,10 +44,13 @@ #include "suggest/nimsuggestcache.h" #include <coreplugin/fileiconprovider.h> + +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectmanager.h> -#include <projectexplorer/toolchainmanager.h> #include <projectexplorer/runcontrol.h> #include <projectexplorer/taskhub.h> +#include <projectexplorer/toolchainmanager.h> + #include <texteditor/snippets/snippetprovider.h> using namespace Utils; diff --git a/src/plugins/nim/project/nimblerunconfiguration.cpp b/src/plugins/nim/project/nimblerunconfiguration.cpp index 68d6d06b727..9364192d049 100644 --- a/src/plugins/nim/project/nimblerunconfiguration.cpp +++ b/src/plugins/nim/project/nimblerunconfiguration.cpp @@ -25,11 +25,11 @@ #include "nimblerunconfiguration.h" -#include "nimblebuildsystem.h" +#include "nimbuildsystem.h" #include "nimconstants.h" -#include "nimbleproject.h" #include <projectexplorer/localenvironmentaspect.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <projectexplorer/runcontrol.h> #include <projectexplorer/target.h> diff --git a/src/plugins/perfprofiler/perfprofilerplugin.cpp b/src/plugins/perfprofiler/perfprofilerplugin.cpp index c12742f113f..b9dab22afa7 100644 --- a/src/plugins/perfprofiler/perfprofilerplugin.cpp +++ b/src/plugins/perfprofiler/perfprofilerplugin.cpp @@ -24,12 +24,10 @@ ****************************************************************************/ #include "perfoptionspage.h" -#include "perfprofilerconstants.h" #include "perfprofilerplugin.h" #include "perfprofilerruncontrol.h" #include "perfprofilertool.h" #include "perfrunconfigurationaspect.h" -#include "perftimelinemodelmanager.h" #if WITH_TESTS //# include "tests/perfprofilertracefile_test.h" // FIXME has to be rewritten @@ -44,8 +42,10 @@ #include <coreplugin/icore.h> #include <debugger/analyzer/analyzermanager.h> #include <extensionsystem/pluginmanager.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/project.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/target.h> diff --git a/src/plugins/perfprofiler/perfprofilertool.cpp b/src/plugins/perfprofiler/perfprofilertool.cpp index 78f79b46718..6a19ccdeda4 100644 --- a/src/plugins/perfprofiler/perfprofilertool.cpp +++ b/src/plugins/perfprofiler/perfprofilertool.cpp @@ -26,9 +26,7 @@ #include "perfconfigwidget.h" #include "perfloaddialog.h" #include "perfprofilerplugin.h" -#include "perfprofilerruncontrol.h" #include "perfprofilertool.h" -#include "perfrunconfigurationaspect.h" #include "perfsettings.h" #include "perftracepointdialog.h" @@ -39,15 +37,20 @@ #include <coreplugin/imode.h> #include <coreplugin/messagebox.h> #include <coreplugin/modemanager.h> + #include <debugger/analyzer/analyzerconstants.h> #include <debugger/analyzer/analyzermanager.h> #include <debugger/debuggericons.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/session.h> #include <projectexplorer/target.h> + #include <qtsupport/qtkitinformation.h> + #include <utils/algorithm.h> #include <utils/fancymainwindow.h> #include <utils/utilsicons.h> diff --git a/src/plugins/projectexplorer/buildsteplist.cpp b/src/plugins/projectexplorer/buildsteplist.cpp index d77dd327ba7..82248bedc8a 100644 --- a/src/plugins/projectexplorer/buildsteplist.cpp +++ b/src/plugins/projectexplorer/buildsteplist.cpp @@ -25,11 +25,9 @@ #include "buildsteplist.h" -#include "buildconfiguration.h" #include "buildmanager.h" #include "buildstep.h" -#include "deployconfiguration.h" -#include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "target.h" #include <utils/algorithm.h> diff --git a/src/plugins/projectexplorer/buildsystem.h b/src/plugins/projectexplorer/buildsystem.h index e9bcd90edaf..38945b46153 100644 --- a/src/plugins/projectexplorer/buildsystem.h +++ b/src/plugins/projectexplorer/buildsystem.h @@ -29,7 +29,7 @@ #include "buildtargetinfo.h" #include "project.h" -#include "treescanner.h" +#include "projectnodes.h" #include <QObject> diff --git a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp index 936411a7f28..8804965a479 100644 --- a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp +++ b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp @@ -26,6 +26,7 @@ #include "customexecutablerunconfiguration.h" #include "localenvironmentaspect.h" +#include "projectexplorerconstants.h" #include "target.h" using namespace Utils; diff --git a/src/plugins/projectexplorer/deployconfiguration.cpp b/src/plugins/projectexplorer/deployconfiguration.cpp index df10a323101..c0f3a8d1924 100644 --- a/src/plugins/projectexplorer/deployconfiguration.cpp +++ b/src/plugins/projectexplorer/deployconfiguration.cpp @@ -26,14 +26,16 @@ #include "deployconfiguration.h" #include "buildsteplist.h" -#include "buildconfiguration.h" #include "deploymentdataview.h" #include "kitinformation.h" #include "project.h" -#include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "target.h" #include <utils/algorithm.h> +#include <utils/qtcassert.h> + +#include <QDebug> using namespace Utils; @@ -44,7 +46,7 @@ const char BUILD_STEP_LIST_PREFIX[] = "ProjectExplorer.BuildConfiguration.BuildS const char USES_DEPLOYMENT_DATA[] = "ProjectExplorer.DeployConfiguration.CustomDataEnabled"; const char DEPLOYMENT_DATA[] = "ProjectExplorer.DeployConfiguration.CustomData"; -DeployConfiguration::DeployConfiguration(Target *target, Utils::Id id) +DeployConfiguration::DeployConfiguration(Target *target, Id id) : ProjectConfiguration(target, id), m_stepList(this, Constants::BUILDSTEPS_DEPLOY) { @@ -135,7 +137,7 @@ DeployConfigurationFactory::~DeployConfigurationFactory() g_deployConfigurationFactories.removeOne(this); } -Utils::Id DeployConfigurationFactory::creationId() const +Id DeployConfigurationFactory::creationId() const { return m_deployConfigBaseId; } @@ -176,7 +178,7 @@ void DeployConfigurationFactory::setUseDeploymentDataView() }; } -void DeployConfigurationFactory::setConfigBaseId(Utils::Id deployConfigBaseId) +void DeployConfigurationFactory::setConfigBaseId(Id deployConfigBaseId) { m_deployConfigBaseId = deployConfigBaseId; } @@ -210,7 +212,7 @@ DeployConfiguration *DeployConfigurationFactory::clone(Target *parent, DeployConfiguration *DeployConfigurationFactory::restore(Target *parent, const QVariantMap &map) { - const Utils::Id id = idFromMap(map); + const Id id = idFromMap(map); DeployConfigurationFactory *factory = Utils::findOrDefault(g_deployConfigurationFactories, [parent, id](DeployConfigurationFactory *f) { if (!f->canHandle(parent)) diff --git a/src/plugins/projectexplorer/desktoprunconfiguration.cpp b/src/plugins/projectexplorer/desktoprunconfiguration.cpp index db39def1def..983d58edaf0 100644 --- a/src/plugins/projectexplorer/desktoprunconfiguration.cpp +++ b/src/plugins/projectexplorer/desktoprunconfiguration.cpp @@ -27,7 +27,7 @@ #include "buildsystem.h" #include "localenvironmentaspect.h" -#include "project.h" +#include "projectexplorerconstants.h" #include "runconfigurationaspects.h" #include "target.h" diff --git a/src/plugins/projectexplorer/desktoprunconfiguration.h b/src/plugins/projectexplorer/desktoprunconfiguration.h index 446186e8035..a8d21eb9ec3 100644 --- a/src/plugins/projectexplorer/desktoprunconfiguration.h +++ b/src/plugins/projectexplorer/desktoprunconfiguration.h @@ -25,8 +25,7 @@ #pragma once -#include "runconfigurationaspects.h" -#include "runcontrol.h" +#include "runconfiguration.h" namespace ProjectExplorer { namespace Internal { diff --git a/src/plugins/projectexplorer/miniprojecttargetselector.cpp b/src/plugins/projectexplorer/miniprojecttargetselector.cpp index bb2845cb292..a1095773b4c 100644 --- a/src/plugins/projectexplorer/miniprojecttargetselector.cpp +++ b/src/plugins/projectexplorer/miniprojecttargetselector.cpp @@ -23,16 +23,17 @@ ** ****************************************************************************/ +#include "miniprojecttargetselector.h" + #include "buildconfiguration.h" #include "buildmanager.h" #include "deployconfiguration.h" #include "kit.h" #include "kitmanager.h" -#include "miniprojecttargetselector.h" +#include "project.h" #include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "projectexplorericons.h" -#include "project.h" -#include "projectmodels.h" #include "runconfiguration.h" #include "session.h" #include "target.h" @@ -44,25 +45,26 @@ #include <utils/styledbar.h> #include <utils/stylehelper.h> #include <utils/theme/theme.h> +#include <utils/treemodel.h> #include <utils/utilsicons.h> -#include <coreplugin/icore.h> #include <coreplugin/coreconstants.h> +#include <coreplugin/icore.h> #include <coreplugin/modemanager.h> +#include <QAction> #include <QGuiApplication> -#include <QTimer> -#include <QLayout> +#include <QItemDelegate> +#include <QKeyEvent> #include <QLabel> +#include <QLayout> #include <QList> #include <QListWidget> -#include <QStatusBar> -#include <QKeyEvent> #include <QPainter> #include <QPixmap> +#include <QStatusBar> #include <QStyleFactory> -#include <QAction> -#include <QItemDelegate> +#include <QTimer> using namespace Utils; diff --git a/src/plugins/projectexplorer/project.cpp b/src/plugins/projectexplorer/project.cpp index cd0c64aec34..bc19d3b1614 100644 --- a/src/plugins/projectexplorer/project.cpp +++ b/src/plugins/projectexplorer/project.cpp @@ -33,6 +33,7 @@ #include "kit.h" #include "kitinformation.h" #include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "projectnodes.h" #include "runconfiguration.h" #include "session.h" @@ -54,6 +55,7 @@ #include <utils/algorithm.h> #include <utils/environment.h> +#include <utils/fileutils.h> #include <utils/macroexpander.h> #include <utils/pointeralgorithm.h> #include <utils/qtcassert.h> diff --git a/src/plugins/projectexplorer/project.h b/src/plugins/projectexplorer/project.h index 039d191c1be..eaeebb100ff 100644 --- a/src/plugins/projectexplorer/project.h +++ b/src/plugins/projectexplorer/project.h @@ -33,9 +33,8 @@ #include <coreplugin/idocument.h> #include <utils/environmentfwd.h> -#include <utils/fileutils.h> +#include <utils/filepath.h> -#include <QObject> #include <QFileSystemModel> #include <functional> diff --git a/src/plugins/projectexplorer/projectfilewizardextension.cpp b/src/plugins/projectexplorer/projectfilewizardextension.cpp index f0ba9a95710..692e1da7e3a 100644 --- a/src/plugins/projectexplorer/projectfilewizardextension.cpp +++ b/src/plugins/projectexplorer/projectfilewizardextension.cpp @@ -24,34 +24,36 @@ ****************************************************************************/ #include "projectfilewizardextension.h" -#include "projectexplorer.h" -#include "session.h" + +#include "editorconfiguration.h" +#include "project.h" +#include "projectexplorerconstants.h" #include "projectnodes.h" #include "projecttree.h" +#include "projecttree.h" #include "projectwizardpage.h" - -#include <utils/algorithm.h> -#include <utils/qtcassert.h> -#include <utils/stringutils.h> +#include "session.h" #include <coreplugin/icore.h> -#include <projectexplorer/editorconfiguration.h> -#include <projectexplorer/project.h> -#include <projectexplorer/projecttree.h> + #include <texteditor/icodestylepreferences.h> #include <texteditor/icodestylepreferencesfactory.h> #include <texteditor/storagesettings.h> #include <texteditor/tabsettings.h> #include <texteditor/texteditorsettings.h> #include <texteditor/textindenter.h> + +#include <utils/algorithm.h> #include <utils/mimeutils.h> +#include <utils/qtcassert.h> +#include <utils/stringutils.h> -#include <QPointer> #include <QDebug> #include <QFileInfo> -#include <QTextDocument> -#include <QTextCursor> #include <QMessageBox> +#include <QPointer> +#include <QTextCursor> +#include <QTextDocument> using namespace TextEditor; using namespace Core; @@ -76,7 +78,6 @@ using namespace Utils; enum { debugExtension = 0 }; namespace ProjectExplorer { - namespace Internal { // --------- ProjectWizardContext diff --git a/src/plugins/projectexplorer/projecttreewidget.cpp b/src/plugins/projectexplorer/projecttreewidget.cpp index c376cac20fe..31f3cb0f7c8 100644 --- a/src/plugins/projectexplorer/projecttreewidget.cpp +++ b/src/plugins/projectexplorer/projecttreewidget.cpp @@ -25,12 +25,12 @@ #include "projecttreewidget.h" -#include "projectexplorer.h" -#include "projectnodes.h" #include "project.h" -#include "session.h" +#include "projectexplorerconstants.h" #include "projectmodels.h" +#include "projectnodes.h" #include "projecttree.h" +#include "session.h" #include <coreplugin/actionmanager/actionmanager.h> #include <coreplugin/actionmanager/command.h> @@ -44,19 +44,19 @@ #include <utils/algorithm.h> #include <utils/navigationtreeview.h> #include <utils/progressindicator.h> +#include <utils/qtcassert.h> #include <utils/tooltip/tooltip.h> #include <utils/utilsicons.h> +#include <QAction> #include <QApplication> +#include <QLineEdit> +#include <QMenu> +#include <QPainter> #include <QSettings> - #include <QStyledItemDelegate> -#include <QVBoxLayout> #include <QToolButton> -#include <QPainter> -#include <QAction> -#include <QLineEdit> -#include <QMenu> +#include <QVBoxLayout> #include <memory> @@ -469,11 +469,11 @@ void ProjectTreeWidget::editCurrentItem() const Node *node = m_model->nodeForIndex(currentIndex); if (!node) return; - auto *editor = qobject_cast<QLineEdit*>(m_view->indexWidget(currentIndex)); + auto editor = qobject_cast<QLineEdit *>(m_view->indexWidget(currentIndex)); if (!editor) return; - const int dotIndex = Utils::FilePath::fromString(editor->text()).completeBaseName().length(); + const int dotIndex = FilePath::fromString(editor->text()).completeBaseName().length(); if (dotIndex > 0) editor->setSelection(0, dotIndex); } diff --git a/src/plugins/projectexplorer/projecttreewidget.h b/src/plugins/projectexplorer/projecttreewidget.h index 7b3c53c84fa..b891d86b34c 100644 --- a/src/plugins/projectexplorer/projecttreewidget.h +++ b/src/plugins/projectexplorer/projecttreewidget.h @@ -25,15 +25,12 @@ #pragma once -#include "expanddata.h" - #include <coreplugin/inavigationwidgetfactory.h> -#include <utils/fileutils.h> +#include <utils/filepath.h> #include <QWidget> #include <QModelIndex> -#include <QSet> QT_FORWARD_DECLARE_CLASS(QTreeView) diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp index 11dc8ef69bc..f1e2d92c839 100644 --- a/src/plugins/projectexplorer/runconfiguration.cpp +++ b/src/plugins/projectexplorer/runconfiguration.cpp @@ -25,7 +25,6 @@ #include "runconfiguration.h" -#include "abi.h" #include "buildconfiguration.h" #include "buildsystem.h" #include "environmentaspect.h" @@ -33,16 +32,19 @@ #include "kitinformation.h" #include "project.h" #include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "projectnodes.h" #include "runconfigurationaspects.h" #include "runcontrol.h" #include "session.h" #include "target.h" -#include "toolchain.h" #include <coreplugin/icontext.h> #include <coreplugin/icore.h> + #include <projectexplorer/devicesupport/idevice.h> +#include <projectexplorer/projectexplorerconstants.h> + #include <utils/algorithm.h> #include <utils/checkablemessagebox.h> #include <utils/detailswidget.h> diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h index caf6593d982..318fafae329 100644 --- a/src/plugins/projectexplorer/runconfiguration.h +++ b/src/plugins/projectexplorer/runconfiguration.h @@ -27,7 +27,6 @@ #include "buildtargetinfo.h" #include "projectconfiguration.h" -#include "projectexplorerconstants.h" #include "task.h" #include <utils/aspects.h> diff --git a/src/plugins/projectexplorer/session.cpp b/src/plugins/projectexplorer/session.cpp index d5b3539bac2..9f9ee8810a4 100644 --- a/src/plugins/projectexplorer/session.cpp +++ b/src/plugins/projectexplorer/session.cpp @@ -31,6 +31,7 @@ #include "kit.h" #include "project.h" #include "projectexplorer.h" +#include "projectexplorerconstants.h" #include "projectnodes.h" #include "target.h" @@ -51,7 +52,6 @@ #include <QDebug> #include <QDir> #include <QFileInfo> - #include <QMessageBox> #include <QPushButton> diff --git a/src/plugins/projectexplorer/toolchainsettingsaccessor.cpp b/src/plugins/projectexplorer/toolchainsettingsaccessor.cpp index d541f7f022c..c4fa29466a2 100644 --- a/src/plugins/projectexplorer/toolchainsettingsaccessor.cpp +++ b/src/plugins/projectexplorer/toolchainsettingsaccessor.cpp @@ -25,6 +25,7 @@ #include "toolchainsettingsaccessor.h" +#include "projectexplorerconstants.h" #include "toolchain.h" #include <coreplugin/icore.h> @@ -56,9 +57,9 @@ public: // Helpers: // -------------------------------------------------------------------- -static const char TOOLCHAIN_DATA_KEY[] = "ToolChain."; -static const char TOOLCHAIN_COUNT_KEY[] = "ToolChain.Count"; -static const char TOOLCHAIN_FILENAME[] = "toolchains.xml"; +const char TOOLCHAIN_DATA_KEY[] = "ToolChain."; +const char TOOLCHAIN_COUNT_KEY[] = "ToolChain.Count"; +const char TOOLCHAIN_FILENAME[] = "toolchains.xml"; struct ToolChainOperations { @@ -284,8 +285,6 @@ Toolchains ToolChainSettingsAccessor::toolChains(const QVariantMap &data) const #ifdef WITH_TESTS #include "projectexplorer.h" -#include "headerpath.h" - #include "abi.h" #include "toolchainconfigwidget.h" diff --git a/src/plugins/projectexplorer/toolchainsettingsaccessor.h b/src/plugins/projectexplorer/toolchainsettingsaccessor.h index 80d3f90fd6d..9f12bc182a2 100644 --- a/src/plugins/projectexplorer/toolchainsettingsaccessor.h +++ b/src/plugins/projectexplorer/toolchainsettingsaccessor.h @@ -29,8 +29,6 @@ #include <QList> -#include <memory> - namespace ProjectExplorer { class ToolChain; diff --git a/src/plugins/projectexplorer/treescanner.h b/src/plugins/projectexplorer/treescanner.h index ff73e8e563e..73b39a4792e 100644 --- a/src/plugins/projectexplorer/treescanner.h +++ b/src/plugins/projectexplorer/treescanner.h @@ -28,7 +28,7 @@ #include "projectexplorer_export.h" #include "projectnodes.h" -#include <utils/fileutils.h> +#include <utils/filepath.h> #include <utils/mimeutils.h> #include <QObject> diff --git a/src/plugins/python/pythonplugin.cpp b/src/plugins/python/pythonplugin.cpp index ab508ca18d2..cfdd61fdf8a 100644 --- a/src/plugins/python/pythonplugin.cpp +++ b/src/plugins/python/pythonplugin.cpp @@ -26,9 +26,7 @@ #include "pythonplugin.h" #include "pysidebuildconfiguration.h" -#include "pythonconstants.h" #include "pythoneditor.h" -#include "pythonlanguageclient.h" #include "pythonproject.h" #include "pythonsettings.h" #include "pythonrunconfiguration.h" @@ -37,6 +35,7 @@ #include <projectexplorer/buildtargetinfo.h> #include <projectexplorer/localenvironmentaspect.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectmanager.h> #include <projectexplorer/runcontrol.h> #include <projectexplorer/taskhub.h> diff --git a/src/plugins/python/pythonproject.cpp b/src/plugins/python/pythonproject.cpp index d0581305697..7d0fc27f0f5 100644 --- a/src/plugins/python/pythonproject.cpp +++ b/src/plugins/python/pythonproject.cpp @@ -50,6 +50,7 @@ #include <utils/algorithm.h> #include <utils/fileutils.h> +#include <utils/mimeutils.h> using namespace Core; using namespace ProjectExplorer; diff --git a/src/plugins/qmakeprojectmanager/qmakenodes.cpp b/src/plugins/qmakeprojectmanager/qmakenodes.cpp index da52070931a..7c2f3b5e7b6 100644 --- a/src/plugins/qmakeprojectmanager/qmakenodes.cpp +++ b/src/plugins/qmakeprojectmanager/qmakenodes.cpp @@ -28,6 +28,7 @@ #include "qmakeproject.h" #include <projectexplorer/buildconfiguration.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/target.h> diff --git a/src/plugins/qmakeprojectmanager/qmakenodes.h b/src/plugins/qmakeprojectmanager/qmakenodes.h index 798a813dad6..59e49f467ae 100644 --- a/src/plugins/qmakeprojectmanager/qmakenodes.h +++ b/src/plugins/qmakeprojectmanager/qmakenodes.h @@ -31,9 +31,8 @@ #include <projectexplorer/buildsystem.h> #include <projectexplorer/projectnodes.h> -namespace Utils { class FilePath; } - namespace QmakeProjectManager { + class QmakeProFileNode; class QmakeProject; diff --git a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.cpp b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.cpp index 3268d16a529..2393251ae02 100644 --- a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.cpp +++ b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.cpp @@ -38,7 +38,6 @@ #include "qmakeproject.h" #include "externaleditors.h" #include "qmakekitinformation.h" -#include "profilehighlighter.h" #include <coreplugin/icore.h> #include <coreplugin/coreconstants.h> @@ -56,6 +55,7 @@ #include <projectexplorer/session.h> #include <projectexplorer/target.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectexplorericons.h> #include <texteditor/texteditor.h> diff --git a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.h b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.h index 68255197dd0..5b3176b9b72 100644 --- a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.h +++ b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.h @@ -27,12 +27,7 @@ #include <extensionsystem/iplugin.h> -namespace ProjectExplorer { class Project; } - namespace QmakeProjectManager { - -class QmakeProFileNode; - namespace Internal { class QmakeProjectManagerPlugin final : public ExtensionSystem::IPlugin diff --git a/src/plugins/qmakeprojectmanager/qmakestep.cpp b/src/plugins/qmakeprojectmanager/qmakestep.cpp index 2502297ef00..7b6eddc5670 100644 --- a/src/plugins/qmakeprojectmanager/qmakestep.cpp +++ b/src/plugins/qmakeprojectmanager/qmakestep.cpp @@ -25,7 +25,6 @@ #include "qmakestep.h" -#include "qmakemakestep.h" #include "qmakebuildconfiguration.h" #include "qmakekitinformation.h" #include "qmakenodes.h" @@ -39,8 +38,10 @@ #include <projectexplorer/buildmanager.h> #include <projectexplorer/buildsteplist.h> #include <projectexplorer/gnumakeparser.h> +#include <projectexplorer/makestep.h> #include <projectexplorer/processparameters.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <projectexplorer/target.h> #include <projectexplorer/toolchain.h> diff --git a/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp b/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp index 8d33feaf5cc..d3252ea8e3e 100644 --- a/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp +++ b/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp @@ -30,8 +30,10 @@ #include <designersettings.h> #include <utils/utilsicons.h> + #include <projectexplorer/kitinformation.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/session.h> #include <projectexplorer/project.h> #include <projectexplorer/target.h> diff --git a/src/plugins/qmlpreview/qmlpreviewplugin.cpp b/src/plugins/qmlpreview/qmlpreviewplugin.cpp index 1cbecc042f1..72907a15419 100644 --- a/src/plugins/qmlpreview/qmlpreviewplugin.cpp +++ b/src/plugins/qmlpreview/qmlpreviewplugin.cpp @@ -44,6 +44,7 @@ #include <projectexplorer/kitinformation.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectnodes.h> #include <projectexplorer/projecttree.h> #include <projectexplorer/runconfiguration.h> diff --git a/src/plugins/qmlprofiler/qmlprofilerplugin.cpp b/src/plugins/qmlprofiler/qmlprofilerplugin.cpp index f6592de524e..06c6f269be1 100644 --- a/src/plugins/qmlprofiler/qmlprofilerplugin.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerplugin.cpp @@ -28,7 +28,6 @@ #include "qmlprofilerruncontrol.h" #include "qmlprofilersettings.h" #include "qmlprofilertool.h" -#include "qmlprofilertimelinemodel.h" #include "qmlprofileractions.h" #ifdef WITH_TESTS @@ -65,6 +64,7 @@ #include <projectexplorer/environmentaspect.h> #include <projectexplorer/kitinformation.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/target.h> diff --git a/src/plugins/qmlprofiler/qmlprofilertool.cpp b/src/plugins/qmlprofiler/qmlprofilertool.cpp index c198b60fe88..551cf32e32c 100644 --- a/src/plugins/qmlprofiler/qmlprofilertool.cpp +++ b/src/plugins/qmlprofiler/qmlprofilertool.cpp @@ -31,8 +31,6 @@ #include "qmlprofilerviewmanager.h" #include "qmlprofilerclientmanager.h" #include "qmlprofilermodelmanager.h" -#include "qmlprofilerdetailsrewriter.h" -#include "qmlprofilernotesmodel.h" #include "qmlprofilerrunconfigurationaspect.h" #include "qmlprofilersettings.h" #include "qmlprofilerplugin.h" @@ -59,8 +57,9 @@ #include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/environmentaspect.h> #include <projectexplorer/kitinformation.h> -#include <projectexplorer/projectexplorer.h> #include <projectexplorer/project.h> +#include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> #include <projectexplorer/session.h> #include <projectexplorer/taskhub.h> diff --git a/src/plugins/qmlprofiler/qmlprofilertool.h b/src/plugins/qmlprofiler/qmlprofilertool.h index a6065e502d1..450607c9c35 100644 --- a/src/plugins/qmlprofiler/qmlprofilertool.h +++ b/src/plugins/qmlprofiler/qmlprofilertool.h @@ -26,8 +26,6 @@ #pragma once #include "qmlprofiler_global.h" -#include "qmlprofilerconstants.h" -#include "qmlprofilereventtypes.h" #include <QAction> #include <QObject> diff --git a/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp b/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp index 9432407d7b6..1d749fee724 100644 --- a/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp @@ -25,12 +25,15 @@ #include "qmlprofilerviewmanager.h" -#include "qmlprofilertool.h" +#include "qmlprofilerconstants.h" #include "qmlprofilerstatewidget.h" -#include <utils/qtcassert.h> #include <debugger/analyzer/analyzermanager.h> +#include <projectexplorer/projectexplorerconstants.h> + +#include <utils/qtcassert.h> + #include <QDockWidget> using namespace Debugger; @@ -51,7 +54,7 @@ QmlProfilerViewManager::QmlProfilerViewManager(QObject *parent, QTC_ASSERT(m_profilerModelManager, return); QTC_ASSERT(m_profilerState, return); - m_perspective = new Utils::Perspective(Constants::QmlProfilerPerspectiveId, tr("QML Profiler")); + m_perspective = new Perspective(Constants::QmlProfilerPerspectiveId, tr("QML Profiler")); m_perspective->setAboutToActivateCallback([this]() { createViews(); }); } diff --git a/src/plugins/qmlprofiler/qmlprofilerviewmanager.h b/src/plugins/qmlprofiler/qmlprofilerviewmanager.h index d65f3c4965a..fc2b4252cab 100644 --- a/src/plugins/qmlprofiler/qmlprofilerviewmanager.h +++ b/src/plugins/qmlprofiler/qmlprofilerviewmanager.h @@ -29,15 +29,11 @@ #include "qmlprofilertraceview.h" #include "flamegraphview.h" -#include <QObject> - namespace Utils { class Perspective; } namespace QmlProfiler { namespace Internal { -class QmlProfilerTool; - class QmlProfilerViewManager : public QObject { Q_OBJECT diff --git a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp index 8d9b1b834dd..bdf08103fba 100644 --- a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp +++ b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp @@ -27,6 +27,8 @@ #include <debugger/analyzer/analyzermanager.h> +#include <projectexplorer/projectexplorerconstants.h> + #include <qmlprofiler/qmlprofilerruncontrol.h> #include <qmlprofiler/qmlprofilertool.h> diff --git a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.h b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.h index 53ef39e8ff1..39491ec0c94 100644 --- a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.h +++ b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.h @@ -28,14 +28,13 @@ #include <qmlprofiler/qmlprofilermodelmanager.h> #include <qmlprofiler/qmlprofilerruncontrol.h> -#include <QUrl> - namespace QmlProfiler { namespace Internal { class LocalQmlProfilerRunnerTest : public QObject { Q_OBJECT + public: LocalQmlProfilerRunnerTest(QObject *parent = nullptr); diff --git a/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp b/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp index 404b43bb772..9eaeaddd4c9 100644 --- a/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp +++ b/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp @@ -34,6 +34,7 @@ #include <coreplugin/editormanager/ieditor.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> #include <utils/algorithm.h> diff --git a/src/plugins/qmlprojectmanager/qmlproject.cpp b/src/plugins/qmlprojectmanager/qmlproject.cpp index b76349ba0a2..bdaffac260d 100644 --- a/src/plugins/qmlprojectmanager/qmlproject.cpp +++ b/src/plugins/qmlprojectmanager/qmlproject.cpp @@ -30,8 +30,6 @@ #include "qmlprojectconstants.h" #include "qmlprojectmanagerconstants.h" #include "qmlprojectnodes.h" -#include "qmlprojectplugin.h" -#include "qmlprojectrunconfiguration.h" #include <coreplugin/documentmanager.h> #include <coreplugin/editormanager/documentmodel.h> @@ -45,6 +43,7 @@ #include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/kitinformation.h> #include <projectexplorer/kitmanager.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> #include <qtsupport/baseqtversion.h> @@ -57,6 +56,7 @@ #include <utils/algorithm.h> #include <utils/infobar.h> +#include <utils/qtcassert.h> #include <utils/qtcprocess.h> #include <QDebug> diff --git a/src/plugins/qmlprojectmanager/qmlproject.h b/src/plugins/qmlprojectmanager/qmlproject.h index a5ce067be69..5d9dc15b7c7 100644 --- a/src/plugins/qmlprojectmanager/qmlproject.h +++ b/src/plugins/qmlprojectmanager/qmlproject.h @@ -26,7 +26,6 @@ #pragma once #include "qmlprojectmanager_global.h" -#include "qmlprojectnodes.h" #include <projectexplorer/buildsystem.h> #include <projectexplorer/project.h> diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp index 9d7805f03f4..64c6301da18 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp @@ -39,6 +39,7 @@ #include <projectexplorer/kitinformation.h> #include <projectexplorer/kitmanager.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <projectexplorer/runcontrol.h> #include <projectexplorer/session.h> diff --git a/src/plugins/qtsupport/gettingstartedwelcomepage.cpp b/src/plugins/qtsupport/gettingstartedwelcomepage.cpp index 8278d5c5f84..574d9b62209 100644 --- a/src/plugins/qtsupport/gettingstartedwelcomepage.cpp +++ b/src/plugins/qtsupport/gettingstartedwelcomepage.cpp @@ -40,8 +40,10 @@ #include <coreplugin/helpmanager.h> #include <coreplugin/modemanager.h> #include <coreplugin/welcomepagehelper.h> -#include <projectexplorer/projectexplorer.h> + #include <projectexplorer/project.h> +#include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <QComboBox> #include <QDesktopServices> diff --git a/src/plugins/remotelinux/customcommanddeploystep.cpp b/src/plugins/remotelinux/customcommanddeploystep.cpp index fef2d103f6c..1e11a1b779c 100644 --- a/src/plugins/remotelinux/customcommanddeploystep.cpp +++ b/src/plugins/remotelinux/customcommanddeploystep.cpp @@ -30,6 +30,7 @@ #include "remotelinux_constants.h" #include <projectexplorer/devicesupport/idevice.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <utils/qtcprocess.h> diff --git a/src/plugins/remotelinux/makeinstallstep.cpp b/src/plugins/remotelinux/makeinstallstep.cpp index f5f60b95bfc..534ebc25399 100644 --- a/src/plugins/remotelinux/makeinstallstep.cpp +++ b/src/plugins/remotelinux/makeinstallstep.cpp @@ -34,9 +34,11 @@ #include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/kitinformation.h> #include <projectexplorer/processparameters.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfigurationaspects.h> #include <projectexplorer/target.h> #include <projectexplorer/task.h> + #include <utils/algorithm.h> #include <utils/fileutils.h> #include <utils/qtcassert.h> diff --git a/src/plugins/remotelinux/makeinstallstep.h b/src/plugins/remotelinux/makeinstallstep.h index fd41291de8c..aff62afbf77 100644 --- a/src/plugins/remotelinux/makeinstallstep.h +++ b/src/plugins/remotelinux/makeinstallstep.h @@ -30,11 +30,6 @@ #include <projectexplorer/deploymentdata.h> #include <projectexplorer/makestep.h> -namespace Utils { -class FilePath; -class StringAspect; -} // Utils - namespace RemoteLinux { class REMOTELINUX_EXPORT MakeInstallStep : public ProjectExplorer::MakeStep diff --git a/src/plugins/remotelinux/remotelinuxplugin.cpp b/src/plugins/remotelinux/remotelinuxplugin.cpp index 5e4cbd1c266..b79fc79eb45 100644 --- a/src/plugins/remotelinux/remotelinuxplugin.cpp +++ b/src/plugins/remotelinux/remotelinuxplugin.cpp @@ -46,6 +46,7 @@ #endif #include <projectexplorer/kitinformation.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/target.h> using namespace ProjectExplorer; diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp index 1fedbcb4a1e..1cd50e2a19b 100644 --- a/src/plugins/valgrind/memchecktool.cpp +++ b/src/plugins/valgrind/memchecktool.cpp @@ -51,6 +51,7 @@ #include <projectexplorer/kitinformation.h> #include <projectexplorer/project.h> #include <projectexplorer/projectexplorer.h> +#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/runconfiguration.h> #include <projectexplorer/session.h> #include <projectexplorer/target.h> |