| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Use the actual image dpr for arithmetics rather than the application
dpr.
Fixes: QTCREATORBUG-30464
Change-Id: I52083bcca067282a677a9d0e1b7c62e9c7270c64
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
| |
Amends 0d8a542b4f7d8a7b4d27f42ff16d309fba6cbf22
Fixes: QTCREATORBUG-30529
Change-Id: Ic786f1e7075ef68cf9d590d27ef90b9d1e8631b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-30209
Change-Id: Icd40d6da99e7fa53f667745a4de32b03b1157c99
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
|
|
|
|
|
|
|
| |
The automatic setup also works with vcpkg.
Change-Id: I755e59ef0a88105da195e9abe30adca5e3011fae
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are new operator== overloads that are causing this to now be
ambiguous.
qlist.h: In instantiation of ‘qsizetype QtPrivate::indexOf(const QList<T>&, const U&, qsizetype) [with V = QByteArray; U = Utils::SmallStringView; qsizetype = long long int]’:
qlist.h:935:20: error: ambiguous overload for ‘operator==’ (operand types are ‘const QByteArray’ and ‘const Utils::SmallStringView’)
qbytearray.h:520:5: note: candidate: ‘bool operator==(const QByteArray&, const QByteArrayView&)’
smallstringview.h:117:16: note: candidate: ‘constexpr bool Utils::operator==(SmallStringView, SmallStringView)’
Change-Id: I6818d78a57394e37857bfffd17b9ffb5101cdc5c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
|
|
| |
It turns out caching the information is unreliable due to a variety of reasons.
We remove the cache for now as its less dangerous than trying to fix each
use case.
Change-Id: I8238166486a2fb29c101f700af1c8d7e4ad7a172
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
| |
Change-Id: I296e4a75984689a4cdbcea69519c4a27d5d5e90a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
| |
Change-Id: Ia7073a8cef72f141253810558b30ba9c28083b7e
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
| |
Change-Id: I64896287dda3df96078f7fabec4cd4437396f3f3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
It tried to use an existing string, but missed the full stop
Amends 124c62a5a0bca8d64c26a64478b9875664d9fb9c
Change-Id: Idf66621b714da86be700d4ac18c6df2c7a83a468
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29361
Change-Id: I0d62d48036e08528c025eac8653e58ff0039e5a2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
|
| |
Hide it from the QDS Manual.
Task-number: QTCREATORBUG-29361
Change-Id: I7c44aaed42e374b8e07d093279c8078ada18c250
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
| |
As specified by design.
Change-Id: Ia766ca16e3ce233aa73ac75d48d70b1379c39c37
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|
|
|
|
| |
Change-Id: I4414c69cebaeb429c5b6dfea6e6fa97b118e353e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
| |
Amends e1f7469afb32efa51d665c9211767b214cd93573
Change-Id: I862bca5a57d818e8b813d557fa7c3a4e3690dcd2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Without the export, when compiled on macOS (with clang), the call
"runControl()->aspect<RunAsRootAspect>()" in runcontrol.cpp would
return a nullptr, since ProjectExplorer and libUtils had different
vtables for TypedAspect<bool>.
Task-number: QTCREATORBUG-30516
Change-Id: Ic3cef6545e97f59af2a1138f13762c07d9402e4a
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTCREATORBUG-30520
Change-Id: I0fc2eaba533e6260763c0c02657cf3a7de7c9dce
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
|
|
| |
A remnant of a wrong refactoring.
Fixes: QTCREATORBUG-30519
Change-Id: I2fadb353b83762d4d821444a58f7631dcfd22b0d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
| |
Change-Id: Id26b41e878ed2b8b20099b62ed1c122966165665
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTCREATORBUG-13413
Change-Id: I93cde8d11867ab8cec8a2f760f0f38a0935fe946
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I0895a8ef3ccad9ab41081ec1df53aa45ed721e3e
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Johnny Jazeix <jazeix@gmail.com>
Reviewed-by: Olivier Delaune <olivier+qt@delaune.info>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
|
|
|
|
|
|
|
|
|
| |
warning indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
if (__builtin_expect(!!(clients.removeAll(client) == 0), true)) {} else { ::Utils::writeAssertLocation( "\"" "clients.removeAll(client) == 0""\" in " "/data/dev/creator-out/src/plugins/languageclient/languageclientmanager.cpp" ":" "114"); } do {} while (0
Change-Id: I14297567627801d3a5436abf2df8fec23bff85dd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In an accompanying change, the installer writes versioned
settings keys. The version string will be appended to the
existing key, after a single underscore character.
When reading from the settings, the plugin first looks for
keys matching one of the requested versions from the kit.
Optionally, if no key for a matching version is found, the
key for the newest version available is chosen. This only
applies to the Qul SDK package for the time being.
If no suitable versioned key is found, the plain unversioned
settings key is picked
Task-number: QTCREATORBUG-29194
Change-Id: I2db888390cfb64a4b7c78ebcf795543251cb7a1b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
| |
Change-Id: I0b181dc05a409a38cbd87366a0cb6631c900ed24
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
|
|
| |
No need to create lambda on every call to credentialKey().
This should remove the warning about the
Performance inefficiencies (AUTO_CAUSES_COPY).
Change-Id: I9a7dc9cabcc6f80e58e39ef8be6a5445a11e0433
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
| |
Amends 0b0941cbcb62b91872a5ee8caf6da11ec9061958
Change-Id: I61cfe511be6627a347b330a6833f5d7a4afe3f1d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
| |
Change-Id: Ib8cd3d336508f1a4e12465456254b02c556ac38b
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a Clangd specific function hint model that alwys highlights the
current parameter based on the number of commas in front of the cursor
position, like the builtin code model. It also correctly closes the
proposal after typing the closing parenthesis.
Fixes: QTCREATORBUG-26346
Fixes: QTCREATORBUG-30489
Change-Id: I09d3ac6856acfe5e0f206d8c3a96dbb561ea2ce7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
|
|
| |
Some of the linked topics were removed and others are now how-to
topics. Added How To and Reference categories and fixed topic titles.
Task-number: QTCREATORBUG-29361
Change-Id: I96efb10baacc173c30c6d568589bc91b3ff381ee
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When triggering them from the context menu while debugging.
Fix used settings group when triggering writeSettings() on
the aspect instead of the AspectContainer.
Explicitly persist respective settings when triggering them
on the context menu.
Fixes: QTCREATORBUG-30491
Change-Id: I6f429bb54630cbe61c8b2ee063028f323a2d08f6
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
User feedback was gathered and in part implemented in form of a design
update:
- Update dark and light tokens
- Add Token_Text_Accent and use it for session/sroject names, tags, etc.
- Change card hover from Token_Foreground_Subtle to
Token_Background_Subtle
- Remove font-style changes on hover
Change-Id: Ia428d43828c9c76ea91d142356457846b932e2d6
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Give the dialog back its minimize and maximize buttons (on Windows),
without setting the Window flag.
Amends: 24796279f3079474469858c366498cd62a84492b
Change-Id: I2bca972c0351d0749ea3771e418449a052703329
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
| |
tst_APTW01 explicitly disables the Clang Code Model
so there is no filter category of that name.
Change-Id: I7378e11582bb0231a24404cca212a234ef7f37ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
| |
Skip targets list if function name is add_subdirectory
Fixes: QTCREATORBUG-30510
Change-Id: I8c601fb2134fc8a9b2814df01f6ec5eec380c51a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already done in 509600da99fe48db30d930b308129da43abdbd40, but
accidentally reverted by a refactoring in
7f908d737b0e017e65e917c65b19499f3093fa4c.
Task-number: QTCREATORBUG-29943
Change-Id: Ica3df46fa9610729629704746a8e1003bb89f465
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were some problems regarding removal of the default kit:
- A precondition of setDefaultKit() was violated.
- The new default kit was set to a kit that was possibly removed later
as well (and never updated afterwards).
- The new default kit was only set if it wasn't null, leaving a
dangling pointer in m_defaultKit.
Also turned some checks into assertions.
Amends e31a06a0f42143724ebf35aa2cc669dbcf54fbf0.
Done-by: Christian Kandeler <christian.kandeler@qt.io>
Fixes: QTCREATORBUG-30493
Fixes: QTCREATORBUG-30502
Change-Id: I3283f02c90d0ec84b579d7cfdf845b03663f5768
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On macOS the action was correctly switching between "Enter Full Screen"
and "Exit Full Screen", but on Windows & Linux the text was fixed to
"Full Screen" and the code tried to set the check state - but forgot to
make it checkable in the first place.
Actually it is unclear what the "correct" behavior is on Windows &
Linux. Neither on Gnome or KDE or Windows the action shows a check mark
when in Full Screen mode though. Either there is a tool button with an
icon, or some variation of "Exit Full Screen" or "Leave Full Screen".
Change the text of the action on all platforms, use "Exit Full Screen"
on all of them, but stay with just "Full Screen" on Windows & Linux (as
opposed to "Enter Full Screen" on macOS).
Fixes: QTCREATORBUG-30365
Change-Id: Ic55a30e32302ceb12f75449781b1aefecb370c97
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
|
|
|
|
|
|
|
|
|
| |
Provide actions to open the selected issue or table inside
the system web browser.
Change-Id: I43d31368444fd4664db7d908c40b898e430cede3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
panelWidget() and isInUnstyledDialogOrPopup() in ManhattanStyle.cpp
would mark the contents of this dialog as "panel widgets". In order to
evade this, we don't set the dialog type of the Crop&Trim dialog to
Qt::Windows.
The author of this dialog did not leave us a comment on why Qt::Windows
was chosen, so we can assume it was done for no particular reason.
Fixes: QTCREATORBUG-29893
Change-Id: I90f653e39cee839203b8767cb30eadab69baaf09
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
But this time ignore unhandled exceptions which were caused by the
'threads' command in certain situations.
Amends db307978bfd4a037a91341e066d63dcde3de71d6
Change-Id: I50819306eeb392ebae8dc869694ed588739c44fb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|
|
|
|
|
|
| |
Use less specific #include to get EnvironmentAspect.
Change-Id: I570c6a0871c63f5857d56ff640e95f10463fce5e
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
|
|
|
|
|
|
|
|
| |
Not needed anymore.
Change-Id: Iadeed22e90ab98ae5db0a4305af7c862fc2a1810
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
|
|
|
|
|
|
|
| |
... without creating a hard dependencies.
Change-Id: I07b40dd9f1a4f53c5279d36f44e2a9123a34fa74
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
|
|
|
|
|
|
| |
Fixes: QTCREATORBUG-30501
Change-Id: Ic1f09e513114acf6fb6ee52c8b5f066a2071e202
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
|
|
|
|
|
|
|
|
| |
It is supposed to be shown in the tool tip, so set the tool tip instead.
Fixes: QTCREATORBUG-29174
Change-Id: Ib2572b71dfccf18276e63fadb7dbe386949b0275
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
|
|
|
|
|
|
| |
Fixes: QTCREATORBUG-30413
Change-Id: Ie637e20d6308da2e1afcf3ff710f29c6a1695d58
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Button states can have individual text tokens assigned. Depending on the
used fonts and platform-specific renderer, any of these states may have
the highest widts. Consider all of them and use the maximum.
Change-Id: I51caccef9e34c1911c2773b8836dba722ad63c47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
|
|
|
|
|
|
|
| |
Change-Id: I0e97c91701030674cba363a692c2c9765a4aedbd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
|
|
|
|
|
|
|
| |
Amends 9832af970187df48d233e3cfe1738eae6fb3d29b
Change-Id: I8840748e3bcb2c0993f93411b324e04a7f81960d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This is a valid path to try the unauthorized access first,
and when it fails we automatically try the authorized access.
So we shouldn't bother the user with an error on a failure
on unauthorized access to the dashboard info.
Change-Id: Ia27686f804415741da614e36802551f8d8d610ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
|