aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind/memchecktool.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Valgrind: Add target executable suffix to heob command lineHannes Domani2018-09-251-2/+3
| | | | | | | | | | The suffix is needed in case the executable name contains a dot, because then the .exe suffix is not added automatically by CreateProcess(). Change-Id: Ief2cfeaa8dd8ebbfb71f69575ee9574a4f2156d3 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Valgrind: Fix heob check if executable existsHannes Domani2018-08-141-1/+2
| | | | | | | Task-number: QTCREATORBUG-20938 Change-Id: Id1c3cbf610b97a13209e6a767c5e881e9be18ac7 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Valgrind: Heob: Make heob support translatableChristian Stenger2018-06-141-0/+4
| | | | | | Task-number: QTCREATORBUG-19830 Change-Id: I0c9799d9b3f8b56d96e78bf48fe32b9a3c4591eb Reviewed-by: hjk <hjk@qt.io>
* Finish merging Runnable and StandardRunnablehjk2018-05-231-8/+6
| | | | | | | | | | As all Runnables are known to be StandardRunnables, this here essentially replaces all .is<StandardRunnable> by 'true'. .as<StandardRunnable> by no-op, and fixes the fallout. Change-Id: I1632f8e164fa0a9dff063df47a9e191fdf7bbb2e Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/4.6'Eike Ziller2018-05-021-1/+3
|\ | | | | | | Change-Id: I9927fdff4c7e73c703757852a3f3cf79444e3cb6
| * Heob: Compile fix for MinGWv4.6.1hjk2018-04-301-1/+3
| | | | | | | | | | | | Task-number: QTCREATORBUG-20347 Change-Id: I13d0e4cae19a1623113f113dc6fe7e245d54be8c Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Heob: Fix compiler warningsChristian Stenger2018-04-301-1/+1
|/ | | | | | | Fix warnings regarding initializing order. Change-Id: Iea220be1fcca47262ebf43d0cfe069ca0bfc1df5 Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Use OPENFILE_TOOLBAR in toolbarsAlessandro Portale2018-02-131-1/+1
| | | | | Change-Id: Ib154f6352006b827b771d033eddc939ac4dc6dfe Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Open help for heobHannes Domani2018-02-071-0/+12
| | | | | Change-Id: I9cc7dfc2553f445784d3bb86378e2db28f70902c Reviewed-by: hjk <hjk@qt.io>
* Heob: Fix UI textLeena Miettinen2018-02-071-17/+17
| | | | | | | | Fix issues in writing style and punctuation. Change-Id: I68da7960ccb5876ec8baf3b8eab1ab7e0d475a77 Reviewed-by: Hannes Domani <ssbssa@yahoo.de> Reviewed-by: hjk <hjk@qt.io>
* Fix MinGW valgrind buildOliver Wolff2018-02-061-9/+3
| | | | | | | | | | QueryFullProcessImageName is only available on Windows >= Vista. iSetting _WIN32_WINNT fixes availability on MinGW and moving the functionality to winutils avoids code duplication. Change-Id: I0ff1a12a1c092b1ad9cde75b636b52c5b959ce7d Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: David Schulz <david.schulz@qt.io>
* Valgrind: Inform about heob/dwarfstack requirementsHannes Domani2018-01-231-3/+19
| | | | | | | Change-Id: I86b561b474f5676568b490bdfd829f17364ea3c3 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Fix heob ui textsHannes Domani2018-01-171-35/+35
| | | | | | | Change-Id: Id246ba7d485c6993ae5788dde3ae4262df2f35d7 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Add heob path to settingsHannes Domani2018-01-161-10/+37
| | | | | | Change-Id: If2fa8c913b20bd30016673d2cf712fb9b85ad9d6 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Enable heob menu entry only if debugging is possibleHannes Domani2018-01-161-0/+3
| | | | | | Change-Id: Ifc2b029538c1dd48e1e9853d52eb1ffae38ea325 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Save current heob settings as defaultHannes Domani2018-01-161-5/+58
| | | | | | Change-Id: I9e2ac8aff2830f2a46d86185d198ecf188c5e649 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Run heob process with debuggerHannes Domani2018-01-161-13/+96
| | | | | | Change-Id: Ie026033b04dce73c8f4d7a4adb42f9c08c53cccd Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Add heob supportHannes Domani2018-01-161-2/+568
| | | | | | | | Change-Id: Ia5957058c59ae2a607620915c2c68f2cfd5ac5f1 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* Project: Make Project::files return a FileNameListTobias Hunger2017-12-081-1/+2
| | | | | Change-Id: I75ceb22ac65b8288d824f229d44089cba6fc8ea3 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Clean up outdated includes and fileshjk2017-10-051-0/+3
| | | | | Change-Id: I1b4b84ff9bfa3f6e0fe3030d70a114e2cf0f0604 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Merge memcheck{engine,tool}.* fileshjk2017-09-251-19/+190
| | | | | | | | | This is purely mechanical in preparation of moving some per-run items from the MemCheckTool singleton to MemCheckToolRunner. Change-Id: I0fcaf6e90b2d63ca8f3c3eb7130ed73ed494f35b Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* MemCheck: Code cosmeticshjk2017-09-181-28/+13
| | | | | | | namespaces, includes, use convenience functions when appropriate. Change-Id: Ibfba9b4ce8d4644829cb308b45b5902e39a57634 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Drop unused variables and lambda capturesUlf Hermann2017-09-081-2/+2
| | | | | | | | | Also, add context to connect() expressions where we are or were capturing "this". Change-Id: I6e006ba6f83d532478018550d148ee93eca59605 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Use a real 'finishing' phase for RunControlshjk2017-07-171-0/+1
| | | | | | | | | | | | | | | | | | Instead of a blunt delete() RunControl::initiateFinish() is triggered by the closing of the application output instead. The rampdown process is basically the same as stop() now, except for the other success signal (new finished()) and the final self-destruction of the runcontrol. stop() itself triggers initiateStop() on all running workers in parallel (before it was in the order of start). This gives downstream complex worker combinations the flexibility to use any order it wants by ignoring stop() on 'uninteresting' workers, and centralizing rampdown e.g. in the main worker. That setup should be rare in practice, but seems needed in some profiler cases. Change-Id: I986a152a663754206709ed4df0d4568847afad17 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/master' into 4.4Eike Ziller2017-07-041-1/+1
|\ | | | | | | Change-Id: I00fe351ee5f2689366c63ba94b042609c47da777
| * Debugger: Move startupRunConfiguration to RunConfigurationhjk2017-07-041-1/+1
| | | | | | | | | | | | | | It's not really debugger-specific. Change-Id: I2246e08d896df1d625ecce9b8b5428e7ea398851 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Valgrind: Simplify RunControlFactory setuphjk2017-07-031-43/+10
|/ | | | | Change-Id: Ibef142e84ce1d4aca299dd8fa53b1eabcf517100 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Remove virtual RunControl start/stop trampolinhjk2017-06-301-1/+1
| | | | | | | Not needed anymore, effectively replaced by RunWorker start/stop. Change-Id: I7483c841cdd4e05c9e1f7636a27b20ece37947c2 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Use Runnable to pass device informationhjk2017-06-301-1/+0
| | | | | | | ... in case of "External Application" starts. Change-Id: I6a5c215831f16c51e3cf98c35dbb792f53128d42 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Valgrind: Remove starting() signalhjk2017-06-281-8/+2
| | | | | | | | | | | | | | | | It's only used internally as one-time communication between worker and the *Tool singleton that handles toolbar button states. We basically start immediately after creation of the worker, so any pre-start tool bar specific operations can be done at RunWorker creation time. Medium term, the runworker should proably steer "their" buttons more directly. Change-Id: Id6df703746ece5eebc23507739cd2a92ec55d11d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Valgrind: Merge MemCheck{,WithGdb}ToolRunnerhjk2017-06-221-5/+1
| | | | | Change-Id: Iaf0707cf5c06ef29c33da835133948256869c76a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger, QmlProfiler et al: Replace AnalyzerStartParameterhjk2017-06-161-4/+1
| | | | | | | | | | | ... and QmlProfilerRunner::Configuaration by PE::UrlConnection, and call it 'serverUrl' on the user side. That's the only variant we ever had and avoids "translations" between three structures that are essential the same. Change-Id: I33386b2b8d2a7985ff934f6f8f840de0831bf9c1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Announce 'started', not 'stopped' on startuphjk2017-05-161-1/+1
| | | | | | | Also provide a name for the workers. Change-Id: I323c498db1eeb8225170aae080fdf084aa53e14a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Split Target and ToolRunners into smaller taskshjk2017-05-151-13/+15
| | | | | | | | This increases re-usability of activities like 'port gathering', and makes their use less dependent on actual device implementations. Change-Id: I017cb74874f2b38c487ba2d03906a675d5618647 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Move to new target/tool split for local setupshjk2017-05-021-14/+16
| | | | | Change-Id: I1167fdc147600c36149c13731d0680b858acf4fb Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Dissolve Debugger::ActionDescriptionhjk2017-04-241-24/+53
| | | | | | | | | | | | | ActionDescription was a horizontal layer of convenience functionality covering (only) ex-AnalyzerBase based RunControl start scenarios and gets in the way of target/tool orthogonalization. So continue the path chosen with the removal of AnalyzerRunControl: Remove ActionDescription by inlining into user code, then orthogonalize tool-by-tool, then generalize again. Change-Id: Ib597df3f4ad7b06bef06644458fa13ddca53afdb Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* ProjectExplorer: Remove startRunControl()'s runMode parameterhjk2017-04-121-1/+1
| | | | | | | It is redundant, as a RunControl has a runMode() getter. Change-Id: Ia048b271a5003356d21f86a3f778827d23466037 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* ProjectExplorer: Merge AnalyzerRunControl into RunControlhjk2017-04-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The change is "conceptually wrong", the AnalyzerRunControl derived classes' functionality should be provided by ToolRunners based classes encapsulating/"being" the current Analyzer*Runner classes. However, the AnalyzerRunControl is only three (empty even) virtual functions, but a big obstacle in merging attempt due to a lot of mechanical followup changes in downstream users. The current construction mechanism of analyzer run controls is actually two different mechanisms (locally direct RunControlFactories, and a "generic" createAnalyzerRunControl wrapper for remote cases). The generic createAnalyzerRunControl makes it difficult to migrated them one-by-one, due to the various downstream users. So instead of merging the per-analyzer two uses directly reduce the "indirection" distance by removing the AnalyzerRunControl intermediate layer. After that the createAnalyzerRunControl mechanism can be dissolved by using normal RunControlFactories also for the remote cases. After that, porting to ToolRunner, and combining with ther local equivalent can be done one by one. Change-Id: I0ddace33fcce210cf3a547ac5bb23b3d85013934 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* SessionManager: Clean up methods around projectsTim Jenssen2017-03-021-1/+1
| | | | | | | | Clean up methods around projects() and update its usages to modern language standards. Change-Id: Ia0a4574d014ce41e0d511a392e4eed4680981d0e Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Remove spaces in initializer listsTim Jenssen2017-02-221-6/+6
| | | | | | | Format initializer lists code style like. Change-Id: Ib82c235e4ba7dc75ee96a7abc0c47eff7b0a9013 Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Create only one extra configuration aspecthjk2016-10-101-4/+5
| | | | | | | | Let only the Callgrind tool create one, Memcheck shares it now. Task-number: QTCREATORBUG-17053 Change-Id: I29d17ef5801ab295c2523f0748616b9e2aab29ce Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Move icons to UtilsUlf Hermann2016-08-051-3/+2
| | | | | | | This way we can use them from libraries, not only from plugins. Change-Id: Ic35cfd5f04d638d87606bf272b2c00ded1267c1b Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Debugger: Dissolve AnalyzerUtils::logToIssuesPane()hjk2016-05-311-4/+7
| | | | | | | | | If the Error + popup combo is generic it should live in TaskHub. If it is not, end user code should decide when to popup. Not an intermediate level. Change-Id: I195ba8c17c5cc192ff9762ed6f45629143bcbb35 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Icons: Move "next/prev", "[un]locked" and "zoom" from Core to UtilsAlessandro Portale2016-05-311-2/+3
| | | | | | | | | | They are needed in the timeline view. The change in qtcreator-project.qdocconf makes sure that qdoc still finds the referenced icons. Change-Id: I812fba8e57d06d93efc00c295467c83c08cd1784 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
* Debugger: Let perspectives specify their central widgethjk2016-05-131-2/+2
| | | | | | | | | | | The default 0 value will be interpreted as 'use the editor stack'. Also, drop the idea of value semantics for Perspective objects to get a simpler approach to the destruction of owned widgets (tools docks + central widget) Change-Id: Ic6470411ee5d387c43447f95b5a12c81c6658ff8 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Merge remote-tracking branch 'origin/4.0'Eike Ziller2016-05-111-2/+2
|\ | | | | | | | | | | | | | | Conflicts: share/qtcreator/debugger/creatortypes.py src/plugins/beautifier/clangformat/clangformat.cpp Change-Id: I1ab281c190767ced8a6ac2c026a121ea229a36cf
| * Valgrind: Avoid crash when changing filterChristian Stenger2016-05-111-2/+2
| | | | | | | | | | Change-Id: Ie7b0965b21a9fde05009cc649289323cba392b63 Reviewed-by: hjk <hjk@theqtcompany.com>
* | Valgrind: Remove factories from object pool when destroying themUlf Hermann2016-05-111-1/+1
| | | | | | | | | | | | | | Otherwise we get crashes on exit. Change-Id: I806f374ba8f835c9e4361599aa901cfc4b2f0720 Reviewed-by: hjk <hjk@theqtcompany.com>
* | Valgrind: Split MemCheck and CallGrind factorieshjk2016-05-101-11/+46
| | | | | | | | | | | | | | | | The tools are separated everywhere, lumping them into the same RunControlFactory removes modularity artificially. Change-Id: I8d9e917bb114a1898a0c293f18d3bf78a52075aa Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.0'Eike Ziller2016-04-221-2/+2
|\| | | | | | | | | | | | | | | Conflicts: qtcreator.pri qtcreator.qbs Change-Id: I0cbc9d335073e3234f472aa43f462eef9a9178aa