Remove the Aspect Thread

This now makes the Qt3D simulation loop run in the Main Thread.

In theory having the Aspect Thread allowed Qt3D to continue rendering
even if the main thread got locked. In practice however this leads to
a large amount of complexities in the Qt3D implementations and provides
little value as in most cases blocking the main thread would block animations
driven by frontend nodes.

Removing the Aspect Thread will allow to remove the backend tree copies each
aspect had to make which will allow to reduce memory. In addition, getting direct
access to frontend nodes, will now be possible without introducing races which
should allow to make more optimizations and reduce latencies on some operations.

Change-Id: I80e4cd6427de06ddedfa1bb50d40710b91867b24
Reviewed-by: Mike Krus <mike.krus@kdab.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/core/services/qdownloadhelperservice.cpp b/src/core/services/qdownloadhelperservice.cpp
index 4cd89c5d0..deddf3ae0 100644
--- a/src/core/services/qdownloadhelperservice.cpp
+++ b/src/core/services/qdownloadhelperservice.cpp
@@ -39,10 +39,10 @@
 
 #include "qdownloadhelperservice_p.h"
 #include "qdownloadnetworkworker_p.h"
+#include <QtCore/QThread>
 #include <Qt3DCore/QAspectEngine>
 #include <Qt3DCore/private/qabstractserviceprovider_p.h>
 #include <Qt3DCore/private/qaspectengine_p.h>
-#include <Qt3DCore/private/qaspectthread_p.h>
 #include <Qt3DCore/private/qaspectmanager_p.h>
 #include <Qt3DCore/private/qservicelocator_p.h>
 
@@ -196,7 +196,7 @@ QString QDownloadHelperService::urlToLocalFileOrQrc(const QUrl &url)
 QDownloadHelperService *QDownloadHelperService::getService(QAspectEngine *engine)
 {
     auto enginePrivate = Qt3DCore::QAspectEnginePrivate::get(engine);
-    return enginePrivate->m_aspectThread->aspectManager()->serviceLocator()->downloadHelperService();
+    return enginePrivate->m_aspectManager->serviceLocator()->downloadHelperService();
 }
 
 bool QDownloadHelperService::isLocal(const QUrl &url)