summaryrefslogtreecommitdiffstats
path: root/src/quick3d/quick3drender/items
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2023-02-06 17:54:32 +0100
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2023-02-10 16:24:55 +0100
commit8a0d1556600e8763e14bb0a9d3cd1a778acded3d (patch)
tree9f107ea6059fd28700f32c197898c86bf4e1634f /src/quick3d/quick3drender/items
parent99a41d0d3f05699d14a1bac5b408ec0872901d38 (diff)
quick3drender plugin: Disambiguate meta type id constants
Make them function-local to prevent clashes in CMake Unity (Jumbo) builds, Pick-to: 6.5 Task-number: QTBUG-109394 Change-Id: I3c42d2b2f45f5aef5f63ced4f68911d6d34a2884 Reviewed-by: Inho Lee <inho.lee@qt.io> Reviewed-by: Mike Krus <mike.krus@kdab.com>
Diffstat (limited to 'src/quick3d/quick3drender/items')
-rw-r--r--src/quick3d/quick3drender/items/quick3dparameter.cpp6
-rw-r--r--src/quick3d/quick3drender/items/quick3dshaderdata.cpp4
2 files changed, 4 insertions, 6 deletions
diff --git a/src/quick3d/quick3drender/items/quick3dparameter.cpp b/src/quick3d/quick3drender/items/quick3dparameter.cpp
index 7f4147ef1..6fb1f144e 100644
--- a/src/quick3d/quick3drender/items/quick3dparameter.cpp
+++ b/src/quick3d/quick3drender/items/quick3dparameter.cpp
@@ -12,10 +12,6 @@ namespace Qt3DRender {
namespace Render {
namespace Quick {
-namespace {
-const int qjsValueTypeId = qMetaTypeId<QJSValue>();
-}
-
Quick3DParameterPrivate::Quick3DParameterPrivate()
: QParameterPrivate()
{
@@ -23,6 +19,8 @@ Quick3DParameterPrivate::Quick3DParameterPrivate()
void Quick3DParameterPrivate::setValue(const QVariant &value)
{
+ static const int qjsValueTypeId = qMetaTypeId<QJSValue>();
+
if (value.userType() == qjsValueTypeId) {
QJSValue v = value.value<QJSValue>();
if (v.isArray())
diff --git a/src/quick3d/quick3drender/items/quick3dshaderdata.cpp b/src/quick3d/quick3drender/items/quick3dshaderdata.cpp
index d03c900c1..8f92fb8f3 100644
--- a/src/quick3d/quick3drender/items/quick3dshaderdata.cpp
+++ b/src/quick3d/quick3drender/items/quick3dshaderdata.cpp
@@ -14,8 +14,6 @@ namespace Render {
namespace Quick {
namespace {
-
-const int qjsValueTypeId = qMetaTypeId<QJSValue>();
const int quick3DShaderDataArrayTypeId = qMetaTypeId<Quick3DShaderDataArray*>();
Q_DECL_UNUSED const int quick3DShaderDataTypeId = qMetaTypeId<Quick3DShaderData*>();
@@ -30,6 +28,8 @@ public:
QVariant readProperty(const QVariant &v) override
{
+ static const int qjsValueTypeId = qMetaTypeId<QJSValue>();
+
// qjsValueTypeId are not compile time constant (no switch)
if (v.userType() == qjsValueTypeId) {
QJSValue jsValue = v.value<QJSValue>();