diff options
| author | Martin Storsjö <martin@martin.st> | 2024-05-10 10:41:01 +0300 |
|---|---|---|
| committer | Martin Storsjö <martin@martin.st> | 2024-05-11 11:02:39 +0300 |
| commit | 7e6f44f38ba6d9b430e0dbaecaad31f3f9e0619b (patch) | |
| tree | 69b26b7a22a6d266172575637084c63f77534fc9 | |
| parent | ed6d1fa71a79a70b7e6a20fbbc737ed9f6c287b1 (diff) | |
QDnsLookup: Fix -Wc++11-narrowing error on 32 bit Windows
This fixes errors like this, with Clang, for 32 bit Windows targets:
src/network/kernel/qdnslookup_win.cpp:99:54: error: non-constant-expression cannot be narrowed from type 'DWORD' (aka 'unsigned long') to 'qsizetype' (aka 'int') in initializer list [-Wc++11-narrowing]
99 | if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer))
| ^~~~~~~~~~~~~
src/network/kernel/qdnslookup_win.cpp:99:54: note: insert an explicit cast to silence this issue
99 | if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer))
| ^~~~~~~~~~~~~
| static_cast<qsizetype>( )
Change-Id: If313e0910006f7556087f272123a0cfe1239f818
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
| -rw-r--r-- | src/network/kernel/qdnslookup_win.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/network/kernel/qdnslookup_win.cpp b/src/network/kernel/qdnslookup_win.cpp index 92dd95ab53..1b07776db9 100644 --- a/src/network/kernel/qdnslookup_win.cpp +++ b/src/network/kernel/qdnslookup_win.cpp @@ -96,7 +96,7 @@ static DNS_STATUS sendAlternate(QDnsLookupRunnable *self, QDnsLookupReply *reply dnsBuffer->MessageHead.AuthenticatedData = true; QDnsLookupRunnable::ReplyBuffer replyBuffer; - if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer)) + if (!self->sendDnsOverTls(reply, { query.data(), qsizetype(dnsBufferSize) }, replyBuffer)) return DNS_STATUS(-1); // error set in reply // interpret the RCODE in the reply |