diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2023-04-19 14:14:00 -0700 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2023-05-03 11:40:37 -0700 |
| commit | 6d30e7da3dcb2d5596552ac6b94f6599abcc2c2f (patch) | |
| tree | 4af752d2a9c4f009a0de64edf42d3f559129738f /src/corelib/io/qprocess.cpp | |
| parent | edabd36cbbc97bd28de893a6f02a0ab5a79cb479 (diff) | |
QProcess: remove the note that it freezes threads on QNX
The notes were added in commit e3363fd945b3ab961fba720ee013533dd8ba2930
by Rafael, because at the time QNX 6.5.0 did not support fork() in
multithreaded applications. We had to use posix_spawn(3) and that
doesn't support setting the child's working directory, so we needed to
freeze the application while chdir(2)ing in doSpawn().
doSpawn() was removed in commit 005a8bfbf0022f03dafafcf2b5c438ccf0675a49
for Qt 5.7, because fork() works since QNX 6.6.0. But the comments were
accidentally left behind.
Fixes: QTBUG-112990
Pick-to: 5.15 6.2 6.5
Change-Id: I3b169860d8bd41e9be6bfffd17577276eaabb855
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io/qprocess.cpp')
| -rw-r--r-- | src/corelib/io/qprocess.cpp | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/corelib/io/qprocess.cpp b/src/corelib/io/qprocess.cpp index a64f9c9cb5..6764273cb7 100644 --- a/src/corelib/io/qprocess.cpp +++ b/src/corelib/io/qprocess.cpp @@ -591,11 +591,6 @@ void QProcessPrivate::Channel::clear() command line option; X11 applications generally accept a \c{-geometry} command line option. - \note On QNX, setting the working directory may cause all - application threads, with the exception of the QProcess caller - thread, to temporarily freeze during the spawning process, - owing to a limitation in the operating system. - \section1 Synchronous Process API QProcess provides a set of functions which allow it to be used @@ -1633,9 +1628,6 @@ QString QProcess::workingDirectory() const process in this directory. The default behavior is to start the process in the working directory of the calling process. - \note On QNX, this may cause all application threads to - temporarily freeze. - \sa workingDirectory(), start() */ void QProcess::setWorkingDirectory(const QString &dir) @@ -2096,9 +2088,6 @@ void QProcess::startCommand(const QString &command, OpenMode mode) If workingDirectory() is empty, the working directory is inherited from the calling process. - \note On QNX, this may cause all application threads to - temporarily freeze. - If the function is successful then *\a pid is set to the process identifier of the started process; otherwise, it's set to -1. Note that the child process may exit and the PID may become invalid without notice. |