diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2024-01-23 11:32:59 +0100 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2024-01-29 16:06:47 +0100 |
| commit | a6151e2d35b67e628eb1a6932bec39e100a2d692 (patch) | |
| tree | 37d285e4c37377b26b3146fd52865078a0883938 /src/corelib/kernel | |
| parent | 101ab278913e3bacc7c0596ae0a5bf3c0fa2f922 (diff) | |
QJniObject: fix signature of LocalFrame::newLocalRef
The implementation calls a const member function on the QJniObject
passed in, and no move happens. And the parameter is not a universal
reference either.
Found during header review.
Pick-to: 6.7
Task-number: QTBUG-119952
Change-Id: I9479df798178b089277aa230f50f4e73f38ceb2c
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Diffstat (limited to 'src/corelib/kernel')
| -rw-r--r-- | src/corelib/kernel/qjniobject.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/kernel/qjniobject.h b/src/corelib/kernel/qjniobject.h index 292596d208..178a4b7faa 100644 --- a/src/corelib/kernel/qjniobject.h +++ b/src/corelib/kernel/qjniobject.h @@ -40,7 +40,7 @@ class Q_CORE_EXPORT QJniObject return static_cast<T>(jniEnv()->NewLocalRef(object)); } template <typename T> - auto newLocalRef(QJniObject &&object) + auto newLocalRef(const QJniObject &object) { return newLocalRef<T>(object.template object<T>()); } |