QTypeRevision: use comparison helper macros

QTypeRevision consists of two quint8 values: major and minor version.
Each of the versions can be unknown.
The rules for comparing with the unknown version are as follows:

 zero version < unknown version < non-zero version

At the same time, two unknown versions are considered equal.

This makes the comparison a bit tricky, but it still fits into the
category of strong ordering.

Replace the existing friend relational operators with helper functions
and comparison helper macros, making this type strongly ordered.

Update the unit-tests to use the new comparison helper test functions.
As the test functions check the reversed arguments as well, we can
reduce the number of rows for the data-driven comparison test.

Fixes: QTBUG-120359
Change-Id: Ib6f1037fc7b5fed148e35ee48b56b05dcd36b3b4
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>

1 files changed, 1 insertions, 0 deletions

diff --git a/src/corelib/tools/qtyperevision.cpp b/src/corelib/tools/qtyperevision.cpp
index c505e47f2f..6426236288 100644
--- a/src/corelib/tools/qtyperevision.cpp
+++ b/src/corelib/tools/qtyperevision.cpp
@@ -26,6 +26,7 @@ QT_IMPL_METATYPE_EXTERN(QTypeRevision)
     \brief The QTypeRevision class contains a lightweight representation of
            a version number with two 8-bit segments, major and minor, either
            of which can be unknown.
+    \compares strong
 
     Use this class to describe revisions of a type. Compatible revisions can be
     expressed as increments of the minor version. Breaking changes can be