diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2015-12-29 10:04:55 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2016-01-02 10:44:23 +0000 |
| commit | 04e76ec857efea1c28322cd44cb04f15134944fe (patch) | |
| tree | 34b51313e0978b9d13600110d4eb835cad97f663 /src/dbus/qdbusargument.h | |
| parent | be94e009ae5d89d97456f5d1389d2a017dd2e69e (diff) | |
QUnixPrintWidget: fix some poor uses of the QComboBox API
- populate the widget with addItems(QStringList) instead of
looping over addItem(QString)
- Use findText() instead of looping over itemText(int).
QComboBox::findText() delegates searching to the model
(via QAbstractItemModel::match()), so is potentially
much faster. I say potentially, because match() isn't
properly reimplemented in most models, yet. But that is
something to fix in the models.
Change-Id: I6e52cf5af810ab7869c0270504a241868a5ca281
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Diffstat (limited to 'src/dbus/qdbusargument.h')
0 files changed, 0 insertions, 0 deletions