Add -Wweak-vtables to headersclean

This requires some fixes in several classes that are also included
in this patch.

The QTestEvent hierarchy is all-inline and changes layout depending on
QT_GUI_LIB and QT_WIDGETS_LIB, so we can't just export it. Suppress the
warning in that header for now. Created QTBUG-104486 to track a fix for
the real issue.

The QFutureInterface hierarchy is also all-inline, but templates, so
doesn't trigger, except the <void> specialization. Created
QTBUG-125115 to track a fix for the real issue.

Done-with: Marc Mutz <marc.mutz@qt.io>
Task-number: QTBUG-45582
Change-Id: I96b3e109aa989b70e0d4809b90bd53a369e50d55
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>

4 files changed, 8 insertions, 7 deletions

diff --git a/src/gui/accessible/qaccessiblebridge.cpp b/src/gui/accessible/qaccessiblebridge.cpp
index a8b54b0c68..0651c516ea 100644
--- a/src/gui/accessible/qaccessiblebridge.cpp
+++ b/src/gui/accessible/qaccessiblebridge.cpp
@@ -33,6 +33,8 @@ QT_BEGIN_NAMESPACE
 
     Destroys the accessibility bridge object.
 */
+QAccessibleBridge::~QAccessibleBridge()
+    = default;
 
 /*!
     \fn void QAccessibleBridge::setRootObject(QAccessibleInterface *object)
diff --git a/src/gui/accessible/qaccessiblebridge.h b/src/gui/accessible/qaccessiblebridge.h
index 4d817c8e58..753f59597a 100644
--- a/src/gui/accessible/qaccessiblebridge.h
+++ b/src/gui/accessible/qaccessiblebridge.h
@@ -16,10 +16,10 @@ QT_BEGIN_NAMESPACE
 class QAccessibleInterface;
 class QAccessibleEvent;
 
-class QAccessibleBridge
+class Q_GUI_EXPORT QAccessibleBridge
 {
 public:
-    virtual ~QAccessibleBridge() {}
+    virtual ~QAccessibleBridge();
     virtual void setRootObject(QAccessibleInterface *) = 0;
     virtual void notifyAccessibilityUpdate(QAccessibleEvent *event) = 0;
 };
diff --git a/src/gui/text/qtextdocument.cpp b/src/gui/text/qtextdocument.cpp
index 31cb3a526a..c39d3514c5 100644
--- a/src/gui/text/qtextdocument.cpp
+++ b/src/gui/text/qtextdocument.cpp
@@ -53,6 +53,9 @@ namespace {
     QTextDocument::ResourceProvider qt_defaultResourceProvider;
 };
 
+QAbstractUndoItem::~QAbstractUndoItem()
+    = default;
+
 /*!
     \fn bool Qt::mightBeRichText(QAnyStringView text)
 
diff --git a/src/gui/text/qtextdocument.h b/src/gui/text/qtextdocument.h
index b6253bfa46..11a8abcb50 100644
--- a/src/gui/text/qtextdocument.h
+++ b/src/gui/text/qtextdocument.h
@@ -45,15 +45,11 @@ namespace Qt
 class Q_GUI_EXPORT QAbstractUndoItem
 {
 public:
-    virtual ~QAbstractUndoItem() = 0;
+    virtual ~QAbstractUndoItem();
     virtual void undo() = 0;
     virtual void redo() = 0;
 };
 
-inline QAbstractUndoItem::~QAbstractUndoItem()
-{
-}
-
 class QTextDocumentPrivate;
 
 class Q_GUI_EXPORT QTextDocument : public QObject