diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2023-08-07 10:14:49 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@qt.io> | 2023-08-18 12:30:41 +0200 |
| commit | 6b1a4afc75c312ece7985177abf32637eeb2aaa7 (patch) | |
| tree | 207ba617cc3fc88120a34a1ad10f21b247cbaa4c /src/charts/axis/polarchartaxisradial.cpp | |
| parent | a15f7570c67aabbab9beaa1e8eeb9631edebea58 (diff) | |
Mark QtCharts (the library) as free of Q_FOREACH, except where it isn't
The density of Q_FOREACH uses is exremely high here, too high for this
author, unfamiliar with this code, to tackle in a short amount of
time. Even if they're not concentrated in just a few TUs, we need to
make progress on a global QT_NO_FOREACH default, so grab the nettle
and stick to our strategy:
Mark the whole library with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115824 to keep track of
this, and other such follow-up changes in this module.
Task-number: QTBUG-115824
Change-Id: If90d9e29bc4fdce1da97f663be35aa715bd6478b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Diffstat (limited to 'src/charts/axis/polarchartaxisradial.cpp')
| -rw-r--r-- | src/charts/axis/polarchartaxisradial.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/charts/axis/polarchartaxisradial.cpp b/src/charts/axis/polarchartaxisradial.cpp index 46d8ca77..80857e4b 100644 --- a/src/charts/axis/polarchartaxisradial.cpp +++ b/src/charts/axis/polarchartaxisradial.cpp @@ -1,6 +1,8 @@ // Copyright (C) 2016 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only +#undef QT_NO_FOREACH // this file contains unported legacy Q_FOREACH uses + #include <QtCharts/qcategoryaxis.h> #include <QtCharts/qlogvalueaxis.h> #include <QtCore/qmath.h> |