Port Q_FOREACH to ranged-for, iterating over a temporary

The loops are iterating over a temporary, so hold the temporary in a
local const container and use ranged-for.

In files where all foreach usages are ported, un-whitelist them by
removing "#undef QT_NO_FOREACH".

Change-Id: I9e7c9d16404fd78b3cf61465d922616de8e4a1a1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>

1 files changed, 2 insertions, 1 deletions

diff --git a/src/charts/piechart/qpieseries.cpp b/src/charts/piechart/qpieseries.cpp
index a7b1bdf7..4f6af014 100644
--- a/src/charts/piechart/qpieseries.cpp
+++ b/src/charts/piechart/qpieseries.cpp
@@ -988,7 +988,8 @@ QList<QLegendMarker*> QPieSeriesPrivate::createLegendMarkers(QLegend* legend)
 {
     Q_Q(QPieSeries);
     QList<QLegendMarker*> markers;
-    foreach(QPieSlice* slice, q->slices()) {
+    const auto slices = q->slices();
+    for (QPieSlice *slice : slices) {
         QPieLegendMarker* marker = new QPieLegendMarker(q,slice,legend);
         markers << marker;
     }