Port Q_FOREACH to ranged-for, iterating over a temporary

The loops are iterating over a temporary, so hold the temporary in a
local const container and use ranged-for.

In files where all foreach usages are ported, un-whitelist them by
removing "#undef QT_NO_FOREACH".

Change-Id: I9e7c9d16404fd78b3cf61465d922616de8e4a1a1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>

1 files changed, 6 insertions, 3 deletions

diff --git a/src/charts/qchart.cpp b/src/charts/qchart.cpp
index 14f95fe0..149f3629 100644
--- a/src/charts/qchart.cpp
+++ b/src/charts/qchart.cpp
@@ -276,7 +276,8 @@ void QChart::removeSeries(QAbstractSeries *series)
  */
 void QChart::removeAllSeries()
 {
-    foreach (QAbstractSeries *s ,  d_ptr->m_dataset->series()){
+    const auto series = d_ptr->m_dataset->series();
+    for (QAbstractSeries *s : series) {
         removeSeries(s);
         delete s;
     }
@@ -487,12 +488,14 @@ QList<QAbstractAxis *> QChart::axes(Qt::Orientations orientation, QAbstractSerie
     QList<QAbstractAxis *> result ;
 
     if (series) {
-        foreach (QAbstractAxis *axis, series->attachedAxes()){
+        const auto axes = series->attachedAxes();
+        for (QAbstractAxis *axis : axes) {
             if (orientation.testFlag(axis->orientation()))
                 result << axis;
         }
     } else {
-        foreach (QAbstractAxis *axis, d_ptr->m_dataset->axes()){
+        const auto axes = d_ptr->m_dataset->axes();
+        for (QAbstractAxis *axis : axes) {
             if (orientation.testFlag(axis->orientation()) && !result.contains(axis))
                 result << axis;
         }