diff options
author | Kaj Grönholm <kaj.gronholm@qt.io> | 2020-11-03 10:29:22 +0200 |
---|---|---|
committer | Kaj Grönholm <kaj.gronholm@qt.io> | 2020-11-05 10:00:37 +0200 |
commit | 5fa85ded71f4bd81b6332d8aecda3edd658f7a39 (patch) | |
tree | 96afc61930beab961bbc99e570415744b22b479f /src/particles/qquickparticlegroup_p.h | |
parent | 43d0eae81e30ae8c8502e68d56c6c8b7e2c30215 (diff) |
Cleanup and optimize particles
Minor improvements while going through the particles sources:
- Reduce getShadowDatum() calls
- Remove unused m_lastLevel, reloadColor(), m_available
m_velocityFromMovement, maximumAlive, m_pending, m_lastT,
m_last_last_last_emitter, modelIndex
- Color4ub structs can be assigned directly
- Fix pri for shaders_ng files
- Other minor refactoring
Task-number: QTBUG-88124
Change-Id: I5768fed9f4b6379a698849c23436fa38169833a4
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'src/particles/qquickparticlegroup_p.h')
-rw-r--r-- | src/particles/qquickparticlegroup_p.h | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/src/particles/qquickparticlegroup_p.h b/src/particles/qquickparticlegroup_p.h index 9b13153a95..6df1e61563 100644 --- a/src/particles/qquickparticlegroup_p.h +++ b/src/particles/qquickparticlegroup_p.h @@ -58,9 +58,6 @@ QT_BEGIN_NAMESPACE class QQuickParticleGroup : public QQuickStochasticState, public QQmlParserStatus { Q_OBJECT - //### Would setting limits per group be useful? Or clutter the API? - //Q_PROPERTY(int maximumAlive READ maximumAlive WRITE setMaximumAlive NOTIFY maximumAliveChanged) - Q_PROPERTY(QQuickParticleSystem* system READ system WRITE setSystem NOTIFY systemChanged) //Intercept children requests and assign to the group & system @@ -75,11 +72,6 @@ public: QQmlListProperty<QObject> particleChildren(); - int maximumAlive() const - { - return m_maximumAlive; - } - QQuickParticleSystem* system() const { return m_system; @@ -87,22 +79,12 @@ public: public Q_SLOTS: - void setMaximumAlive(int arg) - { - if (m_maximumAlive != arg) { - m_maximumAlive = arg; - Q_EMIT maximumAliveChanged(arg); - } - } - void setSystem(QQuickParticleSystem* arg); void delayRedirect(QObject* obj); Q_SIGNALS: - void maximumAliveChanged(int arg); - void systemChanged(QQuickParticleSystem* arg); protected: @@ -113,7 +95,6 @@ private: void performDelayedRedirects(); - int m_maximumAlive; QQuickParticleSystem* m_system; QList<QObject*> m_delayedRedirects; }; |