QQmlProperty: Don't unnecessarily call QStringView::toString()

All those methods can use QStringView.

Change-Id: Ic79ab024ca933e7a21017ee498eb2d486b49ae6e
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>

1 files changed, 5 insertions, 6 deletions

diff --git a/src/qml/qml/qqmlproperty.cpp b/src/qml/qml/qqmlproperty.cpp
index 1d614226e4..bed1d951c4 100644
--- a/src/qml/qml/qqmlproperty.cpp
+++ b/src/qml/qml/qqmlproperty.cpp
@@ -380,7 +380,6 @@ void QQmlPropertyPrivate::initProperty(QObject *obj, const QString &name,
         return false;
     };
 
-    const QString terminalString = terminal.toString();
     const auto findSignal = [&](const QString &signalName) {
         if (ddata && ddata->propertyCache) {
             // Try method
@@ -399,21 +398,21 @@ void QQmlPropertyPrivate::initProperty(QObject *obj, const QString &name,
                 return true;
             }
 
-            return findChangeSignal(terminalString);
+            return findChangeSignal(terminal);
         }
 
         return findSignalInMetaObject(signalName.toUtf8());
     };
 
-    auto signalName = QQmlSignalNames::handlerNameToSignalName(terminalString);
+    auto signalName = QQmlSignalNames::handlerNameToSignalName(terminal);
     if (signalName) {
         if (findSignal(*signalName))
             return;
     } else {
-        signalName = QQmlSignalNames::badHandlerNameToSignalName(terminalString);
+        signalName = QQmlSignalNames::badHandlerNameToSignalName(terminal);
         if (signalName) {
             qWarning()
-                    << terminalString
+                    << terminal
                     << "is not a properly capitalized signal handler name."
                     << QQmlSignalNames::signalNameToHandlerName(*signalName)
                     << "would be correct.";
@@ -431,7 +430,7 @@ void QQmlPropertyPrivate::initProperty(QObject *obj, const QString &name,
             if (!property->isFunction()) {
                 object = currentObject;
                 core = *property;
-                nameCache = terminalString;
+                nameCache = terminal.toString();
                 return;
             }
             property = ddata->propertyCache->overrideData(property);