diff options
| author | Shawn Rutledge <shawn.rutledge@qt.io> | 2023-01-30 19:13:23 +0100 |
|---|---|---|
| committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2023-02-08 00:44:52 +0100 |
| commit | 8dbb9ca52a625baf554f83cd7aad6edf8356c263 (patch) | |
| tree | 9f7efa4b6885d60413697e70bad23c741d37b7ec /src/quick/designer | |
| parent | 59560358139fc8311436d07ac90e273abb884e6a (diff) | |
QQuickItemPrivate::itemToParentTransform: pass transform by pointer
https://wiki.qt.io/API_Design_Principles#Pointers_vs._References
says we prefer pointers for out-parameters because it's clearer at the
call site that the argument will be modified. Amends
bfb3c424abc7c839dc44de0e36024ede99ece736
As a drive-by, re-indented nearby internal doc comments.
Change-Id: Id7f377e94e6917185fc26d7ac7c564841d45a257
Reviewed-by: MikoĊaj Boc <Mikolaj.Boc@qt.io>
Reviewed-by: JiDe Zhang <zhangjide@uniontech.com>
Diffstat (limited to 'src/quick/designer')
| -rw-r--r-- | src/quick/designer/qquickdesignersupport.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/quick/designer/qquickdesignersupport.cpp b/src/quick/designer/qquickdesignersupport.cpp index 5fccd43e96..6f937e38d6 100644 --- a/src/quick/designer/qquickdesignersupport.cpp +++ b/src/quick/designer/qquickdesignersupport.cpp @@ -139,7 +139,7 @@ QTransform QQuickDesignerSupport::parentTransform(QQuickItem *referencedItem) QTransform parentTransform; - QQuickItemPrivate::get(referencedItem)->itemToParentTransform(parentTransform); + QQuickItemPrivate::get(referencedItem)->itemToParentTransform(&parentTransform); return parentTransform; } |