diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2022-07-13 10:54:17 +0200 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2022-07-13 20:04:00 +0200 |
| commit | 813ba0591893fcca2b427dee73106c8773c3b59f (patch) | |
| tree | 5d1d8d7710f4cbaa72597f325c08ff15f2bc67d8 /src/quick/items/qquickitemviewtransition.cpp | |
| parent | a08eb13e7a19f86119b9dcdb5ac3e72062fe7edc (diff) | |
Fix memory leak in QQuickItemViewTransitionableItem::completeTransition
As we're not storing the QQuickTransitionInstance anywhere, we better
delete it when the function returns.
Pick-to: 6.2 6.3 6.4
Change-Id: Ife4d0eee559cffd26ddd9aab8c89729269bb93e1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/quick/items/qquickitemviewtransition.cpp')
| -rw-r--r-- | src/quick/items/qquickitemviewtransition.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/quick/items/qquickitemviewtransition.cpp b/src/quick/items/qquickitemviewtransition.cpp index b8cf6c3180..365a8fc588 100644 --- a/src/quick/items/qquickitemviewtransition.cpp +++ b/src/quick/items/qquickitemviewtransition.cpp @@ -490,7 +490,8 @@ void QQuickItemViewTransitionableItem::completeTransition(QQuickTransition *quic QQuickStateOperation::ActionList actions; // not used QList<QQmlProperty> after; // not used - auto instance = quickTransition->prepare(actions, after, transition, item); + QScopedPointer<QQuickTransitionInstance> instance( + quickTransition->prepare(actions, after, transition, item)); RETURN_IF_DELETED(instance->complete()); clearCurrentScheduledTransition(); |