diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2017-03-06 17:25:45 +0100 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@qt.io> | 2021-02-01 16:40:27 +0100 |
commit | 24ec3b3e7fa09900d791dcaedb0820a0b1890336 (patch) | |
tree | 0a3d470d58fea28add839e4083c84e411cddeaa4 /tests/manual/v4 | |
parent | 125c0fc0b7f51847d2e6c92433c82c3e8982abb0 (diff) |
Prefer qHypot() over sqrt(a sum of squares)
It's apt to be more accurate and may even be optimised.
Comment on a benchmark where we could use Math.hypot(), but that would
break comparison with Qt 5 results.
Change-Id: I7c37dd3df82fdef18e7ebb0e1548198afd256faa
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'tests/manual/v4')
-rw-r--r-- | tests/manual/v4/v8-bench.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/manual/v4/v8-bench.js b/tests/manual/v4/v8-bench.js index bfce6231e4..33f39688c2 100644 --- a/tests/manual/v4/v8-bench.js +++ b/tests/manual/v4/v8-bench.js @@ -3645,6 +3645,7 @@ Flog.RayTracer.Vector.prototype = { }, magnitude : function() { + // return Math.hypot(this.x, this.y, this.z); but keep results Qt5-comparable: return Math.sqrt((this.x * this.x) + (this.y * this.y) + (this.z * this.z)); }, |