aboutsummaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@qt.io>2024-05-08 13:25:12 +0200
committerUlf Hermann <ulf.hermann@qt.io>2024-05-11 21:40:32 +0200
commit32b85f81dd22d6cd598580c956cd08d46338b060 (patch)
tree50504f1205c3b96af0c76c4d7c70a782897ed481 /tests
parenta5ad1d8855f8243adddf0fffcd84e14d32a5ca90 (diff)
ecmascripttests: Actually fail the test if the runner crashes
The runner can have a "normal" exit status but a non-zero exit code. That's still a crash. Amends commit 4e0cf9658a28b7d048a016b9d0ab5926964e9a60 Change-Id: Ia803a947b51c9ea5486d0ca5b6cdd9c01040c84f Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
Diffstat (limited to 'tests')
-rw-r--r--tests/auto/qml/ecmascripttests/test262runner.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/auto/qml/ecmascripttests/test262runner.cpp b/tests/auto/qml/ecmascripttests/test262runner.cpp
index dc6d660e3d..d87a8a9552 100644
--- a/tests/auto/qml/ecmascripttests/test262runner.cpp
+++ b/tests/auto/qml/ecmascripttests/test262runner.cpp
@@ -223,8 +223,8 @@ void Test262Runner::createProcesses()
});
QObject::connect(&p, &QProcess::finished, this,
- [this, processCount, i](int, QProcess::ExitStatus status) {
- if (status != QProcess::NormalExit) {
+ [this, processCount, i](int exitCode, QProcess::ExitStatus status) {
+ if (status != QProcess::NormalExit || exitCode != 0) {
TestData &testData(currentTasks[i]);
auto &result = testData.stillNeedStrictRun