diff options
| author | Sze Howe Koh <szehowe.koh@gmail.com> | 2020-08-29 17:12:34 +0800 |
|---|---|---|
| committer | Sze Howe Koh <szehowe.koh@gmail.com> | 2020-08-29 23:35:54 +0800 |
| commit | 5e6474dba9392c8439a5c9cc877fbb1570337a6c (patch) | |
| tree | 1a7496be66c764b9998a1c22388d197e146e948a /doc/src/snippets | |
| parent | b2bf2210d0ffed593b72cec258b8b767c44c6d9a (diff) | |
Doc: Simplify example for specifying overloaded signals/slots
Keep qOverload<> only, which is arguably better than all the others:
* QOverload<>::of is obsolete since Qt 6 requires C++17
* static_cast<> is harder to read
* The explicitly-typed function pointer variable is arguably harder to
read too:
auto mySlot = qOverload<int>(&QLCDNumber::display);
vs.
void (QLCDNumber::*mySlot)(int) = &QLCDNumber::display;
Change-Id: I6cba15bcf1b46b4fecd704b4d842deb4be5db81f
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Diffstat (limited to 'doc/src/snippets')
| -rw-r--r-- | doc/src/snippets/signalsandslots/signalslotsyntaxes.cpp | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/doc/src/snippets/signalsandslots/signalslotsyntaxes.cpp b/doc/src/snippets/signalsandslots/signalslotsyntaxes.cpp index a6d9aa6f8..ec7bcb4f1 100644 --- a/doc/src/snippets/signalsandslots/signalslotsyntaxes.cpp +++ b/doc/src/snippets/signalsandslots/signalslotsyntaxes.cpp @@ -1,6 +1,6 @@ /**************************************************************************** ** -** Copyright (C) 2017 Sze Howe Koh <szehowe.koh@gmail.com> +** Copyright (C) 2020 Sze Howe Koh <szehowe.koh@gmail.com> ** Contact: https://www.qt.io/licensing/ ** ** This file is part of the documentation of the Qt Toolkit. @@ -143,20 +143,7 @@ void DemoWidget::demoOverloadConnect() connect(slider, SIGNAL(valueChanged(int)), lcd, SLOT(display(int))); - // Functor-based syntax, first alternative - connect(slider, &QSlider::valueChanged, - lcd, static_cast<void (QLCDNumber::*)(int)>(&QLCDNumber::display)); - - // Functor-based syntax, second alternative - void (QLCDNumber::*mySlot)(int) = &QLCDNumber::display; - connect(slider, &QSlider::valueChanged, - lcd, mySlot); - - // Functor-based syntax, third alternative - connect(slider, &QSlider::valueChanged, - lcd, QOverload<int>::of(&QLCDNumber::display)); - - // Functor-based syntax, fourth alternative (requires C++14) + // Functor-based syntax connect(slider, &QSlider::valueChanged, lcd, qOverload<int>(&QLCDNumber::display)); //! [overload] |