summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Blechmann <tim@klingt.org>2024-04-16 10:48:27 +0800
committerTim Blechmann <tim@klingt.org>2024-04-18 20:43:17 +0800
commit6d62ffd1100cf42716de6bb76223ec899fec650d (patch)
tree8b71596d3a0859a1f9492544916f42d553580422
parent7c214817645d0f3475945fc1dcbb94f455280e25 (diff)
GStreamer: tweak thumbnail test
Qt interprets GST_TAG_IMAGE as CoverArtImage and GST_TAG_PREVIEW_IMAGE as ThumbnailImage. This is the reverse of the ffmpeg backend. Task-number: QTBUG-124380 Pick-to: 6.5 6.7 Change-Id: Ifb8f2837775893a55de7516fff82772292deab12 Reviewed-by: Artem Dyomin <artem.dyomin@qt.io>
-rw-r--r--tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp
index d195eabfe..52e89a2be 100644
--- a/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp
+++ b/tests/auto/integration/qmediaplayerbackend/tst_qmediaplayerbackend.cpp
@@ -2162,6 +2162,10 @@ void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHas
void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHasThumbnail()
{
+ // QTBUG-124380: gstreamer reports CoverArtImage instead of ThumbnailImage
+ QMediaMetaData::Key key =
+ isGStreamerPlatform() ? QMediaMetaData::CoverArtImage : QMediaMetaData::ThumbnailImage;
+
// Arrange
QFETCH(const MaybeUrl, mediaUrl);
QFETCH(const bool, hasThumbnail);
@@ -2175,7 +2179,7 @@ void tst_QMediaPlayerBackend::metadata_returnsMetadataWithThumbnail_whenMediaHas
// Act
const QMediaMetaData metadata = m_fixture->player.metaData();
- const QImage thumbnail = metadata.value(QMediaMetaData::ThumbnailImage).value<QImage>();
+ const QImage thumbnail = metadata.value(key).value<QImage>();
// Assert
QCOMPARE_EQ(!thumbnail.isNull(), hasThumbnail);