Cache deserialized manager URIs to promote data sharing

When deserializing ID objects, construct the resulting objects from
cached instances of the manager URI string so that the resulting
ID objects can share a string data representation.

Change-Id: If3091bfc42e61938a823a9d2bfc68d0dafec0977
Reviewed-by: Christopher Adams <chris.adams@jollamobile.com>
Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>

1 files changed, 18 insertions, 1 deletions

diff --git a/src/contacts/qcontactmanager_p.cpp b/src/contacts/qcontactmanager_p.cpp
index 9472c00e6..4f42e0ac3 100644
--- a/src/contacts/qcontactmanager_p.cpp
+++ b/src/contacts/qcontactmanager_p.cpp
@@ -425,7 +425,7 @@ bool QContactManagerData::parseIdString(const QString &idString, QString *manage
         *managerName = unescapeParam(mgrName);
 
     if (managerUri)
-        *managerUri = prefix + QLatin1Char(':') + mgrName + QLatin1Char(':') + paramString;
+        *managerUri = cachedUri(prefix + QLatin1Char(':') + mgrName + QLatin1Char(':') + paramString);
 
     // and unescape the engine id string
     if (engineIdString)
@@ -479,4 +479,21 @@ QString QContactManagerData::buildIdString(const QString &managerName, const QMa
     return idString;
 }
 
+/*!
+    Returns a cached instance of the manager URI string that matches \a managerUri.
+    This instance should be preferred when constructing ID objects in order to promote
+    data sharing of the URI string.
+*/
+QString QContactManagerData::cachedUri(const QString &managerUri)
+{
+    static QStringList managerUris;
+
+    int index = managerUris.indexOf(managerUri);
+    if (index != -1)
+        return managerUris.at(index);
+
+    managerUris.append(managerUri);
+    return managerUri;
+}
+
 QT_END_NAMESPACE_CONTACTS