summaryrefslogtreecommitdiffstats
path: root/git-hooks
Commit message (Collapse)AuthorAgeFilesLines
* Improve specificity of sanity-bot complaints for 3rd party ChangeLogHEADmasterDaniel Smith2024-03-251-3/+10
| | | | | | | | | | | Verify that the form of [Third-Party Code] is correct in the ChangeLog. amends d18cc13199ecb8ad833f759006fdf68b7703878c. Task-number: QTQAINFRA-6097 Change-Id: If4f75a0beb0e19bc5441043fad95c536153dece2 Reviewed-by: Daniel Smith <daniel.smith@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Complain if qt_attribution.json is modified without changelog entryDaniel Smith2024-03-201-0/+15
| | | | | | | | | | If the qt_attribution.json file is modified without a corresponding [ChangeLog][Third-Party Code] entry in the commit message, or vise versa, give a -1 sanity vote. Task-number: QTQAINFRA-6097 Change-Id: I959e0a0678faaae2578911c1d4ee3dd5d3ca61d8 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Ignore branch validity for LTS release branch targets in public reposDaniel Smith2024-03-181-5/+11
| | | | | | | | | | | | | | | Since LTS release branches may not exist in the public repo, sanitize-commit cannot validate Pick-to: targets for them when evaluating public commits. This change bypasses the branch validation check for release targets to known LTS branches. In the event that the target branch is not a valid branch in the end, the cherry-pick bot will simply fail to perform the requested pick and post an error message to the change, alerting the author. Fixes: QTQAINFRA-6191 Change-Id: Id87b9e6fd379ad741801f339d42c13dca1f51123 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Perform generated file checks on a wider set of file typesDaniel Smith2024-01-291-10/+15
| | | | | | | | | | | | | | Fixup for 62c866e68f82d0c940c7c4ee5faff3e517b82ecd. Simply adding the newly generated keywords did not suffice for detecting headers generated by Sol, as they use the .hpp extension. This caused them to fall under a condition that didn't set the $check_gen flag. This issue could also affect other file types, so a more generic check is necessary. Change-Id: I3422d14f1cf35c512c48d7e12e8c5dbfaf1d6026 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Daniel Smith <daniel.smith@qt.io>
* Update generated file detection for SolDaniel Smith2024-01-161-1/+1
| | | | | | | | | Expand the generated file regex to allow for "This file was generated with a script." Change-Id: Iaa896d0718afca87cccd7f07a94e7a79f25d9bb4 Reviewed-by: Daniel Smith <Daniel.Smith@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Update commit-msg hook from gerrit upstreamOrgad Shaneh2024-01-051-159/+93
| | | | | | Change-Id: I41d1efe4783fd0abef3b4d308f5f6ba1aec69fa5 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* commit-msg: Place Coverity-Id before Change-IdOrgad Shaneh2023-10-141-1/+1
| | | | | | Change-Id: I41cb6c482189a8273ac123c66ef8f76ae5679b14 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Don't block committing when clang-format produces a diffVolker Hilsheimer2023-09-211-5/+4
| | | | | | | | | | | | | | clang-format producing a diff with possible format improvements is useful, but shouldn't block a commit. The commit author can run `git clang-format` and selectively add the changes the tool suggests the commit by staging relevant chunks and ammending it. Change-Id: I19d8bfc0749e2ecabcc2c298029daafda8ba9d55 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
* Remove warning about leftover Pick-to footers in cherry-picksDaniel Smith2023-09-111-47/+40
| | | | | | | | | | | | | | | The cherry-pick bot will now "waterfall" changes down from newest to oldest, so Pick-to footers are expected to remain in cherry-picks until all targets are exhausted. Ideally, we'd ensure that no excess entries remain, but that would require examining the named branches, which would be complex and would require ensuring that the refs are current, which both seem unreasonable. Therefore, we simply suppress the check in cherry-picks. Change-Id: I20a77603779654d113e80121b50491239c048e36 Reviewed-by: Daniel Smith <Daniel.Smith@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Also nag about enum deprecation adjustmentsEdward Welbourne2023-08-281-1/+1
| | | | | | | | | | The nag about deprecation adjustments missed out on Q_DECL_ENUMERATOR_DEPRECATED and its _X() variant. These are used raw, instead of via a config-controlled macro. Include them, at least until we sort out a suitable intermediary. Change-Id: Ifde903bde61d8875653c8b4b1b6d5d8ce714ed94 Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Limit deprecation adjustments grumbleEdward Welbourne2023-08-241-1/+3
| | | | | | | | | | | | | | | | | | Where developers deprecate things we want to remind them that they have a duty to sort out all existing Qt code that exercises the newly-deprecated API. However, we were producing the same warning also for the #if-ery around blocks of deprecations (which doesn't need it, as the deprecations within will get it) and for the additions of new version-specific deprecation defines. These can be distinguished as preprocessor directives - specifically #if and #define, although #else or #endif may also have a comment on it echoing #if's condition. So skip this check on all preprocessor commands, so we only grumble where the macros are used to deprecate declarations. Change-Id: Ie296d81a932bd098c54f9e166f3b0609c4af34fd Reviewed-by: Daniel Smith <Daniel.Smith@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Complain when there are two newlines back to backCasimir Saastamoinen2023-08-091-0/+5
| | | | | | Task-number: QTQAINFRA-5498 Change-Id: I94360ee7407f247c35ce54d48cb0f08101d05511 Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Handle branch prefixes for pick targetsDaniel Smith2023-07-211-1/+9
| | | | | | | | | | | | | The sanity bot does not presently handle Pick-to: branch targets when the branch contains a prefix. Since Pick-to: targets are always bare, we should test for the branch including allowed prefixes. Public LTS branches are prefixed with "lts-". TQtC private branches are prefixed with "tqtc/lts-". Change-Id: I31fba92bf39fc92e06f0bf8e0c93ef6874151935 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Verify the presence of a space following a colon in footersDaniel Smith2023-06-201-1/+4
| | | | | | | Fixes: QTQAINFRA-5638 Change-Id: I2c224da115952004458ad2180c52ea0e3ed50ed6 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* sanitize-commit: Warn about extraneous semicolons after Qt macrosOlivier De Cannière2023-06-081-0/+32
| | | | | | | | | | | | This patch adds checks for extraneous semicolons after Qt macros. These macros can be 'object-like' such as Q_OBJECT or 'function-like' such as 'Q_PROPERTY(...)'. The macros are grouped in two lists according to their type. These lists can easily be expanded in the future by adding new entries. Change-Id: Ia7237381de768efe357ab5b790eee100bd282e69 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Don't advocate use of Q_OS_OSX to replace Q_OS_MAC && !Q_OS_IOSEdward Welbourne2023-06-081-1/+1
| | | | | | | Out of date advice in the inanity 'bot. Change-Id: I0c63d9b44841072548fbcd6bf9cdc4ab30ddd1de Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Do not check spelling of licensesKai Köhne2023-05-151-1/+1
| | | | | | | | | | The top-level LICENSES directory is reserved for standard license texts. It does not make much sense to complain about spelling there (for instance licence -> license) Change-Id: Id6eb682a71d7188a0b36ddf6e8601913f277d611 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* sanitize-commit: add support for C++17 if-constexprMarc Mutz2023-05-091-1/+1
| | | | | | | | | | | | ... to flow-control-keyword white-space check, so if constexpr(foo) { doesn't go undetected anymore. Change-Id: I1dbdb5ffd1f1f4e0ce72914d7d75beb3f6c10889 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* sanitize-commit: complain about missing Coverity-Id footersMarc Mutz2023-04-281-0/+9
| | | | | | Change-Id: Ib24710488f48b0466fe3c222aad996b506c47494 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Allow non-numeric branches which do not begin with wip/Daniel Smith2023-03-291-1/+8
| | | | | | | | | | | | | | | | | Some repos are better suited to tracking remote branch names from other projects, rather than following the Qt branching scheme. When these branches do not conform to \d+.\d+.\d+, they are not included in the %allHeads of the sanity bot. As such, attempting to cherry-pick to any of these non-conforming branches will be given a -2 by the bot since it is unaware of the branch, even though the pick target is valid. Provide an option per repo to bypass, allowing non-numeric branches. Fixes: QTQAINFRA-5449 Change-Id: I6ca7772703572fdcc010f31dc9bacbbf4fa5e6a2 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
* Add additional language to autogenerated file detectionDaniel Smith2023-03-031-1/+1
| | | | | | | Fixes: QTQAINFRA-5306 Change-Id: I9a43bb402f001ea72c58098e3154744e16438c76 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Add a check for QT_DEPRECATED macrosDaniel Smith2023-02-071-0/+3
| | | | | | | | | | | If a QT_DEPRECATED macro is added anywhere, the uploader should be reminded to also provide patches which update usages of the deprecated function. Task-number: QTQAINFRA-5376 Change-Id: Ie232e54e123da0060a854dedbeecd276322e3410 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Add 6.5 to the list of LTS branches for sanity botDaniel Smith2023-01-171-1/+1
| | | | | | Change-Id: Idc65f649f33ed78e8ddd58d0a124d5b325168f55 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Dimitrios Apostolou <jimis@qt.io>
* Include tqtc/lts- and lts- branches in the list of all headsDaniel Smith2023-01-171-1/+1
| | | | | | | | | | | When these branches are missing from the heads, the sanity bot wrongly claims "Cherry-pick's source is not an upstream commit" when picking from an LTS branch to anywhere. Fixes: QTQAINFRA-5361 Change-Id: I9c35b61ca0f913aa5ec956aa947b928cfe685fba Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Dimitrios Apostolou <jimis@qt.io>
* sanity: Complain about Q_CLANG_QDOCTor Arne Vestbø2022-10-041-0/+3
| | | | | | | | | | | qdoc is always based on clang these days, so Q_CLANG_QDOC can be reduced to just Q_QDOC. Change-Id: I56293e37126eeb8bb7b7d74ad1e35016811a3d9c Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Complain when pick-to footers do not contain the latest stable branchDaniel Smith2022-06-301-0/+18
| | | | | | | | | | | | | If a change targets the latest-1 stable branch, but neglects to include the current latest, the sanity bot should give a -1 warning with a comment. This situation often arises in changes shortly after qt branches to a new stable branch, as it's easy to forget the latest branch target has moved forward. Task-number: QTQAINFRA-5035 Change-Id: I2067c9b1865bd290183d77e46bca2f491708ca2b Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Warn about header files with a common non-.h extensionLuca Di Sera2022-06-281-1/+4
| | | | | | | | | | | | | | | It is an implied convention in the Qt project that header files should use a ".h" extension. As this might non be known by a contributor (especially if the contributor is from outside the QtCompany) or escape review, possibly requiring a bigger amount of work to change later, a new warning in the commit sanitizer script was included to warn about new files that have some common header extension that is not ".h". Change-Id: I83a25d829a63811c08a11f2a337707c62423f699 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Leave sanitize-commit's $target undefined when no branch is givenEdward Welbourne2022-05-031-2/+2
| | | | | | | | | | | | | | | | | | It was previously unconditionally set, either to false or to the branch passed on the command line; but code tests it using defined($target), which was thus always true. Apparently the intent was to leave it undefined when no branch was given. Exposed by configuring my local repositories for picked modules to have with-pickbot enabled. This script is used as post-commit hook, passing only one argument, without the extra arguments the Qt Sanity bot on Gerrit passes, notably the one that supplies $target's value. The with-pickbot code thus got exercised in a new way, leading to a bogus warning. Change-Id: If4e035300d6017a7398e995be96e3dee2a0969ed Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* add 6.2 to LTS branches of Sanity BotDaniel Smith2022-04-221-1/+1
| | | | | | Change-Id: Icd1c306a5d691cd1888122ed153fd08c0f7234e7 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* sanitize-commit: Don't complain about "Contents/MacOS"Joerg Bornemann2021-11-261-1/+1
| | | | | | | | | Within bundles we still have a "Contents/MacOS" subdirectory despite being "incorrect terminology". Use negative look-behind to ignore "MacOS" if it's preceded by "Contents/". Change-Id: I1b8d975950f8f5f1cf916fc65f8e99642e71108a Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Match Unicode either as such or as UTF-8Edward Welbourne2021-11-151-1/+4
| | | | | | | | | | | | This is a fix-up for commit 8b17acbfde3c6f86d29e62f5de14e6b9340ac3ce; it turns out perl5, at least on our current systems, is encoding the data we're parsing in UTF-8. (Parent commit was tested with onlinegdb's version of perl, which was using naked Unicode, not UTF-8, so we may need the Unicode-form of the check, too.) Task-number: QTQAINFRA-4630 Change-Id: Ic93f9fc1d0cd1d8f6bf6ec1e695454974a84f620 Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
* Ban Unicode Bi-directional override characters from all text filesDaniel Smith2021-11-151-0/+5
| | | | | | | | | | | | | | | | | | | | Since gerrit cannot selectively disable display of unicode characters the sanity bot should give a -2 on any change which includes blacklisted unicode characters used in the bi-directional override attack vector. These characters should not appear in any reasonable code in The Qt Project. See "Trojan Source: Invisible Vulnerabilities" Authors: Nicholas Boucher and Ross Anderson, 2021 eprint: 2111.00169 archivePrefix: arXiv primaryClass: cs.CR url: https://arxiv.org/abs/2111.00169 Fixes: QTQAINFRA-4630 Change-Id: I1fbec7890239cf7ec6bb5b9f9a2f64b6a13aa60f Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Give a -1 when pick-to on a release branch lacks a pick to stable branchDaniel Smith2021-10-281-0/+8
| | | | | | | | | | | | This change should help ensure that fixes submitted directly to a release branch (often due to release crunches) make their way upstream to the stable branch. This check is limited to numerically versioned branches, 6.2.0 release branch for example has an upstream stable branch of 6.2. Change-Id: I17f6576c63a40f89802bad97111560086cce1465 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* sanitize-commit: remove override keywords from hintsOswald Buddenhagen2021-05-211-5/+5
| | | | | | | hints need no overrides by definition. Change-Id: Idd12ac9d2de56f0ab0c9939bf32814a066fa8d32 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* sanity: introduce notobjc_check flag variableTor Arne Vestbø2021-05-211-5/+4
| | | | | | | amends ac9c5658. Change-Id: I245729457f54a04eeb076ec04296827901fbd612 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* sanity: Warn when using __OBJC__ in non-Objective-C/C++ source filesTor Arne Vestbø2021-05-191-1/+9
| | | | | | | | | | The define will never be defined (unless someone explicitly passes -x to change the language the compiler uses, but we don't do that), so using the define in C/C++ source files is most likely an error and will result in dead code. Change-Id: I1eb578b76b0294ce415fce67e6665388812ae651 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Warn if something change-log-like doesn't start with [ChangeLog]Edward Welbourne2021-05-041-0/+2
| | | | | | Fixes: QTQAINFRA-4439 Change-Id: I22d5d0419a3ef4e8c3ca493124ed0d8be877dd2d Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* add 5.15 to LTS branchesOswald Buddenhagen2021-01-061-1/+1
| | | | | | | | qttranslations sticks to forward-merging rather than cherry-picking, so this still makes sense. Change-Id: I7544df15403a559ebb694e3d08e40aebfd5c2849 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Sanity-bot: Fix warning about undefined symbol $branchFriedemann Kleint2020-09-151-2/+2
| | | | | | | | | | | | | | Check on $target instead, fixing: Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at qtrepotools/git-hooks/sanitize-commit line 508. Remove excessive braces from warning message. Amends a2ebc6aedfc217e2af4b02ae97c7a598e85daff9. Task-number: QTQAINFRA-3886 Change-Id: I10224936115fb80a82b858b2784557a6f2db7cbe Reviewed-by: Daniel Smith <Daniel.Smith@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Sanity Bot: Allow branches to be globally excludedDaniel Smith2020-09-081-4/+6
| | | | | | | | | | | | | | | Occasionally, a branch may need to be globally excluded from sanity-bot review. Such is the case in refs/meta/config, which is an internal gerrit config branch, and will never conform to sanity-bot review rules. Updated syntax for excluded-projects: <project>[:<branch>] where project can be the wildcard '*' to exclude a branch from all projects. Fixes: QTQAINFRA-3880 Change-Id: I2f7fb436021a8c87bd82f3091758acff97bd3d24 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Sanity-bot: Make sure Pick-to footer doesn't contain source branchDaniel Smith2020-09-081-0/+3
| | | | | | | | | | | | The sanity bot should warn if the source branch is in the Pick-to footer since this would be redundant and cause a failed pick attempt by the cherry-pick bot. Only exact branches are matched, since it is possible to submit a change to a minor branch with a Pick-to footer that targets a bugfix branch. Fixes: QTQAINFRA-3886 Change-Id: I234d20205bd3896b7be631ba29db2efe895b9bd3 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Sanity: Exclude also testdata-* from copyright checkOrgad Shaneh2020-08-231-1/+1
| | | | | | | For example, testdata-qt in qbs/527d5a8ec54e44291d4968754bdf574ebe57822b Change-Id: I072327c111bb0ba010bc606fabf56a9ebc6c0d95 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Sanity: Exclude also testdata_ from copyright checkOrgad Shaneh2020-08-221-1/+1
| | | | | | | | | | | | https://codereview.qt-project.org/c/qt-creator/qt-creator/+/299771 added tests with directories named tests/cppmodelmanager/testdata_project1 and testdata_project2. As these directories contain test-related header files, they should not require copyright headers. Change-Id: I24ba03fbbf47dddd18d8d8d1a96498ad1301ea3a Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Allow periods in summary when 'etc' is the last wordDaniel Smith2020-08-141-1/+1
| | | | | | | | Fixes: QTQAINFRA-3866 Change-Id: I0872dc2880f3ceb60c6efeb15d72b6bf627c4051 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Sanity-bot: Add /perfdata/ to the whitelist of test data directoriesDaniel Smith2020-07-101-1/+1
| | | | | | | | | | | "perfdata" should be an accepted testdata directory name, since it's logical to separate correctness data from performance data in test directories. Fixes: QTQAINFRA-3841 Change-Id: I3b1522a58c94e5b42774ecd8b0a658c2f8936ef4 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Sanity-bot: Fix typo in commit message parserDaniel Smith2020-07-101-1/+1
| | | | | | | | | Committer name/email have never been checked for validity due to a typo. Change-Id: Ida571959bbe56d7c4ca2c0e20f50ad13dc81ce71 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Gerrit-bot: Fix use of uninitialized variable when no sanity-reviewDaniel Smith2020-07-101-1/+2
| | | | | | | | | | | | If the Sanity-bot subprocess fails to generate a suitable output with the 'Sanity-Review' label, gerrit-bot restarts the process repeatedly, spamming the change in gerrit. Check for the uninitialized variable so the warning isn't thrown. Task-number: QTQAINFRA-3841 Change-Id: I9950e3242bc043d9d986f9e046d53a6ba1fecf17 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* Treat wip branches like dev to suppress cherry-pick messagesDaniel Smith2020-05-261-1/+1
| | | | | | | | | | | | | wip/* branches don't need to be notified of missing pick-to footers since users working on wip branches should know what they're doing. Even though cherry-pick bot is enabled in an entire repo, the usefulness of sanity-checking for pick-to footers is very limited in wip branches. The easiest way around this is to treat wip branches like dev when running in gerrit. Task-number: QTQAINFRA-3751 Change-Id: I81fd427e83ebcd703f9b1700bf00367544c98a0e Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
* take advantage of now having a proper ref->sha1 mappingOswald Buddenhagen2020-05-151-3/+2
| | | | | | | this makes things marginally faster, but mostly just more consistent. Change-Id: Ifdd84b54bb541ba13c9ff1fa349e0a2479f6060f Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* add validation according to the new cherry-picking policyOswald Buddenhagen2020-05-151-11/+61
| | | | | | | | Task-number: QTQAINFRA-3663 Started-by: Daniel Smith <daniel.smith@qt.io> Change-Id: Iafa560d52cbca4bbf490694982bc3cddaea08b20 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 13:10:22 +0000