diff options
| author | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2023-06-23 21:03:53 +0200 |
|---|---|---|
| committer | Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 2023-06-27 23:17:06 +0200 |
| commit | 6953240ad901b55d321d182a114ad17bea2fd5fe (patch) | |
| tree | 5369ab64133b934d6cf0a18d366f8563e13cc9d6 /src/assistant/assistant/helpdocsettingswidget.cpp | |
| parent | cb29aaa8a7dad8ba314e1906ef08260a36cd7beb (diff) | |
Code tidies: use the 4-args connect()
The 3-arg connect to functor is frowned upon because it's easy to misuse
(deleting objects referenced by the functor will not automatically
disconnect). Port them to the 4-args connect.
Change-Id: I2341ce79afab0c7b6c038049a694f30d54d7a311
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
Diffstat (limited to 'src/assistant/assistant/helpdocsettingswidget.cpp')
| -rw-r--r-- | src/assistant/assistant/helpdocsettingswidget.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/assistant/assistant/helpdocsettingswidget.cpp b/src/assistant/assistant/helpdocsettingswidget.cpp index 67442b856..724209164 100644 --- a/src/assistant/assistant/helpdocsettingswidget.cpp +++ b/src/assistant/assistant/helpdocsettingswidget.cpp @@ -106,23 +106,23 @@ HelpDocSettingsWidget::HelpDocSettingsWidget(QWidget *parent) d->q_ptr = this; d->m_ui.setupUi(this); - connect(d->m_ui.docAddButton, &QAbstractButton::clicked, + connect(d->m_ui.docAddButton, &QAbstractButton::clicked, this, [this]() { Q_D(HelpDocSettingsWidget); d->addDocumentation(); }); - connect(d->m_ui.docRemoveButton, &QAbstractButton::clicked, + connect(d->m_ui.docRemoveButton, &QAbstractButton::clicked, this, [this]() { Q_D(HelpDocSettingsWidget); d->removeDocumentation(); }); - connect(d->m_ui.registeredDocsFilterLineEdit, &QLineEdit::textChanged, + connect(d->m_ui.registeredDocsFilterLineEdit, &QLineEdit::textChanged, this, [this](const QString &) { Q_D(HelpDocSettingsWidget); for (const auto item : d->m_namespaceToItem) d->applyDocListFilter(item); }); - connect(d->m_ui.registeredDocsListWidget, &QListWidget::itemSelectionChanged, + connect(d->m_ui.registeredDocsListWidget, &QListWidget::itemSelectionChanged, this, [this]() { Q_D(HelpDocSettingsWidget); d->m_ui.docRemoveButton->setEnabled( |