diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 12:48:24 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 20:31:47 +0000 |
commit | 2ea853ba28e359fba7f98ba1286bc5c89a48105a (patch) | |
tree | 1f4118b793162529f9f725437b5fa0da60dc9394 /src/designer/src/designer/qdesigner_actions.cpp | |
parent | 7e64a97986537fab1105385be8ce70f174ca5118 (diff) |
Qt Designer: Fix clang-tidy warnings about Qt usage
- Use multi-arg form of QString::arg()
- Fix static method calls
- Prefer QFileInfo::exists()
- Use isEmpty() for containers instead of checking size()
- Use QOverload
Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/designer/src/designer/qdesigner_actions.cpp')
-rw-r--r-- | src/designer/src/designer/qdesigner_actions.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/designer/src/designer/qdesigner_actions.cpp b/src/designer/src/designer/qdesigner_actions.cpp index 9db4b0b98..60c8ffb4b 100644 --- a/src/designer/src/designer/qdesigner_actions.cpp +++ b/src/designer/src/designer/qdesigner_actions.cpp @@ -863,7 +863,7 @@ bool QDesignerActions::writeOutForm(QDesignerFormWindowInterface *fw, const QStr box.setInformativeText(tr("The file %1 could not be opened." "\nReason: %2" "\nWould you like to retry or select a different file?") - .arg(f.fileName()).arg(f.errorString())); + .arg(f.fileName(), f.errorString())); QPushButton *retryButton = box.addButton(QMessageBox::Retry); retryButton->setDefault(true); QPushButton *switchButton = box.addButton(tr("Select New File"), QMessageBox::AcceptRole); @@ -901,7 +901,7 @@ bool QDesignerActions::writeOutForm(QDesignerFormWindowInterface *fw, const QStr box.setWindowModality(Qt::WindowModal); box.setInformativeText(tr("It was not possible to write the entire file %1 to disk." "\nReason:%2\nWould you like to retry?") - .arg(f.fileName()).arg(f.errorString())); + .arg(f.fileName(), f.errorString())); box.setDefaultButton(QMessageBox::Retry); switch (box.exec()) { case QMessageBox::Retry: |