Linguist: Replace foreach with range-based for

Change-Id: I8b1aed7bc5f4f1d14ff9db4cf7c09fbc4267246d
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 11 insertions, 8 deletions

diff --git a/src/linguist/linguist/phraseview.cpp b/src/linguist/linguist/phraseview.cpp
index 03fbc7390..9c7a4f966 100644
--- a/src/linguist/linguist/phraseview.cpp
+++ b/src/linguist/linguist/phraseview.cpp
@@ -139,7 +139,8 @@ void PhraseView::mouseDoubleClickEvent(QMouseEvent *event)
 
 void PhraseView::guessShortcut(int key)
 {
-    foreach (const Phrase *phrase, m_phraseModel->phraseList())
+    const auto phrases = m_phraseModel->phraseList();
+    for (const Phrase *phrase : phrases)
         if (phrase->shortcut() == key) {
             emit phraseSelected(m_modelIndex, phrase->target());
             return;
@@ -249,14 +250,15 @@ void PhraseView::setSourceText(int model, const QString &sourceText)
     if (model < 0)
         return;
 
-    foreach (Phrase *p, getPhrases(model, sourceText))
+    const auto phrases = getPhrases(model, sourceText);
+    for (Phrase *p : phrases)
         m_phraseModel->addPhrase(p);
 
     if (!sourceText.isEmpty() && m_doGuesses) {
-        CandidateList cl = similarTextHeuristicCandidates(m_dataModel, model,
+        const CandidateList cl = similarTextHeuristicCandidates(m_dataModel, model,
             sourceText.toLatin1(), m_maxCandidates);
         int n = 0;
-        foreach (const Candidate &candidate, cl) {
+        for (const Candidate &candidate : cl) {
             QString def;
             if (n < 9)
                 def = tr("Guess from '%1' (%2)")
@@ -275,12 +277,13 @@ void PhraseView::setSourceText(int model, const QString &sourceText)
 QList<Phrase *> PhraseView::getPhrases(int model, const QString &source)
 {
     QList<Phrase *> phrases;
-    QString f = MainWindow::friendlyString(source);
-    QStringList lookupWords = f.split(QLatin1Char(' '));
+    const QString f = MainWindow::friendlyString(source);
+    const QStringList lookupWords = f.split(QLatin1Char(' '));
 
-    foreach (const QString &s, lookupWords) {
+    for (const QString &s : lookupWords) {
         if (m_phraseDict->at(model).contains(s)) {
-            foreach (Phrase *p, m_phraseDict->at(model).value(s)) {
+            const auto phraseList = m_phraseDict->at(model).value(s);
+            for (Phrase *p : phraseList) {
                 if (f.contains(MainWindow::friendlyString(p->source())))
                     phrases.append(p);
             }