diff options
| author | Johan Klokkhammer Helsing <johan.helsing@qt.io> | 2019-09-02 10:45:20 +0200 |
|---|---|---|
| committer | Johan Klokkhammer Helsing <johan.helsing@qt.io> | 2019-09-02 11:35:12 +0200 |
| commit | f3668f88ccad6341280fbe2ca493562f80e76955 (patch) | |
| tree | abfdb27cea92dd675732c61ed94fe7b8e2425a9e /src/client/qwaylandinputdevice_p.h | |
| parent | aa54ad2d6e8fa5d0357bcadaf9b5a679c358728f (diff) | |
Client: Fix crash on wl_pointer.up after destroying a window
When wl_pointer version 5 was implemented, we added a raw QWaylandWindow
pointer in QWaylandPointerEvent. This is a problem, because the events
are stored, and the window may be deleted in the meantime.
This manifested itself as flakiness in tst_xdgshell::popup() which is
now fixed.
Fixes: QTBUG-77976
Change-Id: If34eee0286d5a63734535d67503378516d5768c3
Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
Diffstat (limited to 'src/client/qwaylandinputdevice_p.h')
| -rw-r--r-- | src/client/qwaylandinputdevice_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/qwaylandinputdevice_p.h b/src/client/qwaylandinputdevice_p.h index 4ac1dca35..7fbb5667f 100644 --- a/src/client/qwaylandinputdevice_p.h +++ b/src/client/qwaylandinputdevice_p.h @@ -446,7 +446,7 @@ public: QPoint pixelDelta; QPoint angleDelta; Qt::MouseEventSource source = Qt::MouseEventNotSynthesized; - QWaylandWindow *surface = nullptr; + QPointer<QWaylandWindow> surface; }; } |